Deleting a row with a form

130zewe

I am trying to delete a user from my guestbook login. I am getting a T_parser error on the "$form.="<input type=\"submit\" value=\"Submit\">";" line. This is the modified code I used for my add user script. Can some please help or point me to a form that works. I want to be able to delete the whole row ("First Name","Last Name","User Name", and "Password" by just entering in the user ID. Thanks in advance.

<?php
if((!$user_name))
{
$form ="<b>Please enter in all the new user information...</b><br><br>";
$form.="<form action=\"$PHP_SELF\"";
$form.=" method=\"post\"><br><br>User Name: ";
$form.="<input type=\"text\" name=\"user_name\"";
$form.=" value=\"$user_name\">;
$form.="<input type=\"submit\" value=\"Submit\">";
$form.="</form>";
echo($form);
}
else
{
#connect to MySQL
$conn = @mysql_connect("localhost","takach","")
or die("Could not connect to MySQL");
#select a database
$db = @mysql_select_db("takach",$conn)
or die("Could not select database");
#create the SQL query
$sql = "delete from users (first_name,last_name,user_name,password)
values (\"$first_name\",\"$last_name\",\"$user_name\",password(\"$password\") )";
#execute the query
$result = @($sql,$conn)
or die("Could not execute query");
if($result)
{
$msg ="User $user_name deleted";
}
}
echo($msg);
?>

paulnaj

Hi 130zewe, welcome to the forums.

I use single quotes for strings and don't embed variables ... it's much easier on the old eyeballs when trying to debug 😉

Also good for HTML. And you don't necessarily need to use $form .= either.

You could just do ...

<?php
$form = '
<b>Please enter in all the new user information...</b><br><br>
<form action="'.$_SERVER['PHP_SELF'].'" method="post"><br><br>
User Name: <input type="text" name="user_name" value="'.$user_name.'">
<input type="submit" value="Submit">
</form>
';
?>

It's all personal preference, I suppose, (lots of articles/tutorials seem to do it your way) but I think the above's much better for a lot of reasons.

Also, $PHP_SELF relies on the host's configuration and is deprecated (not to be relied upon in the future) so you should always use $_SERVER['PHP_SELF'] instead, which does the same job.

Paul 🙂

Edited for typo.