Debugging php help needed.....

aaa123

Hi,

I am having trouble getting this to work....here is the code below....it suppose to be a event driven code....the table(userProfile) is already created.....when you click the first radio button it pushes 1 into the table or else it pushes 2 into the table. But, for some reason the (if...else) structure is failing or it 3:00am in the morning and I am not seeing it.

<?php
/ Connecting, selecting database /
$link = mysql_connect(localhost , team03 , team03) or die("Could not connect");
mysql_select_db(newsreader) or die("Could not select database");
?>

<td><font class="smallblue">Select News Type:</td> // below is where the radio buttons are being created, the name have to be the same
<td align=center width=10%><font class=medblue><input type=radio class=schedule name="R1" value="International News"><br>International News</td>
<td align=center width=10%><font class=medblue><input type=radio class=schedule name="R1" value="Sports News"><br>Sports News</td>

      <?php
                mysql_query("DELETE FROM userProfile");   // I am doing this b/c I want to remove the row, so that it will always be 1 row and not grow
                $query = "INSERT INTO userProfile (choice) VALUES ('1')";
                $result = mysql_query($query, $link);
      ?>

}
else
{
alert("You have selected to receive Sports News on your PDA");

     <?php
             mysql_query("DELETE FROM userProfile");    // I am doing this b/c I want to remove the row, so that it will always be 1 row and not grow
                $query = "INSERT INTO userProfile (choice) VALUES ('2')";
                $result = mysql_query($query, $link);
     ?>
 }

</script>

<td class="mainftr" colspan="0" align="center">
<input type="hidden" name="pcount" value="1">
Click to save your setting:
<input class="submit" type="submit" name="process_reminder" value="Save Preferences" onclick = "save()"> //javascript is call here when the Save button is clicked
</form>
</tr></table>

<?php
/ Closing connection /
mysql_close($link);
?>

Ok...I am going to bed now.

Thanks
aaa123

tsinka

Hi,

PHP is a server side language. You can't do it in that way.

Move the PHP blocks that do the insert queries on top of the script. Remove the JavaScript code and add some code to the PHP script that checks if
$POST['process_reminder'] is set (the form has been submitted). If that is the case check which value $POST['R1'] and if it is set at all (any radio button has been checked). Depending on the value of $_POST['R1'] execute the INSERT queries.

Thomas

aaa123

follow your example, but it didn't work

what I am doing wrong

<?php
if (!isset($_POST['submit']))
{
echo '<form name = "form" method = "Post">

<td><font class="smallblue">Select News Type:</td>
<td align=center width=10%><font class=medblue><input type=radio class=schedule name="R1" value="International News"><br>International News</td>
<td align=center width=10%><font class=medblue><input type=radio class=schedule name="R1" value="Sports News"><br>Sports News</td>
<td class="mainftr" colspan="0" align="center">
<input type="hidden" name="pcount" value="1">
Click to save your setting:
<input class="submit" type="submit" name="process_reminder" value="Save Preferences" onclick = "save()">
</form>
</tr></table>';
}
else
{
// do all the form handling stuff here:

// connect to the database

$link = mysql_connect(localhost , team03 , team03) or die("Could not connect");
mysql_select_db(newsreader) or die("Could not select database");

  if($_POST['R1[0]'] == 1)
  {
          mysql_query("DELETE FROM userProfile");
          $query = "INSERT INTO userProfile (choice) VALUES ('1')";
          $result = mysql_query($query, $link);
  }
  else
  {
          mysql_query("DELETE FROM userProfile");
          $query = "INSERT INTO userProfile (choice) VALUES ('2')";
          $result = mysql_query($query, $link);
  }

mysql_close($link);

}
?>

tsinka

<?PHP
if (!isset($_POST['process_reminder'])) {
?>
<form name="form" method="post">
<input type="hidden" name="pcount" value="1">
<table>
  <tr>
    <td>
      <font class="smallblue">Select News Type:
    </td>
    <td align="center" width="10%">
      <font class="medblue">
        <input type="radio" class="schedule" name="R1" value="1"><br>International News
      </font>
    </td>
    <td align="center" width="10%">
      <font class="medblue">
        <input type=radio class=schedule name="R1" value="2"><br>Sports News
      </font>
    </td>
    <td class="mainftr" align="center">
      Click to save your setting:
      <input class="submit" type="submit" name="process_reminder" value="Save Preferences">
    </td>
  </tr>
</table>
</form>
<?PHP
} else {
  // do all the form handling stuff here:
  // connect to the database
  $link = mysql_connect(localhost , team03 , team03) or die("Could not connect");
  mysql_select_db(newsreader,$link) or die("Could not select database");

  $validChoices = array(1,2);

  if (isset($_POST['R1']) && in_array($_POST['R1'],$validChoices)) {
    mysql_query('DELETE FROM userProfile',$link);
    $query = "INSERT INTO userProfile (choice) VALUES ('".$_POST['R1']."')";
    mysql_query($query,$link) or die("SQL error: ".mysql_error());
  } else {
    echo "invalid/no news selected";
  }
}
?>

Question: You're deleting all rows from userProfile. Is that what you want to do ? I think the WHERE clause is missing in both the DELETE and the INSERT query. What if someone wants to subsribe to all news ?

Thomas

aaa123

thank you very much for you help.....I am new to php

there is a lot of stuff in your code that I did not understand what they are doing like the following lines...

(!isset($POST['process_reminder']
isset($POST['R1']
$validChoices = array(1,2);
in_array($POST['R1'],$validChoices)
".$POST['R1']."

Can you suggest a book that I can read or study or website that will be good for novices like myself.

Thanks
aaa123