[Resolved] Problem with printing fetched rows

[Tad]

This one is pretty straightforward I think... the coding is slightly different since it's for a mod for InvisionBoard, but I think it's similar enough.

Anyway, here's my problem. I have a query - which works. However, if the query finds 3 results, only the latest one with the highest ID will be printed and not all three. I don't know if there's a problem with my while or what. I just need a fresh set of eyes on the problem. Here's the short code.

    $DB->query("SELECT T1.firstname,T1.lastname,T1.charID FROM ibf_character_registry T1,ibf_character_species T2 
	WHERE T1.userID='".$member['id']."' and T1.speciesID = T2.speciesID and T1.pending = 1");

$x = $DB->get_num_rows();

if ($x > 0)
{
	while ($row = $DB->fetch_row())
	{
		$info['personalist']   = "<a href='$url=$row[charID]'>$row[firstname] $row[lastname]</a> $x<br />";
	}
}

else
{
    $info['personalist']  = 'No characters';
}

[tsinka]

Hi,

the problem is that you're just overwriting $info['personalist'] over and over.

Do something like this:

if ($x > 0)
{
    while ($row = $DB->fetch_row())
    {
        $info['personalist'][]   = "<a href='$url=$row[charID]'>$row[firstname] $row[lastname]</a> $x<br />";
    }
}

else
{
    $info['personalist'][]  = 'No characters';
}

And then something like:

foreach ($info['personalist'] as $value) {
  echo $value;
}

// or e.g.
echo implode("\n",$info['personalist']);

To improve readabiliby of the code do e.g.

$avar = 'somestring '.$row['column'].' some other string';

//instead of 

$avar = "somestring $row[column] some other string";

Thomas

[Tad]

Thanks for your reply. 🙂 I actually wound up solving it another way. Just by changing:

$info['personalist'] = "<a href='$url=$row[charID]'>$row[firstname] $row[lastname]</a> $x<br />";

to

$info['personalist'] .= "<a href='$url=$row[charID]'>$row[firstname] $row[lastname]</a><br />";

so that it concatenates. Thanks again though. 🙂