help with looping please

[yellowchimp]

I have this bit of code

<?
$row = odbc_fetch_array($result);
if (count($row)>1)
{

//NEED TO FIGURE OUT HOW TO MAKE IT LOOP HERE - WORKS BUT ONLY BRINGS UP FIRST RECORD!!!!!!!!!

{ echo
"
<table class=results>
<tr>
<td class=year>" .$row['doc_date_yr'] . "</td>
<td class=title><a href=" . $row['doc_url'] . " target=blank>" . $row['doc_title'] . "</a></td>
</tr>
</table>";

}

}
else
{
echo 'sorry search again';
}
}

basically if there are records to display I want it to display then all. If there aren't I want it to say sorry search again - that bit works.
And it does recognise when there are records to display because it displays the first one. However it stops at that. I want it to display them all so I think I have to do some kind of loop.

Can't figure out exactly how to do it though :-(

[nunomira]

hi,

I'm not familiar with [man]odbc_fetch_array()[/man], but with [man]mysql_fetch_array()[/man] you do:

while ($row = mysql_fetch_array($result))
{
 // do something
}

The while() creates the loop you need.

[yellowchimp]

thanks
but that still doesn;t work. What happens now is - I get the 'sorry please search again' thing all the time now. Even when I know that there should definitely be some records returned. This is how my code looks now:

if (count($row)>=1)

//so have put while in to create a loop
while ($row = odbc_fetch_array($result))

{

echo
"
<table class=results>
<tr>
<td class=year>" .$row['doc_date_yr'] . "</td>
<td class=title><a href=" . $row['doc_url'] . " target=blank>" . $row['doc_title'] . "</a></td>
</tr>
</table>";

}

else
{
echo "sorry search again";
}
}

[yellowchimp]

Hi

I have kind of got it working now. But something is still wrong.

If I have more than one record returned - all the records are displayed correctly.

If I have no records returned - it says - sorry search again - which os what I want

However if there is only one record returned 0 it does nothing - it doesn't display it and it doesn't say sorry.

I know I have put >1 so thats why. But if I put >0 then things don't work right either :-(

This is my code

$row = odbc_fetch_array($result) ;

if (count($row)>1)
//so have put while in to create a loop
while ($row = odbc_fetch_array($result))

{

echo
"
<table class=results>
<tr>
<td class=year>" .$row['doc_date_yr'] . "</td>
<td class=title><a href=" . $row['doc_url'] . " target=blank>" . $row['doc_title'] . "</a></td>
</tr>
</table>";

}

else
{
echo "sorry search again";
}
}

[nunomira]

Your code is starting to get too confusing.

Using [man] odbc_fetch_array()[/man] and then [man]odbc_fetch_array()[/man] again isn't required (and I'm sure it's not a good idea).

I'm not sure about this, but maybe you move the internal pointer of the array by using [man] odbc_fetch_array()[/man] twice, and that's why you don't get anything when there is only one result. When there is more than one, see if the first isn't missing.

In mysql, [man]mysql_data_seek()[/man] is used to move the pointer... don't know which function is used with odbc.
Don't know if [man]reset()[/man] can be used.

You don't need to use [man]count()[/man]. There is [man]mysql_num_rows()[/man] so I see that [man]odbc_num_rows()[/man] is available.

[yellowchimp]

I have basically got my code down to this. I just need to have a bit on the end which says that if there are no results then 'sorry search again' should display.
I am finding that the only way I can get this to print out is if I have
if (count($row)>=1) at the end - this means though that 'sorry search again is at the bottom of the page even if there are results - obviously becuase of the >=1 bit. I don't understand why no results fit into >=1. Surely it should be <1 or ==0. Any suggestions greatly appreciated. I am getting mighty frustrated and fed up :-(

<?
{

while ($row = odbc_fetch_array($result))

{

echo
"
//results displayed here
''
}

}

//need to put something here to say if there are no results to echo search again

{ echo
" sorry search again";
}

[nunomira]

Doesn't odbc_num_rows() work? Why?

I guess you can use this logic instead:

<?php
// start with false
$results_found = false;
while ($row = odbc_fetch_array($result))
{
	// code here...

// as results were found, change $results_found to true
$results_found = true;
}

// if no results were found
if (!$results_found)
{
	echo 'sorry search again';
}
?>

[abnfire]

i was reading your post, to let you know, that i never used any odbc functions before, but this code will work. my version:

$row = odbc_fetch_array($result) ; 

if (count($row)>1) {
//so have put while in to create a loop 
     do { 
          echo 
          " 
          <table class=results> 
          <tr> 
          <td class=year>" .$row['doc_date_yr'] . "</td> 
          <td class=title><a href=" . $row['doc_url'] . " target=blank>" . $row['doc_title'] . "</a></td> 
          </tr> 
          </table>"; 
     }   while ($row = odbc_fetch_array($result)) 

} else { 
     echo "sorry search again"; 
} 

this is your code i modified little bit.

[yellowchimp]

thank you

I have had to tweak your code to get it to work a little bit. But I am back at square one - with it working ok except for instances when only one result/row is pulled back from the database. In this instance noting displays - because of putting >1
if I put >=1 then the instances when one result/row is pulled from the database and when no results are pulled from the database both display nothing - no results and no ' sorry please search again'.

$row = odbc_fetch_array($result);

if (count($row)>1)

{  while ($row=odbc_fetch_array($result))
echo 
" 
<table class=results>
<tr>
<td class=year>" .$row['doc_date_yr'] . "</td>
<td class=title><a href=" . $row['doc_url'] . " target=blank>" . $row['doc_title'] . "</a></td>
</tr>
</table>
";  
} 		

else {
echo
" sorry search again";
}

}

[yellowchimp]

dear Nunomira

Thank you very very much
It works.
Don't know how or why

thank you sooo much

[nunomira]

Great!
🙂