Endless loop

[nickk]

hi,

I made a script that adds users and ad's to a classified advert system without using the script provided (so that I can register large amounts of users from a text file, but thats not the issue). I am pretty sure that I might have entered one of the fields wrong and thats why I get this error. Alot of times when a certain function is called

function q($aSQL)
{
	include "admin/config/general.inc.php";
	include "admin/db.php";
	//$aSQL = safeString($aSQL);
	$res = mysql_query($aSQL) or die(failMsg("Invalid MySql query", mysql_error()));

return $res;	
}

it goes into an endless loop that uses allmost 100% of my pc's resources until it stops (max execution time). Now there are alot of sql statements that use that function, some of them are included below. What I would like help with is the identification of which of the following statements could cause this, so I could try to figure out which field, etc causes the problem.
Some examples:
$sql = "select count(siteid) from $ads_tbl where ad_username = '$valid_user'"
$sql = "select count(siteid) from $ads_tbl where ad_username = '$valid_user' AND sold=1"
$sql = "select sum(sitehits) from $ads_tbl where ad_username = '$valid_user'"

There are many more statements that could cause this, but could anyone tell me what could potentially cause this, as it has cost me some monye allready and is a big hassel.

Thanks, Nick

[nemonoman]

SQL statements will never cause an endless loop. You need to look for a while loop (might be an until loop) that never achieves a true condition.

Most typical is forgetting to increment a counter.

$counter=0;
$timesToDoSomething=1;
while ($counter<$timesToDoSomething){
$x=$y;
}

See what's missing?

$counter++; is missing.