I've run into an issue using PHP, Javascript, and Strings

jmcivor

I'm writing a document that automatically lists images and ringtones. It works great, but I'm also trying to add a Preview option for the midi ringtones and that is where my problem is coming in. I'm using a javascript popup that jumps up when the user clicks the preview link, its a dynamically created document that display the embedded midi file, well, its supposed to...

Here, check out my code:


//////This is the javascript function I'm using to call the popup/////
<script language ="javascript">
function dirtypop()
{
  var generator=window.open('','name','height=50,width=200');


  generator.document.write('<link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" 

type="text/css">');
  generator.document.write('<embed src="$file" height=40 width=160>');
  generator.document.write('<p><center><a href="javascript:self.close()">Close</a> this window.</center></p>');
  generator.document.write('</body></html>');
  generator.document.close();
}
</script>
/////////////////////////////////////////////////////////////////

<?php

$handle=opendir("./");
$n = 0;
$filecount;

while (false !== ($file = readdir($handle))) 
{ 
$ext = strtolower(strstr($file, '.'));

///////////////////////////////////////////////////
//count files//////////////////////////////////////
///////////////////////////////////////////////////

if ($ext == ".jpeg")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".bmp")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".jpg")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".gif")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".imy")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".emy")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".midi")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".mid")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".mp3")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".wav")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".zip")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".thm")
{
$n++;
$filecount=$filecount+1;
}

}

//Post FileCount at top of page////////////////////
echo "<body>$filecount Files Found<br><br></body>";
///////////////////////////////////////////////////

///////////////////////////////////////////////////
//List Files///////////////////////////////////////
///////////////////////////////////////////////////

$handle=opendir("./");
$n = 0;
while (false !== ($file = readdir($handle))) 

{ 
$ext = strtolower(strstr($file, '.'));

if ($ext == ".bmp")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".jpeg")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".jpg")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".gif")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".imy")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".emy")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".midi")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

///////This section is the culprit that refuses to work properly//////
if ($ext == ".mid")
{
echo " <a href='$file'>$file</a> | <a href='javascript:dirtypop();'>Preview Ringtone</a><br>";
$n++;
}
/////////////////////////////////////////////////////////////////////////////////

if ($ext == ".mp3")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".wav")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".zip")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".thm")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

}

echo("\n");
closedir($handle); 

?>

Now, this whole document works great except the popup part, it pops up, looks all pretty and perfect, but it refuses to link to the variable specified in the source called "$file". Everything else accepts this variable and uses it properly accept the popup one (you'll notice it 2/3rds the way down the source in the .mid area.) It pops up the window perfectly but wont link to the midi file, When I ViewSource with internet explorer on the popup window it shows me that the embed option is actually trying to embed $file and not the filename held in $file, it is assuming that $file is the actual file name. To see what I mean, just paste this source code into notepad and save it as a php document, then put it in the same folder as a midi file (or 2 or 3 or whatever) and it will give you 2 options for each song, download, or preview, click preview, you'll get the popup, then right click and view source, you'll see what I mean.

Please help! Im so stumped!

tsinka

Hi,

modify your code a little bit. PHP is a server side script language so you need to add an argument to the javascript function:

....
<script language ="javascript">
function dirtypop(file) {
....
generator.document.write('<embed src="'+file+'" height=40 width=160>');
...
}
</script>
....
.....
echo '<a href="'.$file.'">'.$file.'</a> | <a href="javascript:dirtypop('."'$file'".')">Preview Ringtone</a><br>';
....

for some reason "javascript" gets displayed as "java script" in the code above.

EDIT: make sure to write a complete page HTML code in the javascript function
<html>
<head>
<title>..</title>
<link rel ...>
</head>
<body>
...
<embed src....>
</body>
</html>

Thomas

jmcivor

Thanks for the swift reply 🙂

I did exactly what you said (pretty sure), I editted my code as per your directions, and also made it fill in all the proper html for the document. I'm brand new to PHP, so sorry if I miss something obvious 🙂

Now i get the following Error:

Parse error: parse error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ',' or ';'
in /home/jlm/public_html/wap/tones/polytones/50s_60s_70s_80s/
dynamiclist.php on line 179

Here is the full code after your suggestions:

<script language ="javascript">
function dirtypop(file)
{
  var generator=window.open('','Preview','height=50,width=200');
  generator.document.write('<html>');
  generator.document.write('<head></head>');
  generator.document.write('<link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" 

type="text/css">');
  generator.document.write('<body>');
  generator.document.write('<embed src="'+file+'" height=40 width=160>');
  generator.document.write('<center><br><a href="javascript:self.close()">Close</a> this window.</center>');
  generator.document.write('</body></html>');
  generator.document.close();
}
</script>

<?php

$handle=opendir("./");
$n = 0;
$filecount;
$TheFile;

while (false !== ($file = readdir($handle))) 
{ 
$ext = strtolower(strstr($file, '.'));




///////////////////////////////////////////////////
//count files//////////////////////////////////////
///////////////////////////////////////////////////

if ($ext == ".jpeg")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".bmp")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".jpg")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".gif")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".imy")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".emy")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".midi")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".mid")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".mp3")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".wav")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".zip")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".thm")
{
$n++;
$filecount=$filecount+1;
}

}

//Post FileCount at top of page////////////////////
echo "<body>$filecount Files Found<br><br></body>";
///////////////////////////////////////////////////

///////////////////////////////////////////////////
//List Files///////////////////////////////////////
///////////////////////////////////////////////////

$handle=opendir("./");
$n = 0;
while (false !== ($file = readdir($handle))) 

{ 
$ext = strtolower(strstr($file, '.'));

if ($ext == ".bmp")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".jpeg")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".jpg")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".gif")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".imy")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".emy")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".midi")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".mid")
{
echo " <a href="'.$file.'">$file</a> | <a href='javascript:dirtypop('."'$file'".');'><b>Preview Ringtone</b></a><br>";
$n++;
}

if ($ext == ".mp3")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".wav")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".zip")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".thm")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

}


echo("\n");
closedir($handle); 

?>

planetsim

<script language ="javascript">
function dirtypop(file)
{
  var generator=window.open('','Preview','height=50,width=200');
  generator.document.write('<html>');
  generator.document.write('<head></head>');
  generator.document.write('<link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" 

type="text/css">');
  generator.document.write('<body>');
  generator.document.write('<embed src="'+file+'" height=40 width=160>');
  generator.document.write('<center><br><a href="java script:self.close()">Close</a> this window.</center>');
  generator.document.write('</body></html>');
  generator.document.close();
}
</script>

<?php

$handle=opendir("./");
$n = 0;
$filecount = 0;
$TheFile = null;

while (false !== ($file = readdir($handle))) 
{ 
$ext = strtolower(strstr($file, '.'));




///////////////////////////////////////////////////
//count files//////////////////////////////////////
///////////////////////////////////////////////////

if ($ext == ".jpeg")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".bmp")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".jpg")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".gif")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".imy")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".emy")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".midi")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".mid")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".mp3")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".wav")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".zip")
{
$n++;
$filecount=$filecount+1;
}

if ($ext == ".thm")
{
$n++;
$filecount=$filecount+1;
}

}

//Post FileCount at top of page////////////////////
echo "<body>$filecount Files Found<br><br></body>";
///////////////////////////////////////////////////

///////////////////////////////////////////////////
//List Files///////////////////////////////////////
///////////////////////////////////////////////////

$handle=opendir("./");
$n = 0;
while (false !== ($file = readdir($handle))) 

{ 
$ext = strtolower(strstr($file, '.'));

if ($ext == ".bmp")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".jpeg")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".jpg")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".gif")
{
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>";
$n++;
}

if ($ext == ".imy")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".emy")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".midi")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".mid")
{
echo " <a href='".$file."'>$file</a> | <a href='java script:dirtypop('".$file."');'><b>Preview Ringtone</b></a><br>";
$n++;
}

if ($ext == ".mp3")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".wav")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".zip")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

if ($ext == ".thm")
{
echo " <a href='$file'>$file</a><br>";
$n++;
}

}


echo("\n");
closedir($handle); 

?>

Try that there were a few errors in there like an declared variable without a value, PHP is unlike other language if you declare a variable it must have some sort of value

$content; will not work so $content = 0; or $content = ''; even $content=null; would be sufficient. This is different to other languages like java/c etc where you can declare it and not give it a value.

jmcivor

Ok that seemed to fix the php document generation error, but now its only passing part of the needed string. I took a quick screenshot to show you:

You can see where it cuts it off. I used your code exactly, but with my own css call and javascript for ensuring only members access the area. I'll paste the whole thing in here for you:

<SCRIPT LANGUAGE="JavaScript">
	if(parent.frames.length==0){
	if(document.referrer.indexOf("jmcivor.com/")==-1
	){
	window.location.href="http://www.jmcivor.com/portal/modules.php?op=modload&name=PostWrap&file=index&page=WAPSITE";
	}
	}
</script>

<link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" type="text/css">

<script language ="javascript"> 
function dirtypop(file) 
{ 
  var generator=window.open('','Preview','height=50,width=200'); 
  generator.document.write('<html>'); 
  generator.document.write('<head></head>'); 
  generator.document.write('<link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" 

type="text/css">'); 
  generator.document.write('<body>'); 
  generator.document.write('<embed src="'+file+'" height=40 width=160>'); 
  generator.document.write('<center><br><a href="java script:self.close()">Close</a> this window.</center>'); 
  generator.document.write('</body></html>'); 
  generator.document.close(); 
} 
</script> 

<?php 

$handle=opendir("./"); 
$n = 0; 
$filecount = 0; 
$TheFile = null; 

while (false !== ($file = readdir($handle)))  

{  

$ext = strtolower(strstr($file, '.')); 




/////////////////////////////////////////////////// 
//count files////////////////////////////////////// 
/////////////////////////////////////////////////// 

if ($ext == ".jpeg") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

if ($ext == ".bmp") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

if ($ext == ".jpg") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

if ($ext == ".gif") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

if ($ext == ".imy") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

if ($ext == ".emy") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

if ($ext == ".midi") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

if ($ext == ".mid") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

if ($ext == ".mp3") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

if ($ext == ".wav") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

if ($ext == ".zip") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

if ($ext == ".thm") 
{ 
$n++; 
$filecount=$filecount+1; 
} 

} 

//Post FileCount at top of page//////////////////// 
echo "<body>$filecount Files Found<br><br></body>"; 
/////////////////////////////////////////////////// 

/////////////////////////////////////////////////// 
//List Files/////////////////////////////////////// 
/////////////////////////////////////////////////// 

$handle=opendir("./"); 
$n = 0; 
while (false !== ($file = readdir($handle)))  

{  

$ext = strtolower(strstr($file, '.')); 

if ($ext == ".bmp") 
{ 
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>"; 
$n++; 
} 

if ($ext == ".jpeg") 
{ 
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>"; 
$n++; 
} 

if ($ext == ".jpg") 
{ 
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>"; 
$n++; 
} 

if ($ext == ".gif") 
{ 
echo " <a href='$file'>$file<br><img src='$file'></a><br><br>"; 
$n++; 
} 

if ($ext == ".imy") 
{ 
echo " <a href='$file'>$file</a><br>"; 
$n++; 
} 

if ($ext == ".emy") 
{ 
echo " <a href='$file'>$file</a><br>"; 
$n++; 
} 

if ($ext == ".midi") 
{ 
echo " <a href='$file'>$file</a><br>"; 
$n++; 
} 

if ($ext == ".mid") 
{ 
echo " <a href='".$file."'>$file</a> | <a href='java script:dirtypop('".$file."');'><b>Preview Ringtone</b></a><br>"; 
$n++; 
} 

if ($ext == ".mp3") 
{ 
echo " <a href='$file'>$file</a><br>"; 
$n++; 
} 

if ($ext == ".wav") 
{ 
echo " <a href='$file'>$file</a><br>"; 
$n++; 
} 

if ($ext == ".zip") 
{ 
echo " <a href='$file'>$file</a><br>"; 
$n++; 
} 

if ($ext == ".thm") 
{ 
echo " <a href='$file'>$file</a><br>"; 
$n++; 
} 

} 


echo("\n"); 
closedir($handle);  

?>

planetsim

try using javascript: instead of java script

jmcivor

woops you mentioned that earlier, the forum spaces it for some reason. i fixed that, now it just sends the string:
javascript:dirtypop(); - mouseover
Error on page. - after click

jmcivor

woops my bad, the dirtypop function had an error in it. I fixed it and now the popup is popping up, but the embed function is still treating $file as a file to embed, not as a variable. here is the view source on the popup:

<html><head></head><link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" type="text/css"><body><embed src=".$file." height=40 width=160><center><br><a href="java script:self.close()">Close</a> this window.</center></body></html>

I've tried replacing the variable with the following:
$file
"$file"
' "$file" '
" '$file' "

tsinka

Ok,

post the function again. But basically don't use $ with variable names inside the javascript part. You need to use the javascript syntax, something like

document.write('somecodesomecode'+file+'morecodemorecode');

Thomas

jmcivor

ok. hereis what I have for the function currently:

function dirtypop() 
{ 
  var generator=window.open('','Preview','height=50,width=200'); 
  generator.document.write('<html>'); 
  generator.document.write('<head></head>'); 
  generator.document.write('<link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" 

type="text/css">'); 
  generator.document.write('<body>'); 
  generator.document.write('<embed src="<?php echo "$file";?>" height=40 width=160>'); 
  generator.document.write('<center><br><a href="java script:self.close()">Close</a> this window.</center>'); 
  generator.document.write('</body></html>'); 
  generator.document.close(); 
} 
</script>

This script results in this:

<html><head></head><link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" type="text/css"><body><embed src="" height=40 width=160><center><br><a href="java script:self.close()">Close</a> this window.</center></body></html>

Notice how embed src is an empty string for some reason.

Now this is the function with +file+ replacing $file:

<script language ="javascript"> 
function dirtypop() 
{ 
  var generator=window.open('','Preview','height=50,width=200'); 
  generator.document.write('<html>'); 
  generator.document.write('<head></head>'); 
  generator.document.write('<link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" 

type="text/css">'); 
  generator.document.write('<body>'); 
  generator.document.write('<embed src="+file+" height=40 width=160>'); 
  generator.document.write('<center><br><a href="java script:self.close()">Close</a> this window.</center>'); 
  generator.document.write('</body></html>'); 
  generator.document.close(); 
} 
</script>

resulting in:

<html><head></head><link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" type="text/css"><body><embed src="+file+" height=40 width=160><center><br><a href="java script:self.close()">Close</a> this window.</center></body></html>

This php stuff can be frustrating lol. I've been working on this one problem for 6 hours now. (rubs eyes)

tsinka

<script language ="javascript"> 
function dirtypop(file) 
{ 
  var generator=window.open('','Preview','height=50,width=200'); 
  generator.document.write('<html>'); 
  generator.document.write('<head></head>'); 
  generator.document.write('<link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" type="text/css">'); 
  generator.document.write('<body>'); 
  generator.document.write('<embed src="'+file+'" height=40 width=160>'); 
  generator.document.write('<center><br><a href="java script:self.close()">Close</a> this window.</center>'); 
  generator.document.write('</body></html>'); 
  generator.document.close(); 
} 
</script>

jmcivor

<html><head></head><link rel="stylesheet" href="http://jmcivor.com/portal/themes/Bitrate2/style/styleNN.css" type="text/css"><body><embed src="undefined" height=40 width=160><center><br><a href="java script:self.close()">Close</a> this window.</center></body></html>

Undefined??? lol
Well it seems we've made a bit of progress, i guess.... lol.

for some reason, its not accepting, or its emptying the $file value prior to feeding it through the javascript function.

This is weird because the function right before it :

//Works fine with the value, returns it to the document properly.
echo " <a href='".$file."'>$file</a>

//This function takes place immediately after, on the same
//line even, yet it ignores the value. Whats up with that!?
<a href='javascript:dirtypop()'><b>Preview Ringtone</b></a><br>";

Any ideas as to why it would do this?

tsinka

Check my first post ... you need to change the link itself, too, to add the function argument to the javascript function call. But make sure to type javascript instead of java script. For some reason javascript gets displayed as java script after submitting a post to PHPBuilder.

jmcivor

wow its working! and it appears your first reply was the answer... dont I feel stupid, I thought I tried it and I swear I remember making sure java script was javascript, but my last posts proves that wrong. Thanks alot!