Form and Connecting to database

Numskull

Hi all

Form:
The form is used for entering login information for a database. When the user has entered his information and clicked the "Save" button a database script is called.

Script:
The script first purpose is to validate if the user has entered any information into the form at all, that is no blank fields allowed. If information has been entered into the form fields the script connect to the database. However, as soon as i launch the page with the form, the script try to make a connection to the database, and fails since no information has yet been entered into the form. What do I do?

Form from main page:
<body>
<form action="" method="post">
DBName:<input type="text"
name="dbname" size="" value="" />
DB Host:<input type="text" name="dbhost" size="" value="" />
User Name:<input type="text" name="dbuser" size="" value="" />
Password:<input type="text" name="dbpswd" size="" value="" />
<input type="submit" name="submit" value="Save" />
</form>
<?php
include "../www/lib/sql.createtables.php";
?>

Script:
<?php
if (isset($POST['submit']))
$dbname=$POST['dbname'];
$dbhost=$POST['dbhost'];
$dbuser=$POST['dbuser'];
$dbpswd=$_POST['dbpswd'];

Here shoud be some conditional statements.

@mysql_connect($dbhost,$dbuser,$dbpswd)
or die("could not connect to MySQL server!");
@mysql_select_db($dbname)
or die("could not select MySQL database!");
echo 'Connection succeded!';
mysql_close();

uffis

You must check that the user actually sent the form by pressing the button Save before connecting to the database. Simplified, you can do that with

if (isset($_POST['submit']))
{
  // process the form,
  // do DB queries etc.
}

You may also want to include any DB files only when the form processing went well.

Numskull

Thanks a lot :p

Peredy

I see that this is an old thread, but I am making something like this that will add the table when the info is added. I used what you had above (I hope that was okay) but it wont add the table. Can you tell me what is missing?

</body>
</html>



<?php 
if (isset($_POST['submit'])) 
{ 
$dbname=$_POST['dbname']; 
$dbhost=$_POST['dbhost']; 
$dbuser=$_POST['dbuser']; 
$dbpswd=$_POST['dbpswd']; 

$query = 'CREATE TABLE `schedule` ('
        . ' `id` INT(11) NOT NULL AUTO_INCREMENT, '
        . ' `bsdate` DATE DEFAULT "0000-00-00" NOT NULL, '
        . ' `bstime` VARCHAR(10) NOT NULL, '
        . ' `bsvenue` VARCHAR(150) NOT NULL, '
        . ' `bslocation` VARCHAR(150) NOT NULL, '
        . ' `bsbandlistings` VARCHAR(255) NOT NULL, '
        . ' `bsdetails` VARCHAR(255) NOT NULL, '
        . ' `bsflyer` VARCHAR(100),'
        . ' PRIMARY KEY (`id`)'
        . ' )'; 






@mysql_connect($dbhost,$dbuser,$dbpswd) 
or die("could not connect to MySQL server!"); 
@mysql_select_db($dbname) 
or die("could not select MySQL database!"); 
echo 'Connection succeded!'; 
echo 'You just created your MySQL Table!';
mysql_close(); 
}  


?>

The next step I need to do after this is to get the php files that call for the username and password to direct to this too. So that it can install (sort of) what I made into their site.

Thanks for any help.

Peredy

Tezread

You need to connect to the db first

Peredy

Got it to work.. here it is in case anyone wants the same thing.
What I am wondering though.. is how do I get the settings.php file (which has the connect info) to read it too, so that the user doesnt have to edit that php file or enter in a form everytime they want to use it.

<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body bgcolor="#FFFFFF">
<body>


<form action="" method="post"> 
DBName:<input type="text" name="dbname" size="" value="" /> 
DB Host:<input type="text" name="dbhost" size="" value="" /> 
User Name:<input type="text" name="dbuser" size="" value="" /> 
Password:<input type="text" name="dbpswd" size="" value="" /> 
<input type="submit" name="submit" value="Save" /> 
</form> 
</body>
</html>



<?php 
if (isset($_POST['submit'])) 
{ 
$dbname=$_POST['dbname']; 
$dbhost=$_POST['dbhost']; 
$dbuser=$_POST['dbuser']; 
$dbpswd=$_POST['dbpswd']; 

$query = 'CREATE TABLE `schedule` ('
        . ' `id` INT(11) NOT NULL AUTO_INCREMENT, '
        . ' `bsdate` DATE DEFAULT "0000-00-00" NOT NULL, '
        . ' `bstime` VARCHAR(10) NOT NULL, '
        . ' `bsvenue` VARCHAR(150) NOT NULL, '
        . ' `bslocation` VARCHAR(150) NOT NULL, '
        . ' `bsbandlistings` VARCHAR(255) NOT NULL, '
        . ' `bsdetails` VARCHAR(255) NOT NULL, '
        . ' `bsflyer` VARCHAR(100),'
        . ' PRIMARY KEY (`id`)'
        . ' )'; 






@mysql_connect($dbhost,$dbuser,$dbpswd) 
or die("could not connect to MySQL server!"); 
@mysql_select_db($dbname) 
or die("could not select MySQL database!"); 
$result = mysql_query($query);if(!$result){echo "you fucked up!!!";}
echo 'Connection succeded!'; 
echo 'You just created your MySQL Table!';
if(!$query){echo "something screwed up! try again"; }
mysql_close(); 
}  


?>

Thanks

Peredy