check folder if it's empty or not

kikki

hiya,
This script has got some kinda problem, it does not echo if the directory is empty,, can anyone tell me whats wrong with this script?


if(is_dir($directory)) {
  if($dir=opendir($directory)) {
    if(readdir($dir)===false) 
	{
     //$dir is empty?
	 echo '<b>Directory is empty bro!</b>';
	}else{

 echo '<b>Directory is FULL of something!</b>';
}
}
}

Shrike

A directory always contains . (current directory) and .. (parent directory) even if it contains no files or child directories.

planetsim

That would be because there are these two results being posted

. and ..

Meaning its not empty

Why not try this

$array = scandir($directory);
foreach ($array as $key => $value) {
	if ($value == "." || $value == "..") {
		unset($array[$key]);
	}
}
if (empty($array)) {
	echo '<b>Directory is empty</b>';
} else {
	echo '<b>Directory is FULL of something!</b>';
}

Shrike

Must type faster planetsim 😉

By the way scandir() is PHP 5 only. Shame because it's a cool function.

planetsim

Woops totally forgot here is a working way to do it in PHP 4 then

$array = array();

$d = opendir($directory);
while(($entry=readdir($d))!=false) {
	if ($entry != "." || $entry != "..") {
		array_push($array,$entry);
	}
}

if (empty($array)) {
	echo '<b>Directory is empty</b>';
} else {
	echo '<b>Directory is FULL of something!</b>';
}

And yes you seem to be beating me to get in first :glare:

Shrike

Just to be picky

<?php
$fail = 1;
if(is_dir($directory)) {
	$dir=opendir($directory); 
	while( FALSE !== ( $file = readdir($dir) ) )
	{ 
		if(is_file($file))
		{
			$fail = 0;
		}
	}
}
$fail and print "Empty directory!";
?>

😃

kikki

thankyou guys... 🙂

btw: Is there any good reason to change php 4.x.x.x to php 5.x..? 🙂

I thought not to install it for a while because first of all, php5 is new and they might have some unfixed bugs in it, maybe it's not stable yet. what do you guys thinking abt this?

Shrike

I definitely recommend downloading PHP 5 if you plan to get serious about PHP and OO. I don't think it will really take off until we are a few versions in - just because it offers alot of new functionality and people (and hosting companies) need time to catch up. So it's worth sticking with PHP 4 for production stuff for the time being.

PHP 5 is pretty stable, but as with most things it will take a few releases to fix all of the bugs.

kikki

I'll install php5 as soon as I read the php5 documentation. I think there are some Beta releases on php5, whats up with php beta? Is beta is bad or good?

Anyway Shrike, thanks for your good advice 🙂