Help... Proper way to request files within a template system.

virginiamonkeys

Okay, I've surfed about 30 plus hours and rewrote this script hundreds of times to get this to work, but I can't get it. I even posted on sitepoint.com but nobody there even bothered to answer.

Problem:

I have a template file as such: (very simplified) (named "template.php")

<html>
<head>
<META NAME="keywords" CONTENT="<? print ($keywords); ?>">
<META NAME="description" CONTENT="<? print ($description); ?>">
<title><? print ($pagetitle); ?></title>
</head>
<body bgcolor="#FFFFFF">
<script type='text/javascript' src='<?php print ($menuscript); ?>'></script>
<? include ('picture1.php'); ?>
<? include ('picture3.php'); ?></td>
<CENTER><H1><? print ($articletitle); ?></H1></CENTER>
<? print ($contents); ?>
<? print ($pagefooter); ?>
<? include ('picture2.php'); ?>
<? include ('picture2.php'); ?>
<?php include ("ad1.php"); ?>
<?php echo $phpAds_raw['html']; ?>
<?php $_GET['zfposition']="p1,p3"; include('newsfeeds/zfeeder.php'); ?>
<?php print ($pagefooter); ?>
</body>
</html>

This file will be called by all pages on my site. The thing is, I will have 2 separate themes, and want a different menu bar, pictures, footer, etc for the 2 themes (apples and tuna as an example).

So, page one of theme one (page one of apples) has these variables: (named "page1theme1.php")

<?php
$pagetitle = "Page 1 Apples";
$articletitle = "Page 1 Apples Title";
$keywords = "page 1 apples keywords";
$description = "Page 1 apples description";
$contents = "Page 1 Apples Contents";
include ("template.php");
include ("theme1.php");
?>

and page one of theme two (page one of tuna) has these variables: (named "page1theme2.php")

<?php
$pagetitle = "Page 1 Tuna";
$articletitle = "Page 1 Tuna Title";
$keywords = "page 1 tuna keywords";
$description = "Page 1 tuna description";
$contents = "Page 1 Tuna Contents";
include ("template.php");
include ("theme2.php");
?>

Then I have "theme1.php" with these variables:

<?php
$menuscript = "SinglePage1_var.js";
$pagefooter = "Menu stuff in HTML Theme 1";
?>

And I have "theme2.php" with these variables:

<?php
$menuscript = "SinglePage2_var.js";
$pagefooter = "Menu stuff in HTML Theme 2";
?>

I am getting errors. I think it's the way I'm calling 2 files to include into the template as one types in mysite.com/page1theme1.php.

This is part one of my error. But I think I can solve part 2 if the answer I get from this works. Part 2 has to do with the way files are called as well.

tsinka

Hi,

I hope I understood you comletely 🙂

From what I can see you need to include the theme scripts before you include the template script.

Which errors do you get ?

Additionally, I think that the code can be simplified a little bit. But that's the next step 🙂

Thomas

virginiamonkeys

Oh man! That was brilliant! I can't believe I didn't try that combination of lines within my script.

Worked like a charm!

Now I'm going to experiment for a tad before deciding I need to post my other problem.

Thanks a bunch!

😃

virginiamonkeys

Nope... having troubles again with the other part.

I'm putting ads in my page, and in my "page1theme1.php" I have the following lines:

<?php
$pagetitle = "Page 1 Theme 1";
$articletitle = "Page 1 Theme 1 Title";
$keywords = "page 1 theme 1 keywords";
$description = "Page 1 theme 1 description";
$contents = "Page 1 Theme 1 Contents";
$ad1 = "<?php
if (@include(getenv('DOCUMENT_ROOT').'/phpads/phpadsnew.inc.php')) {
if (!isset($phpAds_context)) $phpAds_context = array();
$phpAds_raw = view_raw ('zone:4', 0, '_blank', 'Index Ad 1', '1', $phpAds_context);
$phpAds_context[] = array('!=' => 'bannerid:'.$phpAds_raw['bannerid']);
}
?>";
include ("theme1.php");
include ("template.php");
?>

And in the "template.php" I have

<? print ($ad1); ?>
<?php echo $phpAds_raw['html']; ?>

If I just run the file with putting the red script where <? print ($ad1); ?> is, it runs fine, but as soon as I put in the $ad1 line and insert the red script into my page1theme1.php, it gets screwey and won't run the page.

I imagine it's a command (print) error or something with me not escaping something out or I don't know.

virginiamonkeys

The error code is:

Parse error: parse error, expecting T_STRING' orT_VARIABLE' or `T_NUM_STRING' in /home/mwatw/monkeywithatypewriter-www/page1theme1.php on line 11

Line 11 would be:

$phpAds_context[] = array('!=' => 'bannerid:'.$phpAds_raw['bannerid']);