data not being inserted

jimday1982

My query looks right when I output it, but the data is not being inserted into my table for some reason...am i missing something?

//Populate tracking table with data from csv
 $fcontents = file ('tracking.csv');

   for($i=0; $i < sizeof($fcontents); $i++) {
      $line = trim($fcontents[$i]);
      $arr = explode("\"", $line);
      #if your data is comma separated
      # instead of tab separated,
      # change the '\t' above to ','

  $sql = "insert into tracking values (";
  for($i=0; $i < sizeof($arr); $i++) {
     $sql .= $arr[$i] . "";
     if($i + 1 < sizeof($arr)) {
       $sql .= "\"";
     }
  }
  $sql .= ")";
  //implode("\",\"", $arr) .)";
  mysql_query($sql) or die(mysql_error());
  echo "<font face=verdana size=2>" . $sql ."</font><br>\n";
  if(mysql_error()) {
     echo mysql_error() ."<br>\n";
  }
}

Thanks for your help.

bastien

what is the error?

Try echoing out the sql before execution, then copy and run the sql thru the gui of your choice and see what the error is

jimday1982

Thanks, but I realized the inner loop needed a new counter variable - $i was being used in the previous loop.

devinemke

$fcontents = file('tracking.csv');
foreach ($fcontents as $line)
{
	$line = trim($line);
	$explode = explode(',', $line);
	foreach ($explode as $key => $value)
	{
		$explode[$key] = "'" . addslashes($value) . "'";
	}
	$result = mysql_query('INSERT INTO tracking VALUES (' . implode(',', $explode) . ')');
	if ($result) {echo 'OK<br>';} else {exit(mysql_error());}
}

jimday1982

Thanks for the code - can you explain the benefits of using this over what I have already? Being new to php, this stuff is pretty confusing to me.

Originally posted by devinemke

$fcontents = file('tracking.csv');
foreach ($fcontents as $line)
{
	$line = trim($line);
	$explode = explode(',', $line);
	foreach ($explode as $key => $value)
	{
		$explode[$key] = "'" . addslashes($value) . "'";
	}
	$result = mysql_query('INSERT INTO tracking VALUES (' . implode(',', $explode) . ')');
	if ($result) {echo 'OK<br>';} else {exit(mysql_error());}
}

[/B]