[Resolved] Adding Error

[NZ_Kiwi]

i have this basic code

<?php
if ($team1 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team1')") 
or die("INSERT error: ".mysql_error());
}

if ($team2 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team2')") 
or die("INSERT error: ".mysql_error());
}

if ($team3 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team3')") 
or die("INSERT error: ".mysql_error());
}

if ($team4 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team4')") 
or die("INSERT error: ".mysql_error());
}

if ($team5 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team5')") 
or die("INSERT error: ".mysql_error());
}

if ($team6 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team6')") 
or die("INSERT error: ".mysql_error());
}

if ($team7 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team7')") 
or die("INSERT error: ".mysql_error());
}

if ($team8 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team8')") 
or die("INSERT error: ".mysql_error());
}

if ($team9 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team9')") 
or die("INSERT error: ".mysql_error());
}

if ($team10 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team10)") 
or die("INSERT error: ".mysql_error());
}

if ($team11 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team11')") 
or die("INSERT error: ".mysql_error());
}

if ($team12 == "") {
} else {
$result = mysql_query ("INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team12')") 
or die("INSERT error: ".mysql_error());
}

?>

Real easy and it works fine but when i try add up to 10 or more items i get this error

INSERT error: You have an error in your SQL syntax near ''2)' at line 1

any idea why???

[planetsim]

You should write the SQL Statement and its number so you can which query it runs off.

I also think you should use an Array.

[NZ_Kiwi]

So how should i change my code?

[kpzani]

don't be daft
your missing a single quote at the end of the line
('$comp_run_id','$team10)")

should be
('$comp_run_id','$team10')")

but you should use an array.
where are your team vars coming from?
I take it you don't understand arrays? if you like post the entire page up and I'll have a look.

if the data is coming from a separate page then post that as well.

[NZ_Kiwi]

Originally posted by kpzani
don't be daft
your missing a single quote at the end of the line
('$comp_run_id','$team10)")

should be
('$comp_run_id','$team10')")

but you should use an array.
where are your team vars coming from?
I take it you don't understand arrays? if you like post the entire page up and I'll have a look.

if the data is coming from a separate page then post that as well.

Sorry got the first part.. didn't change it to resloved..

but the second part... well it's from page where there is option for these boxes... team1 but it loops a number of times and get's a new number everytime.. that is why i get team1, team2, team3 ect ect

i have no idea about array...
do you still want me to post my pages.??

thanks for your help

[kpzani]

REMOVED - it was a duplicate

[kpzani]

SORRY ABOUT THE LAST POST - hit TAB by mistake

ok.

an array is a type of variable designed for holding lists. for info check out
http://www.phpbuilder.com/manual/ref.array.php

backup your files before trying this!
on the submitting page replace your 12 textboxes with the following

<?php
  $maxteams = 12;
  for ($i=0; $i<$maxteams; $i++) {
    echo("<input type='text' id='team" . $i . "' name='team" . $i . "' value=''>");
}
?>

then on the recieving page do this

$teamarray = $_POST["team"];
foreach ($teamarray as $team) {
  $sql = "INSERT INTO results_comp_run_teams (`comp_run_id`,`team_id`) Values ('$comp_run_id','$team')"; 
$result = @mysql_query ($sql) ;
or die("INSERT sql:<br> $sql <br>error: ". @mysql_error());
}

and that should do it