if and else issue

[slimjim]

What I am trying to do is, if an ip and url is in blick in same row, then update banners, else update bclick. But, also do, is have code to check day and any day older then 1 day the row will be deleted in bclick.
Not sure if time is right way to do this, But for sure I have something wrong.

Goal is to stop the click count from rasing if clicked from same person and from same url with same ip on the same day.

$ip = substr($REMOTE_ADDR, 0, strrpos($REMOTE_ADDR, "."));
$url = $PHP_SELF;
$time = time();

$sql = mysql_query("SELECT id,banner,bannerurl,clicks,total FROM banners WHERE id='$id'");
$row = mysql_fetch_array($sql);

$sql2 = mysql_query("SELECT id FROM bclick where ip='$ip' and url='$url'");
$row = mysql_fetch_array($sql2);

if($sql2='$ip'){
	    $sql4 = mysql_query("insert into bclick (id,ip,url,time) VALUES ('','$ip',$url','$time')");
        mysql_query($sql4);
}else{
        $sql3 = mysql_query("UPDATE banners SET clicks = clicks + 1 where id=$id");
        mysql_query($sql3);
}

[wilsonodk]

I can tell you this, your if-else statement will always return true. You need to you need to use a comparison operator (i.e., ==) not an assinment operator (=).

However, once you do that, your statement will always return false, because you use $id in the $sql2 string, so there isn't a way for them to be equal.

Additionally, you never actually query the database with either $sql or $slq2, yet you try and fetch results. Also, you're fetching the results to the same variable ($row) before you've had a chance to do anything with them.

Try using $SERVER['REMOTE_ADDR'] and $SERVER['PHP_SELF'] instead as well.