[Resolved] send_mail() - looping error

[ed210]

How can you loop through sending emails via send_mail()?

I have tried this....

$result = mysql_query("SELECT * FROM hgw_addressbook");

while ($myrow = mysql_fetch_array($result)) {

	function send_mail($myname, $myemail, $contactname, $contactemail, $subject, $message) {
		$headers .= "MIME-Version: 1.0\n";
		$headers .= "Content-type: text/html; charset=iso-8859-1\n";
		$headers .= "X-Priority: 3\n";
		$headers .= "X-MSMail-Priority: High\n";
		$headers .= "X-Mailer: php ". phpversion(). "\n";
		$headers .= "From: \"".$myname."\" <".$myemail.">\n";
		return(mail("\"".$contactname."\" <".$contactemail.">", $subject, $message, $headers));
	}

	if (send_mail($sender_name, $sender_email, $sender_name, $sender_email, $subject, $contents)) {
		print "Your email to $sender_name &lt;$sender_email&gt; has been successfully SENT!";
	} else {
		print "FAILED!";
	}

} // end while

... but i get this error....

Fatal error: Cannot redeclare send_mail() (previously declared in...)

Any tips would be very helpful. Thank you!

[TheDefender]

Move your function out of the while loop so it doesn't get redeclared. Basically, the way you have it, it is trying to redeclare (or redefine) the function after the page has loaded.

$result = mysql_query("SELECT * FROM hgw_addressbook"); 

function send_mail($myname, $myemail, $contactname, $contactemail, $subject, $message) { 
              $headers .= "MIME-Version: 1.0\n"; 
              $headers .= "Content-type: text/html; charset=iso-8859-1\n"; 
              $headers .= "X-Priority: 3\n"; 
              $headers .= "X-MSMail-Priority: High\n"; 
              $headers .= "X-Mailer: php ". phpversion(). "\n"; 
              $headers .= "From: \"".$myname."\" <".$myemail.">\n"; 
              return(mail("\"".$contactname."\" <".$contactemail.">", $subject, $message, $headers)); 
          } 

while ($myrow = mysql_fetch_array($result)) { 

    if (send_mail($sender_name, $sender_email, $sender_name, $sender_email, $subject, $contents)) { 
          print "Your email to $sender_name &lt;$sender_email&gt; has been successfully SENT!"; 
    } else { 
          print "FAILED!"; 
    } 

} // end while

[ed210]

Thanks Defender!

I have updated my code now and it works. Also changed 'while' to 'for'.

	$result = mysql_query("SELECT * FROM hgw_addressbook");

function send_mail($myname, $myemail, $contactname, $contactemail, $subject, $message) {
	$headers .= "MIME-Version: 1.0\n";
	$headers .= "Content-type: text/html; charset=iso-8859-1\n";
	$headers .= "X-Priority: 3\n";
	$headers .= "X-MSMail-Priority: High\n";
	$headers .= "X-Mailer: php ". phpversion(). "\n";
	$headers .= "From: \"".$myname."\" <".$myemail.">\n";
	return(mail("\"".$contactname."\" <".$contactemail.">", $subject, $message, $headers));
}

// start output string with number of entries
$nrows = mysql_num_rows($result);

for ($i=0; $i < $nrows; $i++) {
	$myrow = mysql_fetch_array($result);

	$recipientName = $myrow["addressName"];
	$recipientURL = $myrow["addressURL"];

	// enters dynamic info into email
	eval("\$eval_contents = \"$contents\";");

	if (send_mail($sender_name, $sender_email, $sender_name, $sender_email, $subject, $eval_contents)) {
		print "Your email to $sender_name &lt;$sender_email&gt; has been successfully SENT! \n";
	} else {
		print "Your email to $sender_name &lt;$sender_email&gt; has FAILED! \n";
	}

} // end for

Cheers!

[TheDefender]

Glad you got it working. Be sure to mark the thread resolved using the "Mark Thread Resolved" link below.