Pass parameters to class via method calls, or directly?

[bunner_bob]

(originally posted in 'Database' (erroneously))

What's the best way to get variables/arrays/objects into class instances?

Should I pass them by assigning them to class variables directly?

$foo = &new Class;
$foo->var1 = 'the monkey';
$foo->var2 = &$local_variable;

$bar = &$foo->returnStuff();

or should I pass the variables in a class method call?

$foo = &new Class;
$var1 = 'the monkey';
$var2 = &$local_variable;

$bar = &$foo->returnStuff($var1, $var2);

Or is there any difference?

• Bob

[planetsim]

Id pass them through methods. However why are you using & all the time?

[bunner_bob]

Ya know, that's a good question. Probably because I read too much. The gist I've been getting from a number of sources (books as well as online articles) is that using references in OO PHP is a good idea. That said, I'm probably using them more/less/differently than ideal.

I know I should pretty much always use them when creating a new instance:

$foo = &new Bar;

as well as any time I'm passing that object around, since I end up passing the 'actual' object instead of a copy of it - or more accurately, the work done on the object is done on the original rather than a copy.

class Bar
{
method ProcessObject(&$object)
{
// code
}
}

As far as using refs when passing variables or arrays around, I thought it was just good OO practice. But maybe I'm overdoing it. Advice & opinions are certainly welcome.

• Bob