[RESOLVED] script wont display lines with same content

[Reiners]

Hi all!
I got a finished script which reads out alle the data from a file called arp.dat
My Script:

$fp = fopen('arp.dat', 'r');
  $row = array();


  while(!feof($fp))
    {

$line = fgets($fp,1000); 

$data = explode("	", trim($line)); 


if($order == 'NAME')
{
$key = $data[3];
}
else if($order == 'IP')
{
$key = $data[1];
}
else if($order == 'MAC')
{
$key = $data[0];
}
else
{
$key = $data[2];
}

$row[$key] = array($data[3], $data[1], $data[0], $data[2]);
}

ksort($row, SORT_REGULAR);

echo '<table>
     <tr>
     <td><b><a href="index.php?order=IP">IP-Adresse</a></b></td>
     <td><b><a href="index.php?order=MAC">MAC-Adresse</a></b></td>
     <td><b><a href="index.php?order=NAME">NAME</a></b></td>
     <td><b><a href="index.php?order=TIME">TIME</a></b></td>
     </tr>';

foreach($row as $data)
     {

 echo "<tr><td>$data[1]</td>
               <td>$data[0]</td>
               <td>$data[3]</td>
               <td>$data[2]</td></tr>";
 }

fclose($fp);

echo '</table>';

actually my script is way more longer, but i think thats the part where everything important happens

My arp.dat-file

0🅱b🅱b:b 192.168.1.3 1087368085 pc2
0🅰a🅰a:a 192.168.1.2 1095850759 pc1
0:c:c:c:c:c 192.168.1.1 1097679853 pc3
0:d:d:d:d:d 192.168.1.2 1096280091 pc4

The script displays this stuff in right order (sorted by IP-adress by starting the script) and so on.

everything just works great but there is one problem:
when there is a line which got the same content then another line (for example: both line got the same

IP-adress, everything else is different), then my script wont display both lines when i am trying to order

by the topic, where they both are the same (in this case: order by IP-adress). It just displays the line

which stands lower in the arp.dat-file. it seems to, that the lower line overwrites the line with same

content. but this happens only, as i said, if i order by the topic, under which the lines with the same

content stands.

Here another example:

arp.dat-file

0🅱b🅱b:b 192.168.1.3 1087368085 pc2
0🅰a🅰a:a 192.168.1.2 1095850759 pc1
0:c:c:c:c:c 192.168.1.1 1097679853 pc3
0:d:d:d:d:d 192.168.1.2 1096280091 pc4

my script will display that in a nice table (not ordered):

table un-ordered

192.168.1.3 0🅱b🅱b:b pc2 1087368085
192.168.1.2 0🅰a🅰a:a pc1 1095850759
192.168.1.1 0:c:c:c:c:c pc3 1097679853
192.168.1.2 0:d:d:d:d:d pc4 1096280091

but if I order by IP adress now, it display the following:

table ordered by IP

192.168.1.1 0:c:c:c:c:c pc3 1097679853
192.168.1.2 0:d:d:d:d:d pc4 1096280091
192.168.1.3 0🅱b🅱b:b pc2 1087368085

... the second line with the nother ip adress 192.168.1.2 just seems to be overwritten.

if i order by name, everything is just fine again (because no name is appearing twice) and my table would

look like this:

table ordered by name

192.168.1.2 0🅰a🅰a:a pc1 1095850759
192.168.1.3 0🅱b🅱b:b pc2 1087368085
192.168.1.1 0:c:c:c:c:c pc3 1097679853
192.168.1.2 0:d:d:d:d:d pc4 1096280091

so whats wrong with my script ? how can i let display line's with same content without getting them overwritten when i order by them?

btw: i am using Apache 1.3.20 (win32) and PHP 4.0.3
if you need any more informations please feel free to ask

Would be really great if you could help me
thanks in advance and sorry for my worse english 😉

[sidney]

when you do $key = $data[3]; and then at end do

$row[$key] = array($data[3], $data[1], $data[0], $data[2]);

if there is allready an $row[$key] it is overwritten

try somthing like below
ive not use fopen as i was lazy and could be arsed to
create 2 files so add the data in the script
and used a foreach rather than a while

 $order='MAC';
$ddd[]='192.168.1.3 0:b:b:b:b:b pc2 1087368085'; 
$ddd[]='192.168.1.2 0:a:a:a:a:a pc1 1095850759';
$ddd[]='192.168.1.1 0:c:c:c:c:c pc3 1097679853'; 
$ddd[]='192.168.1.2 0:d:d:d:d:d pc4 1096280091'; 
foreach($ddd as $line)
	{
    $row = explode(" ", trim($line));  

    if($order == 'NAME')  

    	$key[] = $row[3];  

    else if($order == 'IP') 
    	$key[] = $row[1];  

    else if($order == 'MAC')  

    	$key[] = $row[0];
    else  

    	$key[] = $row[2]; 
	$rows[]=$row;
    } 

array_multisort($key, SORT_REGULAR,$rows); 

echo '<table> 
     <tr> 
     <td><b><a href="index.php?order=IP">IP-Adresse</a></b></td> 
     <td><b><a href="index.php?order=MAC">MAC-Adresse</a></b></td> 
     <td><b><a href="index.php?order=NAME">NAME</a></b></td> 
     <td><b><a href="index.php?order=TIME">TIME</a></b></td> 
     </tr>'; 

foreach($rows as $data) 
     { 

 echo "<tr><td>$data[1]</td> 
               <td>$data[0]</td> 
               <td>$data[3]</td> 
               <td>$data[2]</td></tr>"; 
 } 



echo '</table>'; 

[Reiners]

Hi!
thanks for trying to help!
but i dont get your code ... when i tried to involve it in my one i just didnt get it to work.
what is this $ddd for?? i have to read the content from the arp.dat into my table ... therefor the content may change ...
how to express that in your code?
what is in your script the $data ? it just seems to be not defined ...

could you pls help me to get your source code work in my script ?!
would be great
thx again!

[sidney]

the $ddd is so i didnt have to create a file and fopen it
ive add your while loop in place of my testing foreach loop
hope you get the idea now

 $fp = fopen('arp.dat', 'r'); 
  $row = array(); 


  while(!feof($fp)) 
    { 

$line = fgets($fp,1000);  

$row = explode(" ", trim($line));   
if($order == 'NAME')   
    $key[] = $row[3];   
else if($order == 'IP')  
    $key[] = $row[1];   
else if($order == 'MAC')   
    $key[] = $row[0]; 
else   
    $key[] = $row[2];  
$rows[]=$row; 
}  

array_multisort($key, SORT_REGULAR,$rows);  

echo '<table> 
     <tr> 
     <td><b><a href="index.php?order=IP">IP-Adresse</a></b></td> 
     <td><b><a href="index.php?order=MAC">MAC-Adresse</a></b></td> 
     <td><b><a href="index.php?order=NAME">NAME</a></b></td> 
     <td><b><a href="index.php?order=TIME">TIME</a></b></td> 
     </tr>';  

foreach($rows as $data)  

     {  

 echo "<tr><td>$data[1]</td> 
               <td>$data[0]</td> 
               <td>$data[3]</td> 
               <td>$data[2]</td></tr>";  
 }  



echo '</table>';

 

[Reiners]

i think i got the main idea ... but involving your sourcecode into my script it just displays the table header with those links to order but no table content (no entries from the arp.dat-file) ...
i think its because we've not defined anything for "$data" in

foreach($rows as $data)  

what shell i write for "$data" ??

[sidney]

no its fine $rows contains the data

have you got the tab in the explode statment as i used a single space

[Reiners]

yeah ive got a tab ... because between my data in the arp.dat is a tab ... the forum just didnt displayed the tap by posting it here ... so it has to be an tab by "explode" because in the arp.dat is an "tab" too ...

[sidney]

i thought you might have left the space in by mistake thats why i asked

can you post the code as you have used it please

[Reiners]

ok here is my code without taking changes from your post (the code i used to use)

<?php

// time atm in a unix timestamp
       $aktuell = time();

// headtitel as an reload-button
echo '
<h3 align="center"><a href="index.php">arp.dat Logdatei</a></h3>';


//
//        R E A D I N G    OF THE arp.dat CONTENT
//

// at the beginning it shell be sorted by IP
if (empty($order))
{
$order = 'IP';
}

  // opening the file arp.dat
  $fp = fopen('arp.dat', 'r');
  $row = array();


  while(!feof($fp))
    {

// reading the content
$line = fgets($fp,1000); 

// exploding the content by a "tab"
$data = explode("	", trim($line)); 

// look, how the content schould be sorted (by reading the postet variable $order)
if($order == 'NAME')
{
$key = $data[3];
}
else if($order == 'IP')
{
$key = $data[1];
}
else if($order == 'MAC')
{
$key = $data[0];
}
else
{
$key = $data[2];
}

// writing the data in an array to make them sort later
$row[$key] = array($data[3], $data[1], $data[0], $data[2]);
}

// sort the data 
ksort($row, SORT_REGULAR);




//
//       D I S P L A Y   THE DATA
//


  // HEAD of the table
  echo '<table border="1" cellpadding="1" cellspacing="0" align="center" bordercolor="#800000" bgcolor="#F0F0F0">


   <!-- by clicking on the tableheadline the variable $order" will get postet and the table content will get sorted -->

 <tr>
 <td><b><a href="index.php?order=IP">IP-Adresse</a></b></td>
 <td><b><a href="index.php?order=MAC">MAC-Adresse</a></b></td>
 <td><b><a href="index.php?order=NAME">Geräte Name</a></b></td>
 <td>&nbsp;&nbsp;<b><a href="index.php?order=TIME">TIME</b></td>
 </tr>';

// displaying the data
foreach($row as $data)
     {

            echo "<tr><td>$data[1]</td>
               <td>$data[2]</td>
               <td>$data[0]</td>
               <td>$dara[3]</td></tr>";
 }


// closing arp.dat
  fclose($fp);


// closing the table
echo '</table>';

?>

of course this script is shortened it still works (tested it) ... and it is still ordering the tablecontent ... but just dont displays line's with same content ...

now how would you change this code with your ideas ??
many many thx in advance

[sidney]

i need to see how you use the code i supplied so i can
look for the error other wise im working blind

[Reiners]

ok i got it with your changes like the following and it works ... i just have to get it into my big script with all special functions and will see if it works

<?php

// time atm in a unix timestamp
       $aktuell = time();

// headtitel as an reload-button
echo '
<h3 align="center"><a href="index1.php">arp.dat Logdatei</a></h3>';


//
//        R E A D I N G    OF THE arp.dat CONTENT
//

// at the beginning it shell be sorted by IP
if (empty($order))
{
$order = 'IP';
}

  // opening the file arp.dat
  $fp = fopen('arp.dat', 'r');
  $row = array();


  while(!feof($fp))
  {

// reading the content
$line = fgets($fp,1000); 

// exploding the content by a "tab"
$data = explode("	", trim($line)); 

// look, how the content schould be sorted (by reading the postet variable $order)
if($order == 'NAME')
{
$key[] = $data[3];
}
else if($order == 'IP')
{
$key[] = $data[1];
}
else if($order == 'MAC')
{
$key[] = $data[0];
}
else
{
$key[] = $data[2];
}

$rows[]=$data;
  }


array_multisort($key, SORT_REGULAR,$rows);


//
//       D I S P L A Y   THE DATA
//


  // HEAD of the table
  echo '<table border="1" cellpadding="1" cellspacing="0" align="center" bordercolor="#800000" bgcolor="#F0F0F0">


   <!-- by clicking on the tableheadline the variable $order" will get postet and the table content will get sorted -->

 <tr>
 <td><b><a href="index1.php?order=IP">IP-Adresse</a></b></td>
 <td><b><a href="index1.php?order=MAC">MAC-Adresse</a></b></td>
 <td><b><a href="index1.php?order=NAME">Geräte Name</a></b></td>
 <td>&nbsp;&nbsp;<b><a href="index1.php?order=TIME">TIME</b></td>
 </tr>';

// displaying the data
foreach($rows as $data)
     {

            echo "<tr><td>$data[1]</td>
               <td>$data[3]</td>
               <td>$data[0]</td>
               <td>$dara[2]</td></tr>";
 }


// closing arp.dat
  fclose($fp);


// closing the table
echo '</table>';

?>

sry for taking your time ... i dunno why it didnt worked the last times
many many thx again!
and happy xmas 🙂

[sidney]

i bet my bottom dollar you had this in script

$data = explode(" ", trim($line));

rather than this

$row = explode(" ", trim($line));

any way glad you got it going

[Reiners]

edit: yeah ... might be, sry 😉

okay everything works great now
i cant say "thx" enaugh ... there is still 1 short question open:

array_multisort($key, SORT_REGULAR,$rows);

orders my content really nice from 'A to Z'
but know i want them ordered by 'Z to A'
what is the function to this ?
should be quite easy ... 😉

edit²: I used to use
krsort($rows, SORT_REGULAR);
and
ksort($rows, SORT_REGULAR);
but those ones just orderes the content from first or last entry in the arp.dat ... not in alphabetically (?) way ...

[sidney]

 if ($asc=='up')
	array_multisort($key, SORT_ASC , SORT_REGULAR,$rows);  

else
	array_multisort($key, SORT_DESC , SORT_REGULAR,$rows); 

then make your links

 
$asc=($asc!='up')?'up':'down';
echo'<a href="index1.php?order=IP&asc='.$asc.'">IP-Adresse</a>'

[Reiners]

very nice !! thx a lot! works great
you made one of my best xmas-presents 🙂

jippieee it works 😃 😃