Logon and Redirect

NZ_Kiwi

This is my login page......

<form action="auth.php?op=login" method="POST">
Username: 
<input name="username" size="15" style="font-family: Verdana; border-style: solid; border-width: 1px">

<br>
Password:
<input type="password" name="password" size="15" style="font-family: Verdana; border-style: solid; border-width: 1px">

<p>
<input type="hidden" name="redirect" value="<? echo $_SERVER['HTTP_REFERER']; ?>">
<input type="submit" value="Login" style="font-family: Verdana; border-style: solid; border-width: 1px">

</form>

this is the auth page problem is this does not redirect!!!!! any dieas why???

<?php
session_start();
 // dBase file
include "dbConfig.php";

if ($_GET["op"] == "login")
{
if (!$_POST["username"] || !$_POST["password"])
{
Header("Location: error.php");
}

 // Create query 

$q = "SELECT * FROM `members` "   ."WHERE `username`='".$_POST["username"]."' "


   ."AND `password`='".$_POST["password"]."' "


   ." LIMIT 1";


  // Run query
  $r = mysql_query($q);

  if ( $obj = @mysql_fetch_object($r) )
   {
   // Login O.K., create session variables
   $_SESSION["valid_id"] = $obj->id;
   $_SESSION["valid_user"] = $_POST["username"];
   $_SESSION["valid_time"] = time();
   // Redirect to member page
   Header("Location: $redirect");
   }
  else
   {
   // Login not successful
   Header("Location: error.php");
  }
  }
 else
  {
  Header("Location: error.php");
  }
 ?>

bpat1434

Well, looking at your script.....

1st question: Where do you define $redirect and what is it?

2nd question: Why are you posting to a php page with variables in the url?

Personally, I'd create two different scripts:
logon.php and logoff.php

Then you can simply make it easier for yourself. Post to the logon.php and use nothing but $_REQUEST[''] so that you know no matter how you post it, you will always retrieve the value.

I see now that you are trying to make your hidden value the http referer.

Try this:

<form action="auth.php" method="POST">
Username:
<input name="username" size="15" style="font-family: Verdana; border-style: solid; border-width: 1px">

<br>
Password:
<input type="password" name="password" size="15" style="font-family: Verdana; border-style: solid; border-width: 1px">

<p>
<input type="hidden" name="redirect" value="<? echo $_SERVER['HTTP_REFERER']; ?>">
<input type="hidden" name="op" value="login">
<input type="submit" value="Login" style="font-family: Verdana; border-style: solid; border-width: 1px">

</form>

<?php
$op = $_REQUEST['op'];

if($op == "login"){
    session_start();
    $redirect = $_REQUEST['redirect'];

include "dbConfig.php";

if (!$_REQUEST["username"] || !$_REQUEST["password"]) {
    Header("Location: error.php");
}

$q = "SELECT * FROM `members` WHERE `username` = '$username' AND `password` = '$password' LIMIT 1";

$r = mysql_query($q);

if ( $obj = @mysql_fetch_object($r) ) {
    // Login O.K., create session variables
    $_SESSION["valid_id"] = $obj->id;
    $_SESSION["valid_user"] = $username;
    $_SESSION["valid_time"] = time();
    Header("Location: $redirect");
}
else {
    Header("Location: error.php");
}
}

else if($op == 'logoff'){
    // Do Logoff crap here
}
?>

NZ_Kiwi

Originally posted by bpat1434
Well, looking at your script.....

1st question: Where do you define $redirect and what is it?

2nd question: Why are you posting to a php page with variables in the url?

Personally, I'd create two different scripts:
logon.php and logoff.php

Then you can simply make it easier for yourself. Post to the logon.php and use nothing but $_REQUEST[''] so that you know no matter how you post it, you will always retrieve the value.

I see now that you are trying to make your hidden value the http referer.

Try this:
<form action="auth.php" method="POST">
Username:
<input name="username" size="15" style="font-family: Verdana; border-style: solid; border-width: 1px">

<br>
Password:
<input type="password" name="password" size="15" style="font-family: Verdana; border-style: solid; border-width: 1px">

<p>
<input type="hidden" name="redirect" value="<? echo $_SERVER['HTTP_REFERER']; ?>">
<input type="hidden" name="op" value="login">
<input type="submit" value="Login" style="font-family: Verdana; border-style: solid; border-width: 1px">

</form>
<?php
$op = $_REQUEST['op'];

if($op == "login"){
    session_start();
    $redirect = $_REQUEST['redirect'];

include "dbConfig.php";

if (!$_REQUEST["username"] || !$_REQUEST["password"]) {
    Header("Location: error.php");
}

$q = "SELECT * FROM `members` WHERE `username` = '$username' AND `password` = '$password' LIMIT 1";

$r = mysql_query($q);

if ( $obj = @mysql_fetch_object($r) ) {
    // Login O.K., create session variables
    $_SESSION["valid_id"] = $obj->id;
    $_SESSION["valid_user"] = $username;
    $_SESSION["valid_time"] = time();
    Header("Location: $redirect");
}
else {
    Header("Location: error.php");
}
}

else if($op == 'logoff'){
    // Do Logoff crap here
}
?>
[/B]

1st question: Where do you define $redirect and what is it?

<?php
$ref = $_SERVER['HTTP_REFERER']; 
?>
Then on my form....
<input type="hidden" name="redirect" value="<?php echo $ref; ?>">

2nd question: Why are you posting to a php page with variables in the url?

bpat1434

Ok, so you ahve to call $ref as the redirect, not $redirect.

NZ_Kiwi

Originally posted by bpat1434
Ok, so you ahve to call $ref as the redirect, not $redirect.

But the variable is $redirect it holds the value of $ref

am i not right???

bpat1434

$redirect and $ref will hold null values unless you set them. And if you don't set them the same, then there is a chance to get an error. I don't see in your code where you set 1 as the other

$ref = $redirect;
// OR
$redirect = $ref;

Perhaps I'm missing something..... but...

You are changing your code as you go, so I don't really follow. What I had originally posted works. Why are you creating two variables to hold the same information? Use one or the other, $ref or $redirect. No use in using more than one veriable to hold identical information, catch my drift?

The reason I say you are changing yoru code is because in your original post, I don't see:

<?php
$ref = $_SERVER['HTTP_REFERER'];
?>

So, if you want help, yes you need to work at it yourself, but don't change code and not post the changed code, cuz I just got lost trying to find it.

If what you're trying to do is just set $ref & $redirect to be the same, then use only 1 of them, and then change your code as you see fit.
BUT in your original code, I still do NOT see how you are calling the php variable $ref/$redirect from the HTTP Form. You MUST request that value, or you can't get it.

I hope I can help you, but I'll be in and out this week. If you use my original posting of the form & php, it will work.

~Brett