Petty PHP Problem, Please Help

influx

Hi there,

I have the following code:

$file1=arbitrary_file_name_1
$file2=arbitrary_file_name_2
$file3=arbitrary_file_name_3

for($x=1;$x<=3;$x++)
{
    //delete file #1-3
    unlink("../_user_upload/".$username."/".$file.$x); //I want it to delete $file1, $file2, and $file3.  How exactly do I set the last segment of this line to do that?
}

Hopefully this is a petty problem to fix.

Thanks in advance!
-influx

planetsim

I suggest using an Array instead of what you currently have that way its more dynamic incase you have more files to delete later on.

Weedpacket

First, consider using arrays for this job.
Second, ${"file$x"}.

influx

Alright, so I attempted the array approach but it still is not working.

Here is my array, I will show you the error I get afterwards:


$file1=$row["u_file5_name"];
$file2=$row["u_file6_name"];
$file3=$row["u_file7_name"];
$username=$_SESSION['username'];

//array for file deletion
$xfiles = array( $file1, $file2, $file3); 
for ($i=1;$i<count($xfiles);$i++)
{
	if($xfiles[$i]) //delete actual file if it exists
	{
    	       $loser[$i] = "../../_user_upload/".$username."/".$xfiles[$i];
    	       unlink($loser[$i]);
        }
}

There is my code, and the error message says this:

Warning: unlink() failed (Is a directory) in /var/www/members/upload/upload_remove_all.php on line 224

It says it three times, meaning the unlink failed all three times. I am pretty sure the problem lies in the last segment of the line with /".$xfiles[$i];

It is trying to delete the directory instead of a specific file.

Thanks in advance!

-influx

jonno946

all seems ok as far as i can see, but it seems php can't find the file to delete, are you sure the path is correct? how about trying to echo it out (i.e echo $loser[$i]) to check?

it may be an idea for your script to check that the file exists before attempting to delete using http://uk.php.net/file_exists.

like this:


$file1=$row["u_file5_name"];
$file2=$row["u_file6_name"];
$file3=$row["u_file7_name"];
$username=$_SESSION['username'];

//array for file deletion
$xfiles = array( $file1, $file2, $file3); 
for ($i=1;$i<count($xfiles);$i++)
{
    if($xfiles[$i]) //delete actual file if it exists
    {
               $loser[$i] = "../../_user_upload/".$username."/".$xfiles[$i];
                   if(file_exists($loser[$i])) {
                   unlink($loser[$i]);
               } else {
                   echo "File doesn't exist";
               }
        }
}