[Resolved] While loop is looping twice (I think)

webnewone

I'm not sure if it's just a case of me not "getting" how loops work but I can't for the life of me figure this out.

I've built an very basic shopping cart system. When a user checks out, this part of the code takes what's in the users shopping cart and adds each item to an "ordered items" table along with the corresponding order number.

The loop does work apart from one thing. It loops twice! For example if there are items 1, 2, 3 in the cart, the loop will add the items to the "ordered items" table twice . . . i.e:

ordered_items_id    items_id   order_id
1					1			001
2					2			001
3					3			001
4					1			001
5					2			001
6					3			001

Here's the code:

 $orders_items_sql = mysql_query("SELECT items_id FROM store_cart WHERE customers_id='".$_SESSION['customers_id']."'");

 while($row = mysql_fetch_array($orders_items_sql)){

$items_id  = $row['items_id'];
mysql_query("INSERT INTO store_orders_items (orders_items_id,
			 orders_id,
			 items_id)

			 VALUES ('',
			 '$orders_id',
			 '$items_id')");


 }

Why is it doing this? Tried with a for loop too and the same thing happens! Any help appreciated!

Thanks

rehfeld

i dont think the code you posted is your problem. i think your shopping cart is the culprit.

inside your while() loop, instead of inserting the data to the db again, echo it out so you can see it. use this concept in other parts of the script until you find the problem.

btw- in your insert, i dont see where this variable comes from $orders_id

make sure that variable is set, and correct.

webnewone

The orders_id comes from a variable from a different sql query further up.

I'll try echoing it out and see what happens!

webnewone

OKAY. Tried what you suggested and it works fine when I print the results of the loop to the browser like this:

 $orders_items_sql = mysql_query("SELECT items_id FROM store_cart WHERE customers_id='".$_SESSION['customers_id']."'");

 while($row = mysql_fetch_array($orders_items_sql)){

$items_id  = $row['items_id'];

echo "<p>".$items_id."</p>";


 }

The result is:

<p>1</p>
<p>2</p>
<p>3</p>

So it has to be something wrong with this part of the code right?

mysql_query("INSERT INTO store_orders_items (orders_items_id,
				 orders_id,
				 items_id)

			 VALUES ('',
			 '$orders_id',
			 '$items_id')");

But that looks like a perfectly decent query to me!

😕

webnewone

Fixed!

My fault! I had a header location that pointed the script to $_SERVER['PHP_SELF'] and so I was unwittingly invoking the script twice!

D'oh!