Why does this jump to the end?

[esbsolu]

My code shows me the first page, but after my first submit ($Submit) the page jumps to the end. For some reason, it doesn't recognize the !$Assign if statement. Thanks!

<form method="post" action="<?php echo $PHP_SELF; ?>" name="openjobmanager">
<?php

if (!$Submit)
	{
	$connect=mysql_connect("localhost","user","pass");

	$select=mysql_select_db("db");

	$query= mysql_query ("SELECT * FROM openjobs");

	$num_results = mysql_num_rows($query);

	?>
	<br /><br />
	Please select an open job to manage:<br /><br />

	<table align="center" border="0" cellspacing="5" cellpadding="5">
	<tr><td><b>Review Date</b></td><td><b>Firm</b></td></tr>

	<?php

	for ($i=0; $i <$num_results; $i++)
		{
		$row = mysql_fetch_array($query);

		echo '<tr><td><input type="radio" checked="checked" name="ID" value="'.htmlspecialchars(stripslashes($row['ID'])).'">'.stripslashes($row['ReviewDate']).'</td><td>'.stripslashes($row['Firm']).'</td></tr>';
		}

	?>
	<tr>
	<td colspan="4" align="center">
	<input type="submit" value="Submit" name="Submit">
	</td></tr></table>

	<?php
	}

if ($Submit)
	{	
	if (!$Assign)
		{
		echo 'Here';
		die;
		$connect=mysql_connect("localhost","user","pass");

		$select=mysql_select_db("db");

		$query= mysql_query ("SELECT * FROM openjobs WHERE ID ='$HTTP_POST_VARS[ID]'");

		$num_results = mysql_num_rows($query);

		?>

		<br /><br />
		Please assign a function for the following job:<br /><br />

		<?php

		for ($i=0; $i <$num_results; $i++)
			{
			$row = mysql_fetch_array($query);

			echo '<p align="left">
			<b>Firm:</b> '.$row['Firm'].'<br />
			<b>Name:</b> '.$row['Name'].'<br />
			<b>Address:</b> '.$row['Address'].' '.$row['City'].', '.$row['State'].' '.$row['Zip'].'<br 	/>
			<b>Phone:</b> '.$row['Phone'].'<br />
			<b>Email:</b> '.$row['Email'].'<br />
			<b>Review Type:</b> '.$row['ReviewType'].'<br />
			<b>Review Date:</b> '.$row['ReviewDate'].'<br />
			<b>Engagement Letter Accepted:</b> '.$row['EngLettAccept'].'<br 	/>
			<b>Invoiced:</b> '.$row['Invoiced'].'<br 	/>
			<b>Fee:</b> $'.$row['Fee'];
			}
			?>

		<table align="center" border="0">
		<tr>
		<td><input type="radio" name="function" value="engagementletter">Engagement Letter</td>
		<td><input type="radio" name="function" value="invoice">Invoice</td>
		<td><input type="radio" name="function" value="survey">Survey</td>
		<td><input type="radio" name="function" value="closejob">Close Job</td>
		</tr>
		<tr>
		<td colspan="3" align="center">
		<input type="hidden" name="ID" value="<?php echo 	$HTTP_POST_VARS['ID']; ?>">
		<input type="hidden" value="Submit" name="Submit">
		<input type="submit" value="Assign" name="Assign">
		</td></tr></table>

		<?php
		}

	if ($Assign == "Assign")
		{
		$connect=mysql_connect("localhost","user","pass");

		$select=mysql_select_db("db");

		$query= mysql_query ("SELECT * FROM openjobs WHERE ID ='$ID'");

		$num_results = mysql_num_rows($query);

		for ($i=0; $i <$num_results; $i++)
			{
			$row = mysql_fetch_array($query);

			if ($function == "engagementletter")
				{
				if (!$Engage)
					{
					?>
					<table style="color:#000000; font-family:verdana; font-size:10px;">
					<tr><td>564 Saratoga Road</td><td><img src="images/bullet.gif"></td><td>King of Prussia, PA 19406</td><td><img src="images/bullet.gif"></td><td>Telephone [phone]</td><td><img src="images/bullet.gif"></td><td>FAX [phone]</td></tr>
					</table>
					<p align="left">
					<br />
					<b>ENGAGEMENT LETTER PREVIEW:</b><br /><br />
					<?php
					$today = date('F jS, Y');
					print_r($today);

					echo '<br /><br />'.$row['Firm'].'<br />'.$row['Address'].'<br />'.$row['City'].', '.$row['State'].' '.$row['Zip'].'<br /><br /><br />

					Dear '.$row['Name'].',<br /><br />

Blah Blah Blah
	.<br /><br />
					Sincerely,<br />
					<img src="images/signature.gif"><br />
					Jerrold A. Bierhoff, CPA<br /><br /><br />

					<input type="radio" checked="checked" name="sendengagement" value="yes">Send Engagement Letter<br />
					<input type="radio" name="sendengagement" value="no">Cancel<br /	>';

					?>
					<input type="hidden" name="ID" value="<?php echo $row['ID']; ?>">
					<input type="hidden" name="function" value="<?php echo $HTTP_POST_VARS['function']; ?>">
					<input type="hidden" value="Submit" name="Submit">
					<input type="hidden" value="Assign" name="Assign">
					<input type="submit" value="Engage" name="Engage">

					<?php
					}

				if ($Engage == '$HTTP_POST_VARS[Engage]')
					{
					if ($sendengagement == "yes")
						{
						?>
						<font color="red">Engagement Letter Submitted</font><br /><br />
						<a href="openjobmanager.php" class="roll">Go back.</a>
						<?php

						$routed_to_email = $row['Email'];
						$routed_to_url = 'http://www.jbierhoff.com/engagement.php?ID='.$row['ID'];
						$routed_subject = 'Jerrold A. Bierhoff, CPA Engagement Letter';
						$routed_content = 'As per our conversation, we have submitted to you an engagement letter for your peer review..   \n\n Please <a href="'.$routed_to_url.'" target="_blank">click here</a> \n\n Sincerely,\nJerrold A. Bierhoff, CPA';
						$routed_from_email = 'From: [email][e-mail][/email]';

						mail($routed_to_email, $routed_subject, $routed_content, $routed_from_email);

						?>

						<input type="hidden" name="ID" value="<?php echo $row['ID']; ?>">
						<input type="hidden" name="function" value="<?php echo $HTTP_POST_VARS['function']; ?>">
						<input type="hidden" name="sendengagement" value="<?php echo $HTTP_POST_VARS['sendengagement']; ?>">
						<input type="hidden" value="Submit" name="Submit">
						<input type="hidden" value="Assign" name="Assign">
						<input type="hidden" value="Engage" name="Engage">

						<?php
						}

					if ($sendengagement == "no")
						{
						?>
						<font color="red">Engagement Letter Cancelled</font><br /><br />
						<a href="openjobmanager.php" class="roll">Go back.</a>

						<input type="hidden" name="ID" value="<?php echo $row['ID']; ?>">
						<input type="hidden" name="function" value="<?php echo $HTTP_POST_VARS['function']; ?>">
						<input type="hidden" name="sendengagement" value="<?php echo $HTTP_POST_VARS['sendengagement']; ?>">
						<input type="hidden" value="Submit" name="Submit">
						<input type="hidden" value="Assign" name="Assign">
						<input type="hidden" value="Engage" name="Engage">

						<?php
						}
					}
				}

			if ($function == "invoice")
				{



				}


			if ($function == "survey")
				{



				}

			if ($function == "closejob")
				{
				$connect=mysql_connect("localhost","user","pass");

				$select=mysql_select_db("db");

				$query= mysql_query ("SELECT * FROM openjobs WHERE ID ='$ID'");

				$num_results = mysql_num_rows($query);

				for ($i=0; $i <$num_results; $i++)
					{
					$closeddate = date('m/d/y');
					$row = mysql_fetch_array($query);

					mysql_query("INSERT INTO closedjobs (ID,Firm,Name,Address,City,State,Zip,Phone,Email,ReviewType,ReviewDate,EngLettAccept,Invoiced,Fee,ClosedDate) VALUES ('$row[ID]','$row[Firm]','$row[Name]','$row[Address]','$row[City]','$row[State]','$row[Zip]','$row[Phone]','$row[Email]','$row[ReviewType]','$row[ReviewDate]','$row[EngLettAccept]','$row[Invoice]','$row[Fee]','$closeddate')");

					}
				}
			}

		}
	}
}

if (!isset($HTTP_SESSION_VARS['valid_user']))
	{
	include("top_backend.php");
	include("nav_login.php");
	?>
	<br /><br />
	Error: you are not <a href="login.php" class="roll">logged in.</a><br /><br /><br /><br /><br />
	<?php
	include("bottom.php");
	}

?>



</form>

[rehfeld]

i havent looked at your code in depth, but the first thing i noticed is that your are assuming register globals is turned on. if its not your code cannot possibly work.

recent version of php have it off by default, which is good for security.

instead of using
if (!$Submit)

you need to use the superglobals:
if (!$GET['Submit'])
or
if (!$POST['Submit'])
or
if (!$_COOKIE['Submit'])

etc....

search for "register globals" to find more info

i strongly suggest writing your code so it will work w/out register globals. very few hosts have it turned on anymore and that means your code will flat out fail.

same goes for using the old deprecated $HTTP*VARS arrays. now most hosts DO still enable these, but some dont and if thats the case, again, the code will fail

use $GET $POST $COOKIE $REQUEST $SESSION $SERVER $FILES $ENV etc......

try to avoid tutorials and scripts which dont use the current coding standards.

[robert_w_ark]

first line (not sure if $PHP_SELF is valid)

use $_SERVER['PHP_SELF'] and set a variable if needed.