[Resolved] MySQL Errors....

[bpat1434]

HI guys.

I am having trouble with this:

I have a file with 3 functions in it. Identical, but pulling different info. Another script calls these functions separately and formats it to the webpage.

Everything works ok on my main page, but when I go to any other page, I get riddled with errors. Not sure what's going on.

Example: http://www.winfieldvfd.org

Click on "Read More" and you'll see all the errors I get. Usually they follow this syntax:

Warning: mysql_query(): supplied argument is not a valid MySQL-Link resource in /home/winfield/public_html/scripts/includes/sideitems.php on line 9

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/winfield/public_html/scripts/includes/sideitems.php on line 11

Here's my scripts:

3 Functions in 1 script

function news(){
	require_once($_SERVER['DOCUMENT_ROOT'].'/scripts/connection.php');

global $dbc;

$query = "SELECT * FROM `main_news` ORDER BY `id` DESC LIMIT 3";
$result = mysql_query($query, $dbc);

if(!mysql_num_rows($result)){
	echo '<div class="news-wrap">'."\n".
			'<p class="nItem">No news items were found.</p>'."\n".
			'</div>'."\n";
}
else{
	while($display = mysql_fetch_array($result)){
		$id = $display['id'];
		$title = $display['Title'];
		$short = $display['Intro'];

		echo '<div class="news-wrap">'."\n".
				'<h3>'.$title.'</h3>'."\n".
				'<p class="nItem">'.$short.'<br />'."\n".
				'<a href="http://www.winfieldvfd.org/read.php?cat=news&id='.$id.'">Read More...</a></p>'."\n".
				'</div>'."\n";
	}
}
}

function events(){
	require_once($_SERVER['DOCUMENT_ROOT'].'/scripts/connection.php');

global $dbc;

$query = "SELECT * FROM `main_events` ORDER BY `eDate` ASC LIMIT 3";
$result = mysql_query($query, $dbc);

if(!mysql_num_rows($result)){
	echo	'<div class="news-wrap">'."\n".
				'<p class="nItem">No Events were found.</p>'."\n".
				'</div>'."\n";
}
else{
	while($display = mysql_fetch_array($result)){
		$id = $display['id'];
		$edate = $display['eDate'];
		$title = $display['Title'];
		$short = $display['Intro'];

		echo	'<div class="news-wrap">'."\n".
					'<h3>'.$title.'</h3>'."\n".
					'<p class="nItem"><i>'.$edate.'</i><br />'.$short.'<br />'."\n".
					'<a href="http://www.winfieldvfd.org/read.php?cat=events&id='.$id.'">Read More...</a></p>'."\n".
					'</div>';
	}
}
}

function majorcalls(){
	require_once($_SERVER['DOCUMENT_ROOT'].'/scripts/connection.php');

global $dbc;

$query = "SELECT * FROM `main_majorcalls` ORDER BY `Date` DESC LIMIT 3";
$result = mysql_query($query, $dbc);

if(!mysql_num_rows($result)){
	echo	'<div class="news-wrap">'."\n".
					'<p class="nItem">No Major Calls were found.</p>'."\n".
					'</div>'."\n";
}
else{
	while($display = mysql_fetch_array($result)){
		$id = $display['id'];
		$date = $display['Date'];
		$title = $display['Title'];
		$short = $display['Intro'];

		echo	'<div class="news-wrap">'."\n".
						'<h3>'.$date.' - '.$title.'</h3>'."\n".
						'<p class="nItem">'.$short.'<br />'."\n".
						'<a href="http://www.winfieldvfd.org/read.php?cat=news&id='.$id.'">Read More...</a></p>'."\n".
						'</div>';
	}
}
}

Formatting Script

function sidebar(){	
	require_once($_SERVER['DOCUMENT_ROOT'].'/scripts/includes/sideitems.php');

echo '<div class="news"><h2>News</h2>'."\n";
news();
echo "\n".'</div>'."\n".
 '<br>'."\n".
 '<div class="news"><h2>Events</h2>'."\n";
events();
echo "\n".'</div>'."\n".
 '<br>'."\n".
 '<div class="news"><h2>Major Calls</h2>'."\n";
majorcalls();
echo "\n".'</div>'."\n";
}

Page to be Displayed

<div id="content-wrap">
		<div id="left-wrap">
			<? sidebar(); ?>
		</div>

	<div class="content">
		<? showItem(); ?>
	</div>
</div>

Any help you can offer would be greatly appreciated. Thanks.

~Brett

[kburger]

Where is $dbc being defined?

[bpat1434]

$dbc is defined in my connection.php file.

conifg.php

<?php
$dbhost = 'localhost';
$dbuser = 'winfield_madmin';
$dbpass = 'w1nf13ld14';
$database = 'winfield_mainSite';
?>

connection.php

<?php

require_once($_SERVER['DOCUMENT_ROOT'].'/scripts/includes/config.php');

global $dbhost, $dbuser, $dbpass, $database;

$dbc = mysql_connect($dbhost, $dbuser, $dbpass);
mysql_select_db($database, $dbc);

?>

[bpat1434]

bump

As much as I hate to bump topics, I really do need this answered as fast as possible. So, to reitterate...

I get database connection errors in sub-pages when there are 4 simultaneous queries going on. Only thing I don't understand is that on the front page there is the same code, and the page works.

Any help you can offer would be appreciated.

The pages are set up like they are so that when and if I give the website to someone else, it will be easier for them to modify things.

~Brett

[kburger]

Can you show us your read.php and sideitems.php files? I'm wondering if maybe the DB connection is being closed somewhere before a call to the functions.

[bpat1434]

Well, I never close the connection in the first place (perhaps a problem?), nor do i use a persistent connection.

But here are the files you request:

read.php

<?php
require_once($_SERVER['DOCUMENT_ROOT'].'/scripts/sidebar.php');
require_once($_SERVER['DOCUMENT_ROOT'].'/scripts/display/showItem.php');
?>
<!-- HTML CODE -->
<div id="left-wrap">
			<? sidebar(); ?>
		</div>

	<div class="content">
		<? showItem(); ?>
	</div>
<!-- HTML CODE -->

SideItems.php

<?php
require_once($_SERVER['DOCUMENT_ROOT'].'/scripts/connection.php');

function news(){

global $dbc;

$query = "SELECT * FROM `main_news` ORDER BY `id` DESC LIMIT 3";
$result = mysql_query($query, $dbc);

if(!mysql_num_rows($result)){
	echo '<div class="news-wrap">'."\n".
			'<p class="nItem">No news items were found.</p>'."\n".
			'</div>'."\n";
}
else{
	while($display = mysql_fetch_array($result)){
		$id = $display['id'];
		$title = $display['Title'];
		$short = $display['Intro'];

		echo '<div class="news-wrap">'."\n".
				'<h3>'.$title.'</h3>'."\n".
				'<p class="nItem">'.$short.'<br />'."\n".
				'<a href="http://www.winfieldvfd.org/read.php?cat=news&id='.$id.'">Read More...</a></p>'."\n".
				'</div>'."\n";
	}
}
}

function events(){

global $dbc;

$query = "SELECT * FROM `main_events` ORDER BY `eDate` ASC LIMIT 3";
$result = mysql_query($query, $dbc);

if(!mysql_num_rows($result)){
	echo	'<div class="news-wrap">'."\n".
				'<p class="nItem">No Events were found.</p>'."\n".
				'</div>'."\n";
}
else{
	while($display = mysql_fetch_array($result)){
		$id = $display['id'];
		$edate = $display['eDate'];
		$title = $display['Title'];
		$short = $display['Intro'];

		echo	'<div class="news-wrap">'."\n".
					'<h3>'.$title.'</h3>'."\n".
					'<p class="nItem"><i>'.$edate.'</i><br />'.$short.'<br />'."\n".
					'<a href="http://www.winfieldvfd.org/read.php?cat=events&id='.$id.'">Read More...</a></p>'."\n".
					'</div>';
	}
}
}

function majorcalls(){

global $dbc;

$query = "SELECT * FROM `main_majorcalls` ORDER BY `Date` DESC LIMIT 3";
$result = mysql_query($query, $dbc);

if(!mysql_num_rows($result)){
	echo	'<div class="news-wrap">'."\n".
					'<p class="nItem">No Major Calls were found.</p>'."\n".
					'</div>'."\n";
}
else{
	while($display = mysql_fetch_array($result)){
		$id = $display['id'];
		$date = $display['Date'];
		$title = $display['Title'];
		$short = $display['Intro'];

		echo	'<div class="news-wrap">'."\n".
						'<h3>'.$date.' - '.$title.'</h3>'."\n".
						'<p class="nItem">'.$short.'<br />'."\n".
						'<a href="http://www.winfieldvfd.org/read.php?cat=news&id='.$id.'">Read More...</a></p>'."\n".
						'</div>';
	}
}
}

?>

[Weedpacket]

If you've only got the one database connection you shouldn't need to refer toit by name anyway (mysql_query's link identifier argument is optional). By that argument all the global $dbc declarations can go, and mysql_query($query, $dbc) can be just mysql_query($query).

So: assuming that SideItems.php (and hence connection.php) is being included before any of the code that calls any of those functions, I'm wondering if the database connection is even being established in the first place. Maybe it's mysql_connect or (more likely) mysql_select_db that's failing?

On a side note, if you've got three functions that are almost identical, you might like to think about replacing them with one function that gets called with three different arguments. Makes for less code that way.

[bpat1434]

Weed,

Thanks for your help. I'll look at it tomorrow. But while I'm at it....

Using the code above (sideItems.php) how would you suggest I cut it down so that it is less code?

The reason that they're different functions is because each outputs a certain piece of the site (news, major calls, and events) on the left hand side. By keeping the functions separate, I can call them as I need. But I'm always up for suggestions.

Let me know if I'm on the right track with this:

<?php
require_once($_SERVER['DOCUMENT_ROOT'].'/scripts/connection.php');

function sidebar(){
	//
	// Current News Items
	//
	echo '<div class="news"><h2>News</h2>'."\n";

$query = "SELECT * FROM `main_news` ORDER BY `id` DESC LIMIT 3";
$result = mysql_query($query);

if(!mysql_num_rows($result)){
	echo '<div class="news-wrap">'."\n".
		'<p class="nItem">No news items were found.</p>'."\n".
		'</div>'."\n";
}
else{
	while($display = mysql_fetch_array($result)){
		$id = $display['id'];
		$title = $display['Title'];
		$short = $display['Intro'];

		echo '<div class="news-wrap">'."\n".
			'<h3>'.$title.'</h3>'."\n".
			'<p class="nItem">'.$short.'<br />'."\n".
			'<a href="http://www.winfieldvfd.org/read.php?cat=news&id='.$id.'">Read More...</a></p>'."\n".
			'</div>'."\n";
	}
}
echo "\n".'</div>'."\n".
	'<br>'."\n".
//
// Upcoming Events
//
 '<div class="news"><h2>Events</h2>'."\n";

$query = "SELECT * FROM `main_events` ORDER BY `eDate` ASC LIMIT 3";
$result = mysql_query($query);

if(!mysql_num_rows($result)){
	echo	'<div class="news-wrap">'."\n".
			'<p class="nItem">No Events were found.</p>'."\n".
			'</div>'."\n";
}
else{
	while($display = mysql_fetch_array($result)){
		$id = $display['id'];
		$edate = $display['eDate'];
		$title = $display['Title'];
		$short = $display['Intro'];

		echo	'<div class="news-wrap">'."\n".
				'<h3>'.$title.'</h3>'."\n".
				'<p class="nItem"><i>'.$edate.'</i><br />'.$short.'<br />'."\n".
				'<a href="http://www.winfieldvfd.org/read.php?cat=events&id='.$id.'">Read More...</a></p>'."\n".
				'</div>';
	}
}

echo "\n".'</div>'."\n".
	 '<br>'."\n".
	//
	// Recent Major Calls
	//
	 '<div class="news"><h2>Major Calls</h2>'."\n";

$query = "SELECT * FROM `main_majorcalls` ORDER BY `Date` DESC LIMIT 3";
$result = mysql_query($query);

if(!mysql_num_rows($result)){
	echo	'<div class="news-wrap">'."\n".
			'<p class="nItem">No Major Calls were found.</p>'."\n".
			'</div>'."\n";
}
else{
	while($display = mysql_fetch_array($result)){
		$id = $display['id'];
		$date = $display['Date'];
		$title = $display['Title'];
		$short = $display['Intro'];

		echo	'<div class="news-wrap">'."\n".
				'<h3>'.$date.' - '.$title.'</h3>'."\n".
				'<p class="nItem">'.$short.'<br />'."\n".
				'<a href="http://www.winfieldvfd.org/read.php?cat=news&id='.$id.'">Read More...</a></p>'."\n".						'</div>';
	}
}
echo "\n".'</div>'."\n";
}

?>

That was brought down from 2 pages sideItems.php and sidebar.php(The Formatting Script)

~Brett

----[ EDIT ]----
I used the code that I posted above, and fixed my query in showItem.php and it all works now. Thanks for your help guys.

~Brett