quick 'get' help

[guest]

can someone tell me whats wrong with this script?

	if ($_GET['theme'] = "1"){$main = "index1.php";}
	if ($_GET['theme'] = "2"){$main = "index12.php";}
		if (empty($_GET['theme'])){$main = 'index1.php';}

include "$main";

what happens is that it prints out 'index12.php' everytime and the 1 or 2 isnt making the difference

[planetsim]

At the moment you are assigning the value of 1 then 2 in the next if

Try this

switch ($_GET['theme'])
{
case 1:
    $main = "index1.php";
break;
case 2:
    $main = "index12.php";
break;
default:
    $main = 'index1.php';
break;
}
include $main;

Id suggest also reading up on comparison operators which is what you should have been using in the if's http://www.php.net/manual/en/language.operators.comparison.php

[Frederick]

$theme = $_GET["theme"];
if (!isset($theme)) {$main = "index1.php";} 
if ($theme == 1) {$main = "index1.php";} 
elseif ($theme == 2){$main = "index12.php";} 

include $main;

[dewen]

$_GET['theme'] = "1" is an assignment, not a comparison.

consider $_GET['theme'] == "1"

[Roger_Ramjet]

And consider using the 'Switch' instead of if-else. It will be easier to add a new case to a switch than to add an elseif when the need arises, and it is much easier to follow the logic of the code. Case Select (switch) also executes faster than nested ifs or if-elseif-else, in all the languages I know anyway.