weird problem with calendar script

dud3r

Here's my calendar script:

//--------------CALENDAR---------------------------------//
echo "<table border=0 width=100% class=class=td_cells>";
echo "<tr>";
echo "<td class=td_cells>Sun</td>";
echo "<td class=td_cells>Mon</td>";
echo "<td class=td_cells>Tue</td>";
echo "<td class=td_cells>Wed</td>";
echo "<td class=td_cells>Thu</td>";
echo "<td class=td_cells>Fri</td>";
echo "<td class=td_cells>Sat</td>";
echo "</tr>";
for ($i = 0; $i <= $t_days; $i++){
if ($day > 6) {
echo "</tr><tr>";
$day = 0; 
}
if ($i == date("j")) {
echo "<td class=td_title align=center>";
echo "<b>";
echo $i; $day++; 
echo "</b></td>"; 
}
else if ($i > 0) {
echo "<td class=td_cells align=center>";
echo $i; $day++; 
echo "</td>"; }
else if ($day > 0) {
echo "<tr>";
echo "<td class=td_cells colspan=".$day."></td>\n"; 
}
if ($i == $t_days && $day < 6) {
echo "<td colspan=".
7 - $day."></td>\n</tr>\n"; 
}
}
echo "</table>";
//-----------------------------------------------//

Now, for some reason it say "-2>" above the days of the week. I attached a screenshot of that. What did I do wrong?

robert_w_ark

umm shouldnt this line:

if ($i == $t_days && $day < 6) {

be this:

if ($i == $t_days && $day <= 7) {

just wonderin \=

dud3r

no..

scrupul0us

theres an error here:

echo "<table border=0 width=100% class=class=td_cells>";

"class=class=td_cells" that doesnt look right but isnt the source of the problem...

when i run the code on my end i dont even get anything past the days of the week

where are your variables defined?

connected

if ($i == $t_days && $day < 6) {
echo "<td colspan=".
7 - $day."></td>\n</tr>\n"; 
}

Congradulations, you are banging your head against my favorite wall. It's called "operator precedence," and it exists to make your life miserable. Although the concatenation (.) and addition (+) operators have the same precedence, they follow a left associativity--that is, they are evaluated from left to right. So when you say "<td colspan=". 7 - $day, you are telling PHP to concatenate "<td colspan=" and 7 first, then subtract $day from the result. A quote from the aforementioned link:

Parentheses may be used to force precedence, if necessary.

With that in mind, you need to re-write your code as follows:

if ($i == $t_days && $day < 6) {
echo "<td colspan=".
(7 - $day)."></td>\n</tr>\n"; 
}

This will substract $day from 7, then concatenate the result with the rest of the string. I advise you remember this well; it will save you many nights of sleeplessness.

Hope that helps.

dud3r

That fixed it. Thanks buddy.

Oh yea that "class=class=" was a mistake. I wrote it twice by accident. Thanks for pointing that out too.