Problem with list() = each();

Chris_Evans

Hi there,
This is the code:

			while(list($key, value) = each($_POST['relatedlinks'])) {
				if(!is_numeric($value)) {
					die("Hacking attempt. Form not submitting numeric values.");
				} else {
					$relatedlinks_id[$key] = $value;
				}
			}

Firstly I'm positive there's a quicker way of doing that - but secondly if there isn't I can't figure this but apparently it wants a , or a ) on the first line. Not sure why though... I think I've got it all there. 😐

Thanks,

Chris

Installer

This is what "foreach" was made to replace. Try:

foreach ($_POST['relatedlinks'] as $value) { 
    if (!is_numeric($value)) { 
        die("Hacking attempt. Form not submitting numeric values."); 
    }
}
$relatedlinks_id = $_POST['relatedlinks'];

You didn't have "$" in front of "value".

Weedpacket

I prefer [man]foreach[/man] myself....

You could look at $relatedlinks_id = [man]array_filter/man;. Dunno if that would be faster - and trying to make this bit of the program faster probably isn't worth the effort anyway - but if the length of the $relatedlinks_id is less than that of $_POST['relatedlinks'] then some of the submitted fields were not numeric. Come to think of it, it would probably be slower - but like I said, the difference probably isn't worth the effort.

Chris_Evans

Hi there,
The foreach doesn't work. The field 'relatedlinks' is a group of checkboxes. It only returns the last value?

Thanks,

Chris

dewen

make sure in your form use:

foreach should work

Chris_Evans

Hi there,
Yes I am using that. I'll have another go though, give me a few minutes as got to figure an SQL problem now. 😛

Chris.