[Resolved] help with rating script

[dud3r]

Ok, so I'm making a script that allows members rate over members on the site. I didn't really know where to start but here's what I did:
I made a user database where various user information is stored along with 19 rows that start with u1 and end with u_10. They increase at 0.5.. so after u1 there's u1_5 (u1.5 but I used "_" instead of a dot).
Too keep members from voting twice, I created another table with the following fields:

CREATE TABLE rates (
id int(5) NOT NULL auto_increment,
user varchar(50) NOT NULL default '',
timestamp varchar(50) NOT NULL default '',
rate varchar(50) NOT NULL default '',
ip varchar(36) NOT NULL default '',
voter varchar(25) NOT NULL default '',
PRIMARY KEY (id)
) TYPE=MyISAM AUTO_INCREMENT=1 ;

Anyways, when the user is rated (through a radio button.. not that this matters anyway). For example, if the radio button with the value of 1 is clicked, 2 things happen:

Here the user database is updated for a user that puts "1" in the field that represents a 1 rating (u1):

mysql_query("UPDATE users SET u1 = u1 + 1 WHERE username = '$new_name'");

Here, data is entered into "ratings" table so users are prevented from voting twice for the same member:

mysql_query("INSERT INTO rates (user,timestamp,voter,ip,rate) VALUES ('$username',now(),'$voter','$ip','1')");

Basically, I tried hiding the table with my radio buttons from users who voted for that member already. It doesn't seem to work. I know I'm doing something wrong for sure and I need some guidance (haha) from you guys again.

I tried doing this to hide the table from members who already rated a user and show the table to those who haven't but it didn't work. It hides the table from me only when I vote for my own username.

$result = mysql_query("SELECT * FROM rates");
while ($row = mysql_fetch_array($result,MYSQL_ASSOC)) {
if($row['user']==$username && $row['voter']==$_COOKIE['Username']){
	echo "You rated this member a ".$row['rate'];
}
else {
// show table with ratings and such here
}
}

Any ideas?

[bpat1434]

Ok... here's an attempt....

Try this:

$result = mysql_query("SELECT * FROM rates");
while ($row = mysql_fetch_array($result,MYSQL_ASSOC)) {
if( ($row['user']==$username) && ($row['voter']==$_COOKIE['Username']) ){
    echo "You rated this member a ".$row['rate'];
}
else {
// show table with ratings and such here
}
}

Another thing to think about is are you calling the cookie correctly? I don't do cookies, I use sessions. But if you are, then my guess is that there is something going on with the $username variable. Where do you define it?

~Brett

[dud3r]

$username is called from the user profile page. for example, profile.php?username=$username. If a user clicks on, I don't know.. "user" then $username would be profile.php?username=user.
I tried putting them in parenthesis but I still get the same result. =\

Edit: Yes, I'm sure I'm calling the cookie correctly. I call it the exact same way in other pages and they all work.

[bpat1434]

Ok. So I came up with my own page to test things out. Here's what i have:

I set the $username and $_COOKIE[] values because I'm not going for full functionality. This code works.

Viewable Here
Just click on User Ratings Table.
Code will be printed below output.

Basically, I don't know what is causing yoru script to not work. Perhaps it is how you are calling your variables $username. Since you don't show how you retrieve the variable, I can't be sure.

~Brett

[dud3r]

That's not exactly what I wanted.
Basically, what I want is:

mysql table rates

| id | user | rated_by |

| 1 | user1 | person1 |

| 2 | user2 | person2 |

| 3 | user3 | person3 |

I want PHP to load fields from that table and show "You already rated $row['user']" if $COOKIE['Username'] matches an entry in field "rated_by" where $username matches the entry in field "user" so that person cannot vote for the same person twice.
If $COOKIE['Username'] doesn't match any entry where field "user" is equal to $username, then it should display the table with the radio buttons.

I wrote the script that enters data into table rates I just don't know how to make PHP check and make sure the a person can't vote for the same user twice.

[bpat1434]

So basically, what you're telling me is:

A user comes to the site, votes for people. Those that they have voted are not to be voted again. If they haven't voted, then show the rating form.

Sounds easy enough:

As always... Viewable Here
Just click on User Ratings Table.
Code will be printed below output.

That should work. I don't understand why your code now is not working. What exact error are you getting? Use mysql_errno() and mysql_error() to find out.

EDIT
I figured out your problem. If you go to my page, you can see the same proble you're having (right?).
~Brett

[bpat1434]

Ok, so you send the username through the URL correct? Doing so make the username static so that they would be able to view the persons profile, but not vote if they have already voted. The easiest way to do this is just to check if their cookie name shows up in the rated_by column (voter in my scripts). You don't need the second check because you'll always come up with errors.

Check out my working example:
Viewable Here
Just click on User Ratings Table.
Code will be printed below output.
The top version is what I think your problem is. You can only pull the ones where both criteria are matched. Version 2 is the one that you should go with. I'll post the entire php script. The only difference is the if() statement.

<?php
$username = "someone";
$cookie = "brett2";

$dbc = mysql_connect("localhost", "db_username", "********");
mysql_select_db("Database", $dbc);

$query = "SELECT * FROM `rates` ORDER BY id DESC";
$result = mysql_query($query) or die('<b>'.mysql_errno().'</b><br>'.mysql_error());

echo '<table border="1">'.
        '<tr><th>User</th>'.
        '<th colspan="5">Rating</th></tr>';

while($row = mysql_fetch_array($result)){
    if( ($username == $row['user']) && ($cookie == $row['voter']) ){
        /* Display the "Already Voted" line */
        echo('<tr><td>'.$row['user'].'</td><td colspan="5">You have already voted for this person.  You gave them the following rating: '.$row['rate'].'</td></tr>');
    } // End If Statement

else{
    /* Display the voting table */
    echo '<tr>'.
			'<td>'.$row['user'].'</td>'.
            '<td><input type="radio" value="1">1</td>'.
            '<td><input type="radio" value="2">2</td>'.
            '<td><input type="radio" value="3">3</td>'.
            '<td><input type="radio" value="4">4</td>'.
            '<td><input type="radio" value="5">5</td>'.
            '</tr>';
} // End Else Statement

} // End While Loop

echo('</table>');

echo('<h2>Version 2</h2><b>User:</b> brett2<br>');
/* Version 2 */
$query = "SELECT * FROM `rates` ORDER BY id DESC";
$result = mysql_query($query) or die('<b>'.mysql_errno().'</b><br>'.mysql_error());

echo '<table border="1">'.
        '<tr><th>User</th>'.
        '<th colspan="5">Rating</th><th>Rated By (Voter)</th></tr>';

while($row = mysql_fetch_array($result)){
    if($cookie == $row['voter']){
        echo('<tr><td>'.$row['user'].'</td><td colspan="5">You have already voted for this person.  You gave them the following rating: '.$row['rate'].'</td><td>'.$row['voter'].'</tr>');
    }

else{
    echo '<tr>'.
			'<td>'.$row['user'].'</td>'.
            '<td><input type="radio" value="1">1</td>'.
            '<td><input type="radio" value="2">2</td>'.
            '<td><input type="radio" value="3">3</td>'.
            '<td><input type="radio" value="4">4</td>'.
            '<td><input type="radio" value="5">5</td>'.
			'<td>'.$row['voter'].'</td>'.
            '</tr>';
}

}

echo('</table>');

?> 

I've also attached a screenshot of my database so you can see how I have it set up.

~Brett

[dud3r]

The second example is what I need except I need it in the same format as the first example. I think I was very vague when I first started to explain this but thanks for sticking around.

I have 2 files, profile.php and rate.php.

profile.php
EDIT: See attachment. It wouldn't show the whole code here.

rate.php

require('db.php');
global $username,$voter,$ip,$rate1,$rate1_5,$rate2,$rate2_5,$rate3,$rate3_5,$rate4,$rate4_5,$rate5,$rate5_5,$rate6,$rate6_5,$rate7,$rate7_5,$rate8,$rate8_5,$rate9,$rate9_5,$rate10;
$new_name = $username;
if($rate1==True) {
header("Location: profile.php?username=$username");
mysql_query("UPDATE users SET u1 = u1 + 1 WHERE username = '$new_name'");
mysql_query("INSERT INTO rates (user,timestamp,voter,ip,rate) VALUES ('$username',now(),'$voter','$ip','1')");
	exit;
}
if($rate1_5==True) {
header("Location: profile.php?username=$username");
mysql_query("UPDATE users SET u1_5 = u1_5 + 1 WHERE username = '$new_name'");
mysql_query("INSERT INTO rates (user,timestamp,voter,ip,rate) VALUES ('$username',now(),'$voter','$ip','1.5')");
	exit;
}
if($rate2==True) {
header("Location: profile.php?username=$username");
mysql_query("UPDATE users SET u2 = u2 + 1 WHERE username = '$new_name'");
mysql_query("INSERT INTO rates (user,timestamp,voter,ip,rate) VALUES ('$username',now(),'$voter','$ip','2')");
	exit;
}

// it continues from $rate2 to $rate10. I left out the middle part so it doesn't take up so much space in my post on this forum

if($rate9_5==True) {
header("Location: profile.php?username=$username");
mysql_query("UPDATE users SET u9_5 = u9_5 + 1 WHERE username = '$new_name'");
mysql_query("INSERT INTO rates (user,timestamp,voter,ip,rate) VALUES ('$username',now(),'$voter','$ip','9.5')");
	exit;
}
if($rate10==True) {
header("Location: profile.php?username=$username");
mysql_query("UPDATE users SET u10 = u10 + 1 WHERE username = '$new_name'");
mysql_query("INSERT INTO rates (user,timestamp,voter,ip,rate) VALUES ('$username',now(),'$voter','$ip','10')");
	exit;
}

Now, "mysql_query("UPDATE users SET u10 = u10 + 1 WHERE username = '$new_name'");" updates table "users" so I can count those and get an average rating (so it'll be faster or something, I don't know..).

Here's the structures of "users" and "rates"

CREATE TABLE `users` (
  `userid` int(25) NOT NULL auto_increment,
  `email` varchar(25) NOT NULL default '',
  `username` varchar(25) NOT NULL default '',
  `password` varchar(255) NOT NULL default '',
  `user_level` enum('0','1','2','3') NOT NULL default '0',
  `birthdate` datetime NOT NULL default '0000-00-00 00:00:00',
  `signup_date` int(14) default NULL,
  `postcount` int(25) NOT NULL default '0',
  `u_title` varchar(100) NOT NULL default 'e-Lounge newbie',
  `ip` text NOT NULL,
  `theme` varchar(25) NOT NULL default 'default',
  `gender` enum('0','Male','Female') NOT NULL default '0',
  `description` mediumtext NOT NULL,
  `picture_approved` enum('0','1') NOT NULL default '0',
  `u_picture` mediumtext NOT NULL,
  `denied_pic` enum('0','1') NOT NULL default '0',
  `u1` varchar(25) NOT NULL default '0',
  `u1_5` varchar(25) NOT NULL default '0',
  `u2` varchar(25) NOT NULL default '0',
  `u2_5` varchar(25) NOT NULL default '0',
  `u3` varchar(25) NOT NULL default '0',
  `u3_5` varchar(25) NOT NULL default '0',
  `u4` varchar(25) NOT NULL default '0',
  `u4_5` varchar(25) NOT NULL default '0',
  `u5` varchar(25) NOT NULL default '0',
  `u5_5` varchar(25) NOT NULL default '0',
  `u6` varchar(25) NOT NULL default '0',
  `u6_5` varchar(25) NOT NULL default '0',
  `u7` varchar(25) NOT NULL default '0',
  `u7_5` varchar(25) NOT NULL default '0',
  `u8` varchar(25) NOT NULL default '0',
  `u8_5` varchar(25) NOT NULL default '0',
  `u9` varchar(25) NOT NULL default '0',
  `u9_5` varchar(25) NOT NULL default '0',
  `u10` varchar(25) NOT NULL default '0',
  PRIMARY KEY  (`userid`)
) TYPE=MyISAM COMMENT='Membership Information' AUTO_INCREMENT=59 ;

and now finally "rates"

CREATE TABLE `rates` (
  `id` int(5) NOT NULL auto_increment,
  `user` varchar(50) NOT NULL default '',
  `timestamp` varchar(50) NOT NULL default '',
  `rate` varchar(50) NOT NULL default '',
  `ip` varchar(36) NOT NULL default '',
  `voter` varchar(25) NOT NULL default '',
  PRIMARY KEY  (`id`)
) TYPE=MyISAM AUTO_INCREMENT=3 ;

[dud3r]

here's the part of Profile.php I'm working with.

[bpat1434]

Ok, I'm lost.

Why is it that you are using ALL KINDS of variables ($rate1, $rate1_5, $rate2, $rate2_5...). Why not just use a simple switch function? Your form would look like so:

<input type="radio" name="rating" value="1">1
<input type="radio" name="rating" value="1.5">1.5
....
<input type="radio" name="rating" value="9.5">9.5
<input type="radio" name="rating" value="10">10

And when you submit it, then you get the value of the radio button (whcih would be the radio) and you do a switch:

<?php
$rating = $_REQUEST['rating'];

switch($rating){
    case "1":
        // Do query
        break;
    case "1.5":
        // Do query
        break;
    ....
    case "9.5":
        // Do query
        break;
    case "10":
        // Do query
        break;
}

That would work better, and be less code. You wouldn't have all those if()s just lying around. Makes more sense to me. Then you can tie this in wherever you need it.

Also, take out all those u1, u1_5 and just use a table that is like this:

rates (keep the same)
CREATE TABLE rates (
id int(5) NOT NULL auto_increment,
user varchar(50) NOT NULL default '',
timestamp varchar(50) NOT NULL default '',
rate varchar(50) NOT NULL default '',
ip varchar(36) NOT NULL default '',
voter varchar(25) NOT NULL default '',
PRIMARY KEY (id)
) TYPE=MyISAM AUTO_INCREMENT=3 ;

users
CREATE TABLE users (
// All the same junk above
// Your u1 stuff used to be here
rating varchar(25) NOT NULL default '0',
totalvotes varchar(25) NOT NULL defautl '0',
// Same junk below[/code]

That way, you can pull the info as you wish from either database. You can see who voted how by pulling info from the rates db, and see what the avg out of total votes is from the users db. Lots easier. And with the switch.... way better.

~Brett

[dud3r]

I haven't tried it yet but by the looks of things it won't solve the existing problem. I still haven't used the u_1 or u1_5 crap yet so it didn't even play a part in the script.
It seems to me that if more than one entry's in the rates table, the whole system doesn't want to work. :bemused:

[dud3r]

I figured it out. This works. =]

$sql = mysql_query("SELECT * FROM rates where user='$username' AND voter='".$_COOKIE['Username']."'");
$rate_check = mysql_num_rows($sql);

if($rate_check > 0){
	while($row = mysql_fetch_array($sql)){
	foreach( $row AS $key => $val ){
		$$key = stripslashes( $val );
	}
	echo "You rated this member a ".$row['rate'];
		}
} else {
//
// Ratings table
//
}

[bpat1434]

ok....

That's an interesting way to do it. Never thought of that.

Glad to see you got it working.

But what is the difference in output between what I posted earlier and this?

~Brett

[dud3r]

The second version of the script that you posted worked, but I didn't need a table to show who voted for every person. I just needed the voter to see that he/she voted for that particular person in that person's profile and that they can't vote for him/her again.
Thanks for sticking around and trying to help. I really appreciate it.

[bpat1434]

no problem.

~Brett