Variables not being shown??

[Napster]

So in the middle of my code I have this:

$templates['game_play'] .= '
<p class=\"general\">Rated an average of $rate from $x votes.
</div>';

And for some reason the variables $rate and $x are not being shown. I can not figureo out why?? I have other variables in $templates['game_play'] but they are arrays and they are being displayed like this:

....{$game[\'gSwfFile\']}.....

How can I get it to show up?

[jonno946]

are they post, get or cookie variables?

if so, and you have register_globals turned off, you'll need to call them from the suberglobals array like this:

$_POST['x']

$_GET['x']

$_COOKIE['x']

or:

$_REQUEST['x'].

See here for more info:

http://uk.php.net/en/language.variables.predefined

Jonno

[Napster]

They are none of those. They are part of the script like this:

$votes = mysql_query("SELECT * FROM game_reviews WHERE gId = '{$game['gId']}'") or die(mysql_error());

while ($vote = mysql_fetch_object($votes)) {

  $x++;

  $rate += $vote->rating;

}

if (!empty($x)) {

  $rate = round(($rate / $x), 2);

} else {

  $rate = 0;

  $x = 0;

}

$templates['game_play'] .= '
<p class=\"general\">Rated an average of {$game[\'rate\']} from {$game[\'x\']} votes.
</div>';

When I view the script, {$game['gId']} is blank and so is $game[gId]. The message appears like this: Rated an average of from votes.

[jonno946]

change:

$templates['game_play'] .= '
<p class=\"general\">Rated an average of {$game['rate']} from {$game['x']} votes.
</div>';

to:

$templates['game_play'] .= '
<p class=\"general\">Rated an average of ' . $game['rate'] . ' from ' . $game['x'] . ' votes.

you cant do this:

'hello my name is $foo'

as it will appear exactly how it appears above and no variable replacement will be actioned (unless you escape like i have).

you have to use " for variable replacement.

Jonno

[Weedpacket]

Wouldn't the fact that in the original post the string only used single quotes instead of double quotes be relevant? Certainly, since the variables being assiged are called $x and $rate, then their values should be available by using $x and $rate and not some other funky thing involving arrays of database records or whatever that $game thing is supposed to be.

On a side note, couldn't those calculations be done in the query itself?

[TheDefender]

Originally posted by jonno946

you cant do this:

'hello my name is $foo'

as it will appear exactly how it appears above and no variable replacement will be actioned (unless you escape like i have).

Well, that's not entirely true. That's why the [man]eval[/man] function was created.

[Napster]

Ok, so I tried the

$templates['game_play'] .= ' 
<p class=\"general\">Rated an average of ' . $game['rate'] . ' from ' . $game['x'] . ' votes.';

And it works. Though now I am having a problem. The variable $game['gId'] from a higher part of the script is turning up blank and I can not figure out why. I am not changing the value of it at all. Here is the code it is being used it:

$votes = mysql_query("SELECT * FROM game_reviews WHERE gId = '" . $game[gId] . "'") or die(mysql_error());

And it is being used higher up in the script properly a few lines up like this:

$templates['game_play'] = '...
<a href=\"/forum/forum.php?f={$game[\'gId\']}\">Discuss This Game in the Forums</a>
...';

[TheDefender]

Quote your index name:
Change:

$votes = mysql_query("SELECT * FROM game_reviews WHERE gId = '" . $game[gId] . "'") or die(mysql_error());

to:

$votes = mysql_query("SELECT * FROM game_reviews WHERE gId = '" . $game['gId'] . "'") or die(mysql_error());