[Resolved] Javascript Calender & PHP Problem [Plz Help!]

MartinJD

I'm new to php and this has been bugging me no end, I'm sure it's an easy problem, but if someone could point me in the right direction it would be most appreciated.

I'm updating a JS calender on a shopping cart to one thats cross-browser compatible.

The calender shows on the onFocus event of a text box, now the old code works fine. (Except it doesn't work in NS/FireFox)

This is the original code

$tmp_html = '<input type="text" name ="id[' . TEXT_PREFIX . $products_options_name['products_options_id'] . ']" size="' . $products_options_name['products_options_length'] .'" maxlength="' . $products_options_name['products_options_length'] . '" value="' . $cart->contents[$HTTP_GET_VARS['products_id']]['attributes_values'][$products_options_name['products_options_id']] .'" onfocus="getCalendarForProduct(this, \'' . (int)$HTTP_GET_VARS['products_id']. '\')" >  ' . $products_options_name['products_options_comment'] ;

And this is the change I've made

$tmp_html = '<input type="text" name ="id[' . TEXT_PREFIX . $products_options_name['products_options_id'] . ']" size="' . $products_options_name['products_options_length'] .'" maxlength="' . $products_options_name['products_options_length'] . '" value="' . $cart->contents[$HTTP_GET_VARS['products_id']]['attributes_values'][$products_options_name['products_options_id']] .'" onFocus="showCalendar('''',this,this,'getCurrentDate()','holder',0,30,1)" > . ';

I'm sure I have the syntax wrong, maybe not escaping something? ...

I hope someone can help me see where i'm going wrong.

All the best, and happy new year.

Martin

MartinJD

if i just do onFocus="showCalender()"> '; it pops up fine, but I can't set dates etc.

Any idea's why this won't parse correctly in the above code?

onFocus="ShowCalender('', this, null, 'getCurrentDate()', 'holder', 0,30, 1)"> ';

I'm fully stuck on this, have been at it for hours and if anyone can give any insight i'll owe you bigtime!

Martin

Weedpacket

Try looking at the generated Javascript. Since you're using Firefox, try looking to see what if any errors are reported in its Javascript console.

If you can confirm it is a PHP problem, (and even if you can't, for appearances' sake!) consider simplifying the PHP to make it easier to debug (this being a rewrite of the original code - since vBulletin is wonky when it comes to displaying \ characters it's hard to say whether you've got everything properly escaped or not - the syntax highlighting looks suspect, though):

$options_id = $products_options_name['products_options_id']
$text_options_id = TEXT_PREFIX . $options_id;
$options_length = $products['products_options_length'];
$options_value = $cart->contents[$_GET['products_id']] ['attributes_values'] [$options_id];
$product_id = (int)$_GET['products_id'];
$options_comment = $product_options_name['products_options_comment'];
$tmp_html = <<<EOT
<input type="text" name ="id[$text_options_id]"
size="$options_length" maxlength="$options_length" value="$options_value"
onfocus="getCalendarForProduct(this, '$product_id')">$options_comment
EOT;

MartinJD

Hi people..

Just an update to say I found the problem... I'm so pleased lol... bloody stupid little thing that took this newbie so so so long..

btw, I recommend everyone buys Zend Studio! ..It's a god send and without it I don't think i would have solved this myself. (ps . i don't work for zend lol)

Basically i wasn't escaping correctly, but the in-line code helper thing made it easy.

$tmp_html = '<input type="text" name ="id[' . TEXT_PREFIX . $products_options_name['products_options_id'] . ']" size="' . $products_options_name['products_options_length'] .'" maxlength="' . $products_options_name['products_options_length'] . '" value="' . $cart->contents[$HTTP_GET_VARS['products_id']]['attributes_values'][$products_options_name['products_options_id']] .'" onfocus="showCalendar(\'\',this,this,\'getCurrentDate()\',\'holder\',0,30,1)" >';