[RESOLVED] Uploading Files Problems

bpat1434

Hey Guys.

Having a bit of trouble here. I can't seem to remedy the problem:

I follow the php.net tut for uploading files via HTTP. I then go to move them to a directory, and I get errors saying that the uploaded file doesn't exist even though $_FILES['userfile']['error'] is 0 (which means everything was fine).

Warning: move_uploaded_file(/home/bpat1434/public_html/images/photos/2004/test/Pics/test.html.bak): failed to open stream: No such file or directory in /home/bpat1434/public_html/test/scripts/upit.php on line 16

Warning: move_uploaded_file(): Unable to move '/tmp/php40lMX5' to '/home/bpat1434/public_html/images/photos/2004/test/Pics/test.html.bak' in /home/bpat1434/public_html/test/scripts/upit.php on line 16

There was an error!

File Size: 0.5576171875 MB

File Location: /home/bpat1434/public_html/images/photos/2004/test/Pics/

Direct Link: /home/bpat1434/public_html/images/photos/2004/test/Pics/test.html.bak
Error #: 0
Temp:

Debugging Info:
Array
(
[userfile] => Array
(
[name] => test.html.bak
[type] => application/octet-stream
[tmp_name] => /tmp/php40lMX5
[error] => 0
[size] => 571
)

)

<?php
$dir = $_SERVER['DOCUMENT_ROOT'].'/images/photos/';
$year = $_REQUEST['yr'].'/';
$cat = $_REQUEST['cat'].'/';
$evt = $_REQUEST['evt'].'/';

$updir = $dir.$year.$cat.$evt;
@mkdir($updir, 0755);

global $updir, $_FILES;
$uploadfile = $updir.basename($_FILES['userfile']['name']);

$size = $_FILES['userfile']['size']/1024;

echo '<pre>';
if(move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile)){
	echo 'Your file has been successfully uploaded.<br>'."\n".
		'File Size: '.$size.'<br>'."\n".
		'File Location: '.$updir.'<br>'."\n".
		'Direct Link: '.$uploadfile;
}
else {
	echo '<h3>There was an error!</h3><br>'."\n".
		'File Size: '.$size.' MB<br>'."\n".
		'File Location: '.$updir.'<br>'."\n".
		'Direct Link: '.$uploadfile.'<br>'.
		'Error #: '.$_FILES['userfile']['error'].'<br>'.
		'Temp: '.$_FILES['userfile']['tmp_dir'].'<br><br>';
}

echo '<b>Debugging Info:</b><br>';
print_r($_FILES);

echo '</pre>';
?>

Any help would be appreciated.

~Brett

Installer

Are you sure the directory is being created? What happens if you remove the "@" from "mkdir()"?

btw, this line:

global $updir, $_FILES;

does nothing. "global" is effective only in function scope and besides that "$_FILES" is already a superglobal.

bpat1434

If I remove the @ from the mkdir(), then I don't get any errors, just like I don't get any errors when the @ is present.

~Brett

cbj4074

I'm having the same problem. PHP 5.x on Win32 with Apache 2.0. The error code returned in $_FILES is 0, yet the files never make it to the tmp directory.

Any progress on this, bpat1434?

Here's my code; it's directly from the PHP manual, in order to eliminate other possiblities. No real indication of any problems, the file simply doesn't show up in the temp directory (which, on Windows32, is C:\WINDOWS\Temp by default).

<html>
<head>
<title></title>
</head>
<body>
<pre>
<?php print_r($_FILES); ?>
</pre>
<form enctype="multipart/form-data" action="<?php echo $_SERVER['PHP_SELF'] ?>" method="POST">
   <!-- MAX_FILE_SIZE must precede the file input field -->
   <input type="hidden" name="MAX_FILE_SIZE" value="30000" />
   <!-- Name of input element determines name in $_FILES array -->
   Send this file: <input name="userfile" type="file" />
   <input type="submit" value="Send File" />
</form>
</body>
</html>

samudasu

No such file exists is refering to /home/bpat1434/public_html/images/photos/2004/test/Pics/test.html.bak. In my experience with this issue it's mkdir that usually causes the problem. Where i usually see the problem is when i'm trying to create a directory several levels deep (2004/test/Pics/). If you're using php5 you can try adding the recursive flag to mkdir('dir', 0755, 1). For php4 you might try writing a recursive function to create the dirs one at a time. Just my experiences.

samudasu

Just noticed the original post date on this thread. I guess this was resolved long ago.

cbj4074

Actually, I did post my question yesterday, even though this thread was started a long time ago, so your help is greatly appreciated.

Any idea why even the simple-ass code, straight from the PHP manual, wouldn't work for uploading files in my case? I'm using the simplest example possible. Error code is 0, file never shows up in C:\WINDOWS\Temp. Ugh!

Roger_Ramjet

Are you running Windows 95 or 98 then????

In 2K and XP, the default system dir is C:\WINNT, and the default temp dir for each user is C:\Documents and Settings\%username%\Local Settings\Temp

samudasu

Ok, i'm guessing that you're seeing something similar when you run print_r($_FILES). The reason you're not getting anything in your temp directory is because the temporary file in this case below (php61E3.TMP) is automatically deleted by php upon the end of the script. The problem probably lies with the move_uploaded_file function.
What does the rest of your code look like?

Array
(
    [userfile] => Array
        (
            [name] => 302redirect.doc
            [type] => application/msword
            [tmp_name] => C:\WINDOWS\TEMP\php61E3.TMP
            [error] => 0
            [size] => 31744
        )

)

cbj4074

Duuude! You're the man. That worked 🙂 When I added that function, everything turned to gold. I guess I somehow missed this from the manual:

"The file will be deleted from the temporary directory at the end of the request if it has not been moved away or renamed."

Thanks!!!

This works:

<html>
<head>
<title></title>
</head>
<body>
<pre>
<?php
print_r($_FILES);

if (!move_uploaded_file($_FILES['userfile']['tmp_name'], 'C:\a\\' . $_FILES['userfile']['name'])) {
	echo 'File move failed.';
}
else {
	echo 'File move succeeded.';
}
?>
</pre>
<form enctype="multipart/form-data" action="<?php echo $_SERVER['PHP_SELF'] ?>" method="POST">
   <!-- MAX_FILE_SIZE must precede the file input field -->
   <input type="hidden" name="MAX_FILE_SIZE" value="30000" />
   <!-- Name of input element determines name in $_FILES array -->
   Send this file: <input name="userfile" type="file" />
   <input type="submit" value="Send File" />
</form>
</body>
</html>

samudasu

glad i could help!

cbj4074

As a final point of note... is it redundant and unnecessary to use both is_uploaded_file() and move_uploaded_file(), or does move_uploaded_file() call is_uploaded_file() anyway?

Thanks!

bpat1434

Answering a question in my own thread..... I thought I'd never see the day.....

Anyway, it's not redundant. If you want to use error catching (like I do), the first step is to make sure it's uploaded. That way, if it's not uploaded (which returns FALSE) then you can write your own error. It's better than dealing with a PHP error from move_uploaded_file.

I personally do it because it takes away the chance of having my page throw oodles of errors while it tries to do file manipulation....

And yes, this was resolved LONG ago.... I just never marked it resolved because I forgot about it..... but I'm rectifying it today!! (as per my signature)

~Brett