copy() doesn't work for $_FILES

rolwong

Hi there, I have a problem and doesn't know why it comes:

In the first page, i have similar code likes this:
if ($HTTP_POST_FILES["upload_file"]["name"] != "") {
$temp_array = array("name"=>$FILES["upload_file"]["name"],"tmp_name"=>$FILES["upload_file"]["tmp_name"],"size"=>$FILES["upload_file"]["size"],"type"=>$FILES["upload_file"]["type"]);
$_SESSION['upload_array'][] = $temp_array;

    for ($i = 0 ; $i < count($_SESSION['upload_array']) ; $i++) {
      print $_SESSION['upload_array'][$i]["name"]."       <a href='javascript:removeAttachment(".$i.")'>[Remove]</a>"."<br>";
      copy($_SESSION["upload_array"][$i]["tmp_name"], $_SESSION["upload_array"][$i]["name"]);
    }
  }

The copy function is fine.

But users click the submit button and some data post to other page. I run this code:
copy($SESSION["upload_array"][$i]["tmp_name"], $SESSION["upload_array"][$i]["name"]);

It wouldn't work anymore. Why?

rajavel

u need to set the enctype of form attribute like this

<form enctype="multipart/form-data" action="_URL_" method="post">

rolwong

I have already done this. I have checked that whenever there is a POST to other page or even to the same page, the copy wouldn't work. But the session values are still there.

rajavel

try using...move_uploaded_file() like this

move_uploaded_file($_SESSION["upload_array"][$i]["tmp_name"], $_SESSION["upload_array"][$i]["name"])

if it doesn't work means.....plzzz paste the full code of both the pages........I will try to find the error.....

rolwong

Thanks for your help. here is the full code: mail_compose.php

<html>
<head>
<title>Compose Email</title>
<script language = "JavaScript">
function addAttachment() {
var frm = document.getElementById("form1")
frm.action="mail_compose.php"
frm.method="POST"
if (frm.upload_file.value != "") { //only handle the add attachment when the user has selected a file
frm.submit();
}

}
function removeAttachment(ID) {
var frm = document.getElementById("form1");
frm.deleteID.value = ID;
frm.action="mail_compose.php"
frm.method="POST"

frm.submit();
}

</script>

</head>
<body>
<?
session_start();
if (!isset($SESSION['last_submission_id'])) {
$SESSION['last_submission_id'] = 0;
}
?>

<form id="form1" name="uploadForm" action="mail_send.php" method="post" enctype="multipart/form-data">
<table border="1">
<?
print "<tr><td>To</td><td><input type='text' name='mailTo' value='".$mailTo."'></td></tr>";
print "<tr><td>Title</td><td><input type='text' name='mailTitle' value='".$mailTitle."'></td></tr>";
?>

<tr><td> </td><td><textarea rows="15" cols="60" name="mailContent"></textarea></td></tr>
</table>
<?
print "<input type='file' name='upload_file'> <input type='button' value='Add' onClick='addAttachment()'>";
print "<br>";

if ($_SESSION['last_submission_id'] != $_POST['submission_id']) {  // when the form is submitted.
  $_SESSION['last_submission_id'] = $_POST['submission_id'];

  if ($HTTP_POST_FILES["upload_file"]["name"] != "") {
  	$_SESSION['upload_array'][] = $HTTP_POST_FILES["upload_file"];

    for ($i = 0 ; $i < count($_SESSION['upload_array']) ; $i++) {
      print $_SESSION['upload_array'][$i]["name"]."       <a href='javascript:removeAttachment(".$i.")'>[Remove]</a>"."<br>";
      [B]copy($_SESSION["upload_array"][$i]["tmp_name"], $_SESSION["upload_array"][$i]["name"]);  // this is ok[/B]
    }
  } else {  // when delete the array
  	  // this copy wouldn't work anymore. 
  	  [B]copy($_SESSION["upload_array"][$i]["tmp_name"], $_SESSION["upload_array"][$i]["name"]);  [/B]
  	  array_splice($_SESSION['upload_array'], $_POST['deleteID'], 1);
  	  for ($i = 0 ; $i < count($_SESSION['upload_array']) ; $i++) {
        print $_SESSION['upload_array'][$i]["name"]."       <a href='javascript:removeAttachment(".$i.")'>[Remove]</a>"."<br>";
      }
  }	    	
} else {
    session_unregister("upload_array");	
}	

$next_submission_id = md5(uniqid(""));
print "<input type='hidden' name='submission_id' value='".$next_submission_id."'>";
print "<input type='hidden' name='deleteID' value=''>";

?>

<input type="submit" value="Upload">
</form>

</body>
</html>

rolwong

mail_send.php, this page receive the POST value:
And i try to make this page simpler to debug

<?
session_start();

// doesn't work neither
for ($i = 0 ; $i < count($SESSION['upload_array']) ; $i++) {
copy($SESSION["upload_array"][$i]["tmp_name"], $_SESSION["upload_array"][$i]["name"]);
}
?>

rolwong

can anybody help?

rajavel

try using

 if ((isset($HTTP_POST_FILES["upload_file"]["name"] )) && ($HTTP_POST_FILES["upload_file"]["name"] != "")) {

instead of

 if ($HTTP_POST_FILES["upload_file"]["name"] != "") {

in multiple upload file...............