Undefined Offset with graphics generation script

monger

I've inherited some code that I'm working with. I've done more in Perl than php, so it's a bit tough ironing all this out.

I'm working to bring the php code up to speed with some newer software, and I keep running into broken code. Surprise! Here's my current quandry:

// First find the maximum value of $p,
// and count the rows.
$cnt="0";
$s = "0";
$fp=fopen($reportfile,'r');
while ( !feof($fp) ) {
        list($d,$p,$count)=split("\t",fgets($fp,1000));
        if ($p > $s) { $s = $p; } 
        $cnt += 1;
}
rewind($fp);

I've dug through the online docs for each of the functions involved, but I still can't figure out the error I have, below:

PHP Notice: Undefined offset: 2 in - on line 92
PHP Notice: Undefined offset: 1 in - on line 92
PHP Notice: Undefined offset: 2 in - on line 122
PHP Notice: Undefined offset: 1 in - on line 122
PNG
cHsI#0d»ìFÛvïÆÃÍFÕ
IHDRvµ$PLTEÿÿÿÿÿÿÿÿ}}}¾áÿôÞºëÒ¹ëëë77´«#=IDAT8 i¯[ü&¿ôpó¨ÞÑ´1ªr½ÄÆ¯1¦ÔÈî¼ÄYñýIEND®B

The garbage at the end is the graphic this script generates. I'm calling it a bit out of context for debugging (this error exists both ways).

Any ideas? Anyone...Anyone...Bueller?

Thanks,
monger

rehfeld

have you looked at line 92 and 122? what are they?

Weedpacket

Just a wee bit of code run from the command line to test an idea - and its result:

php -r "list($x,$y,$z) = array('one element');"

Notice: Undefined offset:  2 in Command line code on line 1

Notice: Undefined offset:  1 in Command line code on line 1

Could that have something to do with it?

(Also, why are you using [man]split[/man] instead of [man]explode[/man]?)

monger

To awnser a couple of questions, here goes.

Lines 122 & 92 are the following:

     list($d,$p,$count)=split("\t",fgets($fp,1000)); (92)

list($d,$p,$count)=split("\t",fgets($fp,1000)); (122)

As for the split v. explode, I inherited it. I'm still digging through the script to understand it more fully. For example, I understand the sequence of functions listed in the original post, but not in relation to the purpose of the script as a whole - graphics generation. So, I'll see if I can muster any gumption to look at changing the split.

And weedpacket, what is the offset here? That's the crux of my confusion now.

thanks,
monger