problem with foreach construct

ejwf

Hello
I have created an array from which I wish to run a query for each result in the array, but I cannot get it to work
so far I have got

$query = "SELECT CRef FROM tblUser WHERE CLogIn = '$username'"; //  variable set earlier in code
$result = mysql_query($query)
or die (mysql_error());
$row = mysql_fetch_array($result);
$CRef = $row['CRef'];

$query = "SELECT MRef FROM tblResults WHERE aRef = '0' AND bRef = '0' AND CRef = '$CRef'";
$result1 = mysql_query($query)
or die (mysql_error());
while ($row1 = mysql_fetch_array($result1)) 
    {  

        $MRef[] = $row1['MRef']; 
    }  

foreach($MRef as $value) 
  { 

$query = "SELECT (aRef) AS aRef, (bRef) AS bRef FROM `tblMachine` WHERE Id = '$MRef' "; 
$result2 = mysql_query($query) 
or die(mysql_error());

if ($result2)
{		
echo $MRef;
echo '<br>';
echo $aRef;
echo '<br>';
}

  }	// close foreach

I have run print_r($MRef); to see what is int he array and it outputs a list such as Array ( [0] => 49 [1] => 110 [2] => 46 [3] => 59 [4] => 60 [5] => 79 etc.etc. which is what I was expecting but when I continue to try to output the other information I get
Array

Array

Array

etc.etc.

any ideas where I am going wrong - thanks

Shrike

$query = "SELECT (aRef) AS aRef, (bRef) AS bRef FROM `tblMachine` WHERE Id = '$MRef' ";  

// Should this be
$query = "SELECT (aRef) AS aRef, (bRef) AS bRef FROM `tblMachine` WHERE Id = '$value' ";

ejwf

thank you
I have tried this but get the error message
Warning: Invalid argument supplied for foreach()
for the line
foreach($MRef as $value)

any ideas?
thanks

dewen

I guess it is because this code did not return any rows:

 
$query = "SELECT MRef FROM tblResults WHERE aRef = '0' AND bRef = '0' AND CRef = '$CRef'"; 
$result1 = mysql_query($query) 
or die (mysql_error()); 
while ($row1 = mysql_fetch_array($result1))  

    {   

        $MRef[] = $row1['MRef'];  

    }

or something wrong with the query

ejwf

I have tested this - if I run print_r($MRef) I get all the contents of the array shown as expected so the array is OK

Shrike

Are you sure you changed the correct line? It was the third database query.

dewen

usually the "Warning: Invalid argument supplied for foreach" is about the empty var or wrong var name. So you have to make sure no typo...

Weedpacket

Although I don't know anything about ejwf's setup, I wonder if that [IMPORTANT] Announcement at the top of the forum is relevant (faults with foreach are a part of the issue).