Mod Rewrite Question

[Sharif]

I am thinking of recoding some things on my site to work with mod-rewrite. My question is, you know that it works like this:

URL Without Mod rewrite:
www.site.com/page.php?var1=42&var2=45

URL with Mod rewrite:
www.site.com/page/var1/42/var2/45

My question is, will I have to change all the things that my script uses for URLs? Like in form actions sometimes I have,
$_SERVER['PHP_SELF'] . '?var=135'

Will that have to be changed to:
$_SERVER['PHP_SELF'] . '/var/135/' ?

[rehfeld]

of course

i would suggest wrting a function to do this.

that way in the future, if you change your rewriting style, you only need to change your function

like
echo rewrite_encode('?foo=bar&baz=blah'); // /foo/bar/baz/blah

or whatever format you decide upon

[Sharif]

So I can just do something like

function rewrite($url)
{
$rewrite = '/';
foreach($_GET as $key=>$value)
{
$rewrite.= $key . '/' . $value;
}

echo $rewrite;
}

Hows that look?

[_Demonoid_]

Close, but not quite. 🙂 What that script would do (not that I've tested it) is give you /key1/val1key2/val2key3/val3. What you want is this:

function rewrite($url)
{
foreach($_GET as $key=>$value)
{
$rewrite.= '/' . $key . '/' . $value;
}

echo $rewrite;
}

[Sharif]

Ok so say I wanted to link to news.php?id=435, I'd use the function like this?

rewrite(page/?id=435);

? Or do I have to put page.php?

[_Demonoid_]

Hold on... I just realised that the script I gave you wouldn't work. It uses the $_GET array, but really you want to be able to rewrite any URL (not just the one the page was called by). How about this...

function rewrite($url)
$ParsedURL = parse_url($url);
$Parts = parse_str($ParsedURL["query"]);
{
foreach($Parts as $key=>$value)
{
$rewrite.= '/' . $key . '/' . $value;
}

echo $rewrite;
}

...this script parses the URL (ie. seperates it into host, path, query, etc). Then it takes query (the bit after the ?) and splits it into key-value pairs, using parse_str().

And yes, you should be able to call:

rewrite("page/?id=435");

...but remember the quotation marks!

[Sharif]

Ok so lets ask some test stuff...

Say I wanted to link to page.php?var1=555&var2=abc

I'd do:

rewrite('page/?var1=555&var2=abc');

It would output:

page/var1/555/var2/abc ?

Is there a way to get it to be

page/555/abc ?

And would I check if the variable is set the same way? like

isset($_GET['var1']) ?

[_Demonoid_]

Well, if you did, you'd have to have the variables in a set order. Otherwise, the script wouldn't know which value goes with which variable. Is that what you want to do?

[_Demonoid_]

Hold on. Do your ModRewrite entries map something like:

page/foo/bar

...to...

page.php?var1=foo&var2=bar

...because if they do, it would be easy to do what you want. Like this:

function rewrite($url)
$ParsedURL = parse_url($url);
$Parts = parse_str($ParsedURL["query"]);
{
foreach($Parts as $value)
{
$rewrite.= '/' . $value;
}

echo $rewrite;
}

[MatrixGL]

gives me a

Warning: Invalid argument supplied for foreach() in /home/******/public_html/******/includes/functions.php on line 87

line 87

foreach($Parts as $key=>$value)

[_Demonoid_]

Ah, worked out the problem. This should (hopefully) work.

function rewrite($url)
$ParsedURL = parse_url($url);
parse_str($ParsedURL["query"],$Parts);
{
foreach($Parts as $value)
{
$rewrite.= '/' . $value;
}

echo $rewrite;
}

[Sharif]

Fixed your code a little (parse errors), then did this:

rewrite('page?id=25&act=03');

and it output '/25/25/03/'

it should out put /id/25/act/03' right?

[_Demonoid_]

I thought you didn't want it to display the variable names:

Ok so lets ask some test stuff...

Say I wanted to link to page.php?var1=555&var2=abc

I'd do:

rewrite('page/?var1=555&var2=abc');

It would output:

page/var1/555/var2/abc ?

Is there a way to get it to be

page/555/abc ?

And would I check if the variable is set the same way? like

isset($_GET['var1']) ?

[Sharif]

Typo!

To properly use mod_rewrite wouldn't I have to show var names?

[_Demonoid_]

Not necessarily. You could have all the variables in a set order. For example, var1 would always come first, then var2, etc. But it would be easier to set it up so it did show the variable names. It would be done like this...

function rewrite($url) {
 $ParsedURL = parse_url($url);
 $Parts = parse_str($ParsedURL["query"]);
 foreach($Parts as $key=>$value) {
  $rewrite.= '/' . $key . '/' . $value;
 }
 echo $rewrite;
}