[Resolved] Deleting files from a folder + also from mysql

kikki

Hi guys,
I need help in deleting files from folder, normal unlink doesn't help. I'm trying to delete rows from DB and in the same time those files from a folder(I can delete the filenames from DB, but not the files from the folder), could someone please guilde me to solve this problem?

Thanks!


//Deleting from DB
<?
if(isset($_POST['deletefiles_x']) || isset($_POST['deletefiles_y']))
{
//Strat to grab info...
	$upload_dir = "members/kikki/";
	$total = $_POST['total'];
	$td = 0;
	$i = 0;

//Delete each selected filenames from DB-------------------------------------->
		for($i = 1; $i <= $total; $i++)
		{
		if(isset($_POST["d$i"]))
		{
		mysql_query("DELETE FROM members_uploads WHERE id=".$_POST["d$i"]);
		$td++;
		}
		}
echo "$td record(s) deleted!";
//End deleting the filenames from the DB-------------------------------->

//Start Deleting the same files from the folder too :/


//End deleting

}
?>

devinemke

2 things:

you do not need the for loop. you can do the deletes all in a single query. code your form to return all the "to be deleted" id's in an array and then do:
```
$sql = "DELETE FROM members_uploads WHERE id IN(" . implode(',', $_POST['to_delete']) . ')';
```

what are the names of the files? are they the same of the id's from the table? if so:

foreach ($_POST['to_delete'] as $value)
{
	$unlink = unlink('./members/kikki/' . $value);
	if ($unlink) {echo 'delete OK<br>';} else {echo 'delete FAIL<br>';}
}

kikki

Hi Mike,
Thanks for the fast answer, Those files are not same as it's ids, they are containing different names, any ideas how to delete the files along with ids?

devinemke

Originally posted by kikki
Hi Mike,
Thanks for the fast answer, Those files are not same as it's ids, they are containing different names, any ideas how to delete the files along with ids?

what/where/how are the files named? if they are in the database then pull them out, youv'e already got the list if ID's.

ps. my name is not mike

kikki

Originally posted by devinemke
what/where/how are the files named? if they are in the database then pull them out, youv'e already got the list if ID's.

ps. my name is not mike

sorry.. I called u mike because there is reading: devinemke 'devinemke' != 'mike'... sorry again...

anyway, I've got ids, I've never pulled many filenames at once(should I use loop?) and donno how to use them to delete each files, even I pulled them out from DB using IDs.

Thats the main question of my topic, could u pls show me how?

Thanks!

devinemke

as i pointed out before, your form is already returning a list of id's to delete. use that list to grab the filenames, loop thru and delete.

$result = mysql_query('SELECT filename FROM members_uploads WHERE id IN(' . $_POST['to_delete'] . ')') or exit(mysql_error());
while ($row = mysql_fetch_assoc($result))
{
	$unlink = unlink('./members/kikki/' . $row['filename']); 
	if ($unlink) {echo 'delete OK<br>';} else {echo 'delete FAIL<br>';}
}

this must of course come first before you delete all of the records

kikki

Thanks for the reply, But I'm getting query error, it's deleting from DB, not from the folder.. 🙁


<?
if(isset($_POST['deletefiles_x']) || isset($_POST['deletefiles_y']))
{
//Strat to grab info...
	$total = $_POST['total'];
	$td = 0;
	$i = 0;

//Delete each selected filenames from DB-------------------------------------->
		for($i = 1; $i <= $total; $i++)
		{
		if(isset($_POST["d$i"]))
		{
		mysql_query("DELETE FROM members_uploads WHERE id=".$_POST["d$i"]);
		$td++;
		}
		}
echo "$td record(s) deleted!";
//End deleting the filenames from the DB-------------------------------->

//Start Deleting the same files from the folder too :/

$result = mysql_query("SELECT filename FROM members_uploads WHERE id IN(".$_POST["d$i"].")") or die(' Error, query failed');
while ($row = mysql_fetch_assoc($result))
{
    $unlink = unlink($upload_dir . $row['filename']); 
    if ($unlink) {echo 'delete OK<br>';} else {echo 'delete FAIL<br>';}
}

//End deleting

}
?>

devinemke

i think you need to re-read the bottom of my last post. you must pull the filenames first, before you delete the records, otherwise you will be attempting to pull records that are already gone.

i think you should also re-read my first post. it looks like you are still not returning the id's as an array.

kikki

sorry I didn't note that, everything worked just fine, Thankyou devinemke, I really appreciate your help 🙂