Writing to the dabse and echoing the result.

mdastous

With a little help from Rehfeld I was able to now get the IF in this statement to work.

<?php 
$imgname=$profile["imgname"]; 

if (!empty($imgname)) 
{ 
$pic="$siteaddress/files/"."$defaultpic"; 
$dimensions = resize($pic); 
echo "<img src=\"$pic\" width=\"$dimensions[0]\" height=\"$dimensions[1]\">"; 
} 
else 
{ 
$pic = "$siteaddress/files/".$profile["imgname"]; 
$dimensions = resize($pic); 
echo "<img src=\"$pic\" width=\"$dimensions[0]\" height=\"$dimensions[1]\">"; 
} 
?>

However, now the ELSE is having issues when it connects to the file that writes to the Dbase.

I get an error in this section I believe....

# If does not exist in the database, insert a new entry 
  if (!mysql_num_rows($page_count)) { 
    $sql = "INSERT INTO profile (userid, profiletext, imgname) VALUES('{$user["userid"]}', '$profiletext', NULL)"; 
    $result = mysql_query($sql,$db); 
  }

What am I doing wrong?

Marc

devinemke

you didn't post you actual query but i'm guessing is uses the COUNT() keyword. if so then there is no reason to use mysql_num_rows(). the return value will always be "1" (even if the count is 0). you need to check the value of the count itself, not the number of rows return in the result set.

Roger_Ramjet

You can simplify this by relying on mysql indexing. Simply run the insert unconditionally. If the primary key value already exists then the insert will fail. So you only insert when there is no existing record, which is exactly what you want

If you want to know which it was then test the query return.

It is a 'suck it and see' solution, or 'chuck it at the db and see if it sticks'; but none the less valid for all that. And it breaks no Relational Database Theory, or Practice principles. It is just sound practical database programming.

mdastous

Thank you for the reply!! As I have said, I am a Newbie, so be gentle 😉

The code for this page is below. What do I need to change to make this work right.

<?php
// +----------------------------------------------------------------------+
// | profile_update.php                                                   |
// | This file updates db with student profile.                           |
// +----------------------------------------------------------------------+
include("../inc/timer.php");
include_once("../config.php");
include_once("../inc/version.php");
include_once("./inc/functions.php");
checkLoggedIn("yes");
include("./inc/userinfo.php");
include("../inc/dtd.php");
?>
<title>Online Portfolios</title>

<!-- Start Stylesheet Block -->
<?php include("../inc/styles.php");?>
<!-- End Stylesheet Block -->

</head>

<body>
<div id="container">
<!-- Start Banner Block -->
<?php include("../inc/banner.php");?>
<!-- End Banner Block -->

<div id="sidebar-a">
<!-- Start Find Portfolio Block -->
<?php include("./inc/nav.php");?>
<!-- End Find Portfolio Block -->
</div>

<!-- Start Content Block -->
<div id="content">
<h3>Update your profile</h3>
  <?php

# if magic quotes not set, add slashes
if (!get_magic_quotes_gpc()) { 
$profiletext = addslashes($profiletext);  

}

$sql = "SELECT profiletext, userid FROM profile WHERE userid='{$user["userid"]}'";
$page_count = mysql_query($sql,$db);

  # If does not exist in the database, insert a new entry
  if (!mysql_num_rows($page_count)) {
    $sql = "INSERT INTO profile (userid, profiletext, imgname) VALUES('{$user["userid"]}', '$profiletext', NULL)";
    $result = mysql_query($sql,$db);
  }


// file upload fix from Pete Shima
if(!empty($file_name)){
  $img=explode(".",$file_name);
    $upldfile="{$user["userid"]}.$file_name";
	$fileext = substr($file_name, -3);
	if(($fileext != "gif") && ($fileext != "jpg")){
    echo "<p><b>$file_name</b> name is not a valid image.<br /><br />
    Please make sure your file is one of the following types: <br /> <br />
    * GIF Image<br />
    * JPG Image<br /><br />
    Please click the back button and change your file, thank you.</p>";
    die;
  }

// if file exists, delete it
if (file_exists("$filepath$upldfile")) 
	{unlink("$filepath$upldfile");}

// upload file and insert profile into database
    if(copy($file,"$filepath$file_name")){

  if(rename("$filepath$file_name","$filepath$upldfile")){
    $foo=false;
$query="UPDATE profile SET profiletext='$profiletext',imgname='$upldfile' WHERE userid='{$user["userid"]}'";
    $db=mysql_query($query,$db);
    echo "<b>Image upload and profile update complete</b><br>";
  } // rename

}
} else{}

?>
</div>
<!-- end content block -->

<!-- Start Footer Block -->
<?php include("../inc/footer.php");?>
<!-- End Footer Block -->
</div>
<!-- Start Klahowya Info Block -->
<?php include("../inc/powered.php");?>
<!-- End Klahowya Info Block -->

</body>
</html>
<!-- The End -->

Thank you in advance. I'm trying to teach myself new tricks, but it isn't working very well 😉

Marc

Roger_Ramjet

I'd do it this way.

<?php include("./inc/nav.php");?>
<!-- End Find Portfolio Block -->
</div>

<!-- Start Content Block -->
<div id="content">
<h3>Update your profile</h3>
  <?php

# if magic quotes not set, add slashes
if (!get_magic_quotes_gpc()) { 
$profiletext = addslashes($profiletext);  

}
	// always run the insert, if the user already exists then the insert will bounce off
	$sql = "INSERT INTO profile (userid, profiletext, imgname) VALUES('{$user["userid"]}', '$profiletext', NULL)";
    $result = mysql_query($sql,$db);
    // check whether the insert worked or bounced
    $t = mysql_affected_rows();
    if ($t == -1) {
    	// insert failed, user already in the db
    }
    else {
    	// new user added
    }

$sql = "SELECT profiletext, userid FROM profile WHERE userid='{$user["userid"]}'";
$page_count = mysql_query($sql,$db);

// file upload fix from Pete Shima
if(!empty($file_name)){
  $img=explode(".",$file_name);
    $upldfile="{$user["userid"]}.$file_name";
    $fileext = substr($file_name, -3);
    if(($fileext != "gif") && ($fileext != "jpg")){
    echo "<p><b>$file_name</b> name is not a valid image.<br /><br />
    Please make sure your file is one of the following types: <br /> <br />
    * GIF Image<br />
    * JPG Image<br /><br />
    Please click the back button and change your file, thank you.</p>";
    die;
  }

// if file exists, delete it
if (file_exists("$filepath$upldfile")) 
    {unlink("$filepath$upldfile");}

// upload file and insert profile into database
    if(copy($file,"$filepath$file_name")){

  if(rename("$filepath$file_name","$filepath$upldfile")){
    $foo=false;
$query="UPDATE profile SET profiletext='$profiletext',imgname='$upldfile' WHERE userid='{$user["userid"]}'";
    $db=mysql_query($query,$db);
    echo "<b>Image upload and profile update complete</b><br>";
  } // rename

}
} else{}

?>
</div>
<!-- end content block -->

<!-- Start Footer Block -->
<?php include("../inc/footer.php");?>
<!-- End Footer Block -->
</div>
<!-- Start Klahowya Info Block -->
<?php include("../inc/powered.php");?>
<!-- End Klahowya Info Block -->

</body>
</html>
<!-- The End -->

In a multi-user environment, it is easy for the contents to change between the query that test for an entry and the next query that adds one. Writing code to stop this happening is labourious and wastes server resources. Programmers can also forget to write the code the next time the write a script.
Database tables should be designed to protect themselves from duplicate entries. So the carefull design of indexes etc is essential to prevent them. They can then be relied upon to ensure that duplicate entries do not occur. And you can get on with writing code that does something usefull.