strange error with certain query...

Grofit

ok its quite a long query... but i cant see any problems with it...
but for some reason i keep getting this error...

$MySQLQuery =  	"INSERT INTO characters"
						." (Name, Description, Race, Class, Max_HP, HP, Str, Con, Dex, Int, Wis,"
						." Level, Next_Level, Upper, Lower, Weapon, Gold, World_Pos, Area_Pos)"
						." VALUES"
						." ('$Name', '$Desc', '$Race', '$Class', '$Max_HP', '$Max_HP', '$Str', '$Con', '$Dex', '$Int', '$Wis'," 
						." '$Level', '$Next_Level','$Equip_Top', '$Equip_Bottoms', '$Equip_Wep', '$Gold', '$World', '$Area')";

"You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'Int, Wis, Level, Next_Level, Upper, Lower, Weapon, Gold, World_"

i thought maybe i cant use all these on one insert statement but PHPMyAdmin lets it thru..so i dont know whats wrong... 🙁

devinemke

i find that sort of INSERT syntax very accident prone. try this:

$MySQLQuery = "INSERT INTO characters SET
Name = '$Name',
Description = '$Desc',
Race = '$Race',
Class = '$Class',
Max_HP = '$Max_HP',
HP = '$Max_HP',
Str = '$Str',
Con = '$Con',
Dex = '$Dex',
Int = '$Int',
Wis = '$Wis',
Level = '$Level',
Next_Level = '$Next_Level',
Upper = '$Equip_Top',
Lower = '$Equip_Bottoms',
Weapon = '$Equip_Wep',
Gold = '$Gold',
World_Pos = '$World',
Area_Pos = '$Area'";

be sure to addslashes() if PHP isn't already doing it for you. also try echoing the query before running it to make sure it looks right.

Grofit

yeah i do anyway...lol its just being stupid...lol
i didnt know you could do it that way...let me change it over now 🙂

Grofit

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'Int = '8', Wis = '15', Level = '1', Nex

same thing... tried add slashes.. same thing too.. 🙁

devinemke

what does the query look like when echoed out to the browser?

Grofit

does it matter that im not putting ALL the fields into the insert command... i mean im missing out a few fields which will fill themselves with default data...

like ID, Inv1-Inv15 and things... i thought it wouldnt care as long as i specify the fields and the values...

Actual Browser Output:

INSERT INTO characters SET Name = 'Killa', Description = 'Moonshine', Race = 'Human', Class = 'Warrior', Max_HP = '300', HP = '300', Str = '14', Con = '18', Dex = '12', Int = '8', Wis = '15', Level = '1', Next_Level = '262', Upper = '2', Lower = '31', Weapon = '118', Gold = '100', World_Pos = '1', Area_Pos = '1'

devinemke

Originally posted by Grofit
does it matter that im not putting ALL the fields into the insert command... i mean im missing out a few fields which will fill themselves with default data

no, that does not matter, fields not specified in the INSERT query will get default values.

Grofit

thats what i thought... i cant see anything wrong with the query, doing it thru PHPMyAdmin it works fine, but in here it kicks up that error...

xblue

INT is a reserved word that shouldn't be used as a column name

http://dev.mysql.com/doc/mysql/en/Reserved_words.html

(it probably does work via phpmyadmin because they use backticks to be on the safe side)