Howto: check all 5 required fields are set? [form]

Novum

I have created a form. I do have five fields which are all required. The names of the fields: name, address, city, organisation and email.

I already created a statement with something like:

if( emtpy($_POST['name']) || .... etc.)
{
$error="some value";
}

Later on I check whether or not $error is set yes/no.

The question is: When one of the fields is empty $error should be set. But using "||" or "&&" (in conjunction with the !) doesn't seem to work. I've used this code before with succes, but it seems I am doing something wrong.

Many thanks in advance for your help![

devinemke

foreach ($_POST as $key => $value)
{
	if ($value == '') {echo 'you forgot to fill out your ' . $key . '<br>';}
}

Roger_Ramjet

You do this sort of thing with a javascript function in the <head> of the page BEFORE you waste time posting it to the server. Search any javascript forum or resource and you will find hundreds of form validation scripts to choose from.

Novum

devinemke:

You are referring to an array I suppose?

Roger Ramjet:
OK. I will look for a good javascript.

Still all suggestions regarding PHP code are still welcome.

Many thanks till so far. Will test this on Monday.

devinemke

Originally posted by Novum
You are referring to an array I suppose?

yes, the $POST array specifically. if your form uses the GET method then use the $GET array.

Roger_Ramjet

I posted an example in this thread . It's real easy.

Benefits:
1. instant feedback to user.
2. reduces server load
3. input page is self-contained, don't have to add validation code to each php script every time you reuse the input form

ahundiak

I posted an example in this thread . It's real easy.

Benefits:
1. instant feedback to user.
2. reduces server load
3. input page is self-contained, don't have to add validation code to each php script every time you reuse the input form

Even if you validate with js then you should still check on the server. Otherwise your scripts will be more suspectible to attacks.

this should work:

if (empty($_POST['var1') && empty($_POST['var2']))
{
    $error = 'Input data error';
} 
else $error = 'None';

Roger_Ramjet

Even if you validate with js then you should still check on the server. Otherwise your scripts will be more suspectible to attacks.

Yes, ahundiak, that is a given. My point is that you first have to have something to validate. The javascript validation is simply to check for empty field. Content will be page and application specific and needs to be done on the target script. Protecting against sql injections is also something that needs to be done in the target script. That however is a general problem best dealt with through a general solution that you use in every script.

None of this negates the benefits I outline. Saying that because you have to validate content in the target script you should also validate for empty fields just shows that you have not understood the client-server environment, and have not therefor understood the benefits I outlined.