Problem Passing Variables PHP/MySQL

[MisterPerson]

Hello. I've recently set up PHP, MySQL, phpMyAdmin and Xitami up on my local machine. As a starter, I decided I that I would set up a guestbook, however, when I enter my information and click the "Sign" button, I get this error: Notice: Undefined variable: submit in c:\Inetpub\create_entry2.php on line 4 on the create_entry.php page. I have no idea what to do - the code looks fine to me, but I'll paste it anyway.

---

guestbook.php (page 1)

<?
include("dbconnect.php");

echo("

<h2>Hey, sign my guestbook!</h2>
<form method=post action=\"create_entry.php\">

<b>Name:</b>
<input type=text size=40 name=name>
<br>
<b>Location:</b>
<input type=text size=40 name=location>
<br>
<b>Email:</b>
<input type=text size=40 name=email>
<br>
<b>Your Site:</b>
<input type=text size=40 name=url>
<br>
<b>Comments:</b>
<textarea name=comments cols=40 rows=4 wrap=virtual></textarea>
<br>

<input type=submit name=submit value=\"Sign\">
<input type=reset name=reset value=\"Clear\">
</form>

")
?>

---

create_entry.php (page 2)

<?
include("dbconnect.php");

if ($submit == "Sign"){
$query = "insert into guestbook
(name,location,email,url,comments) values
('$name', '$location,' '$email', '$url', '$comments')";

mysql_query($query) or
die (mysql_error());

echo("
<h2>Thanks!</h2>
<h2><a href=\"view.php\">View my guestbook!</a></h2>
");
}
else{include("guestbook.php");}
?>

The dbconnect.php page simply connects to the database.

Please help me out.

[phpscripters]

what is the status of your "register_globals" ?

register_globals must be set to "on" to do something like this, if not you will have to do $HTTP_POST_VARS["submit"]; and that for everything you want to pass

[devinemke]

your script assumes that register_globals is turned ON in your php.ini and it sounds like it is off. you should do some basic reading on Using Register Globals.

[phpscripters]

i am wondering why this had to be said twice... didnt i make it pretty clear?

[devinemke]

Originally posted by phpscripters
i am wondering why this had to be said twice... didnt i make it pretty clear?

it did not have to said twice but was, as it often happens, because we composed our posts concurrently. if it's really bothering you i will delete my post.

[phpscripters]

no no no, i was just wondering... i thought you may have been one of those d00ds that just read the main issue and respond, disregarding any help that was already given... and if concurrent means 4 minutes ok...

but hey, you're fine, was just wondering about it.

[MisterPerson]

Thanks for the super quick replies, but even with register_globals turned on the the php.ini file, the same error occurs. Though
'phpscripters' mentioned the "$HTTP_POST_VARS["submit"];" change, where exactly do I put this? Sorry to sound like a complete newbie, but I've hardly used PHP before. Thanks.

[cezve]

turn register globals OFF, use variables;

$name -> $_POST[name]
...

[MisterPerson]

I tried what you suggested, cezve, but I still get the same error! Unless I misinterpreted what you were talking about, I'll post the changed version of the create_entry.php page

---

<?
include("dbconnect.php");

if ($submit == "Sign")
{
$query = "insert into guestbook
('$POST[name]', '$POST[location]', '$POST[email]', '$POST[url]', '$_POST[comments]')"
;
mysql_query($query) or
die (mysql_error());
?>
<h2>Thanks!</h2>
<a href=view.php>View guestbook</a><br>
<?
}
else
{
include("guestbook2.php");
}

?>

Please help me out, thanks.

[gotissues68]

Hi-
You need to change

if ($submit == "Sign"){

to

if ($_POST[submit] == "Sign"){

Hope that helps!!! 🙂