UPDATE deleting records!

weazy

my update code when run from PHP has the effect of deleting records. when i strip the php out and run it from phpmyadmin sql window the appropriate records are updated.... what gives?

php:

$update = "UPDATE SillyHistory SET candy = '$candy', batchnumber = '$batch', date = '$date', amount = '$amount', checknumber='$check', thru = '$thru', event='$event', contrib_id = 'contrib_id' WHERE dollhist_id = '$dollhist_id'";

echo $update;

$result = mysql_query($update) or die(mysql_error());

if ($result == 'ok') {
header('location: '.$referer.'');
} else {
header('location: '.$referer.'');
}

tsinka

Hi,

please post the complete script as attachment.

Thomas

Roger_Ramjet

And yet another person who wants to use MySQL Reserved Words as column names. Look it's just setting yourself up doing this. Yes I know that the manual says

MySQL allows some keywords to be used as unquoted identifiers because many people have already used them. Examples are those in the following list:

.. DATE ...

But it makes your code non-standard SQL = unportable. It will also trip you up somewhere in a query where you least expect it.

Besides, what Date is this? Date_in, Date_updated, Birthday ??

There is NO situation where using a reserved word is the only option, and none where it is the best option. At some point down the track, in a year or two, you are going to re-read your code and see the reserved word as it's MySQL data type, function, or operator not the label. And what if someone else has to maintain it??

Make your names as meaningfull as possible. Make your code as explicit as possible, and don't set up bugs for the future.

leatherback

Hi,

In line with colum-names:
I usually include the first latter of the table in which it is contained. So instead of id in the table persons, I'd use P_Id.
The added benefit is, that when you are linking tables, you still have unique columnames.

Roger_Ramjet

I've never heard of an UPDATE doing a delete?? What error message does it throw out?

weazy

no error message at all; i also changed the 'date' field to contrib_date --> but the problem persists ... any ideas?

tsinka

Do you have PHP code in the same script that executes a DELETE query ?

If yes, then it might be executed accidently.

How does the complete script look like ?

One first step could be to add a
exit;

line just after the header function calls to make sure that the script really ends after them.

Additionally, if you use sessions (and depending on the session settings) it might be neccessary to add
session_write_close();
just in front of the header function calls.

Thomas

weazy

there is no delete code in this php script -- i have not gotten around to writing it yet. the only other code that there is in this script is just definition of variables

ex.
$dollhist_id = $HTTP_GET_VARS['dollhist_id'];

tsinka

Is there a typo in your first post ?

contrib_id = 'contrib_id'
instead of
contrib_id = '$contrib_id'

Just to make sure:

If you execute
SELECT COUNT(*) FROM SillyHistory
with phpMyAdmin, execute the script and then execute the count query again ... does it show a different count ?

Thomas

weazy

you are right, there was a typo and that was the problem. thanks.