O.O.P. Basic Probs...

[bpat1434]

Hey guys & gals.

I'm following a tut on the front page (Creating a CMS System - Peter Z.).

I have gotten to the part where he discusses testing to see how your dbConnector class is working. Well, I have the followign scripts and I get the ever infamous:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource

SystemComponent.php

<?php
class SystemComponent{
	var $cfg;
	function getSettings(){
		$cfg['siteDir'] = $_SERVER['DOCUMENT_ROOT'].'/install_folder/';
		$cfg['dbHost'] = 'localhost';
		$cfg['dbUser'] = 'dbuser';
		$cfg['dbPass'] = '*******';
		$cfg['dbName'] = 'tablename';
		return $cfg;
	}
}
?>

dbConnector.php

<?php
require_once 'systemcomponent.php';
class DbConnector extends SystemComponent{
	var $theQuery;
	var $link;
	function DbConnector(){
		$cfg = SystemComponent::getSettings();
		$dbhost = $cfg['dbHost'];
		$dbuser = $cfg['dbUser'];
		$dbpass = $cfg['dbPass'];
		$dbname = $cfg['dbName'];
		$this->link = mysql_connect($dbhost, $dbuser, $dbpass);
		mysql_select_db($dbname);	register_shutdown_function(array(&$this, 'close'));
	}
	function query($query){
		$this->theQuery = $query;
		return mysql_query($query, $this->link);
	}
	function fetchArray($result){
		return mysql_fetch_array($result);
	}
	function close(){
		mysql_close($this->link);
	}
}
?>

Testit.php

<?php
require_once('includes/dbconnector.php');
$connector = new DbConnector();
$result = $connector->query("SELECT * FROM `categories` ORDER BY `id`");
$row = $connector->fetchArray($result);
echo $row['id'].'.) '.$row['cateogry'].' :: '.$row['description'];
?>

Yes there is information in the database (2 rows). It's not returning anyting. When I echo different variables holding the query, only the var $query displays anything.

Can anyone see what is going on here? I have no clue as to what is goign wrong. I have tried editing area, and it just won't work.

Anyhelp is appreciated.

~Brett

[Shrike]

Sorry to state the obvious, but have you looked at mysql_error() ?

[bpat1434]

It's ok. You were right to do so as I had not stated what I had done.

I did NOT do that; however, after adding it, I get the error: 1065 Query was Empty.

So now I'm doing some basic debugging....

Thanks for pointing out my n00bish mistake.

~Brett

EDIT
After debugging it a little....
I got the connection problems sorted out. Now, with the "or die(mysql_error())" code still there, I don't get an error but the following error comes up:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource

So I'm lost.... I'll continue to work on it, but I'm really stuck as to what it could be.

[Kudose]

What about pulling the entire table at once instead of each row? I pulled this from my class and it might save you a lot of time down the line.

function dbFetch($sql){
		$this->items = array();
		$this->result = mysql_query($sql, $this->connection);
		$item = array();
		while($item = mysql_fetch_array($this->result)){
			$this->items[] = $item;
		}
		if(!mysql_error()){
			return $this->items;
		} else {
			return mysql_error();
		}
	}

[Kudose]

Also, in regards to your problem:

Shouldn't you be quering the database before you try to fetch information?

i.e.:

$sql = "SELECT * FROM table";
$query = mysql_query($sql);
$fetch = mysql_fetch_array($query);

Hope that helps.

[bpat1434]

I believe I am querying the information prior to fetching to an array. I would like to stay as close to the tut as possible, but I'm lost.

If I run the query as stated:

<?php
$connector = new DbConnector();
$result = $connector->query("SELECT * FROM `table_name` ORDER BY `id`");
$row = $connector->fetchArray($result);
echo // the information
?>

Wouldn't that run in successive order the query, then fetch them to an array?

If I echo the value of $result, then I get:

1

Not sure what is going on.

As for having it retrieve the entire table, I can do that in regular PHP. I'm not concerned with it. But this error I'm sure would still pop up. I will cod that in later, but now I need to get rid of this error so that I can see the information I have in the database.

Thanks for the help.

~Brett

[ahundiak]

And are you also checking for mysql_error after doing the query?

[bpat1434]

Yes. Both queries have an or die() statement. But still I get no errors other than the mysql_fetch_array nto being a valid resource.

Any other ideas?

~Brett