mail problem urgent!!

merav

i'm new to php and i have this submition form for the contact page and it's not seem to work or give me an error message.

this is the submition form:

<?php

$vars = array('First Name', 'Last Name', 'Home Phone', 'Fax', 'Mobile Phone', 'Email');
$texts = array('First Name', 'Last Name', 'Home Phone', 'Fax', 'Mobile Phone', 'Email');

$magic_quotes = get_magic_quotes_gpc();

$message = "<div dir=\"ltr\">\n";
for ($i=0; $i<count($vars); $i++) {
if ($magic_quotes) {
$POST[$vars[$i]] = stripslashes($POST[$vars[$i]]);
}
$message .= "<b>".htmlspecialchars($texts[$i]).":</b> ".htmlspecialchars($_POST[$vars[$i]])."<br />\n";
}
$message .= "</div>\n";

$to = 'J.B.H. <info@bh-j.com>';
$from = $POST['name'].' <'.$POST['email'].'>';
$subject = 'Contact Form from the Web-Site';

$headers = "Content-Type: text/html; charset=windows-1255\n";
$headers .= "From: {$from}\n";

mail($to, $subject, $message, $headers);

header('Location: contact.php');
die();

please help me...

rehfeld

and the error is????????

merav

the error is that the emails aren't getting to their destination...

rehfeld

oh i misread you post, i thought you said it DID give you an error.

put this at the top of the script and see if you get any errors from php

ini_set('display_errors', 1);
error_reporting(E_ALL);

kurtjensen

try replace

mail($to, $subject, $message, $headers);

header('Location: contact.php');

die();

with this

$MailYes = mail($to, $subject, $message, $headers);

if($MailYes)

{
echo "The message was sent.";
header('Location: contact.php');
die();

else
{
echo "I am sorry but there was an error. Some or all notices were not sent. <br/>";
echo "Email to ".$to." from: ".$from." failed";
die();
};

kurtjensen

also

$to = 'J.B.H. <info@bh-j.com>';
$from = $POST['name'].' <'.$POST['email'].'>';
$subject = 'Contact Form from the Web-Site';

$headers = "Content-Type: text/html; charset=windows-1255\n";
$headers .= "From: {$from}\n";

======================================

I think should be

$to = 'J.B.H. <info@bh-j.com>';
$from = $name.' <'.$email.'>';
$subject = 'Contact Form from the Web-Site';

$headers = "Content-Type: text/html; charset=windows-1255\n";

$headers .= "From: ".$from."\r\n";

I don't think you need to use $_POST[]. Just use the forms <input> name with a $ in front of it. At least this works for all my form submissions.

rehfeld

Originally posted by kurtjensen

I don't think you need to use $_POST[]. Just use the forms <input> name with a $ in front of it. At least this works for all my form submissions.

you do need to use POST GET _COOKIE etc... unless register globals is turned on. its been turned off by default for over 2 years now. so its pretty bad practice to rely upon it being turned on, plus it can be a pretty big security hole.

if your host upgrades to a new version of php, or changes the config sttings, all your code will break. not good.

kurtjensen

Didn't know that about $_POST[].
Sorry about the bad advice. Glad you expirienced guys are here to keep us newbes on track. :-)

merav

Sorry guys, but it's still don't seem to work, nor give me an error script even though i addded the part of tha display errors...
don't know what to do any more....

kurtjensen

I know this may sound simple but have you added something like this:

echo "to: ".$to;
echo "<br/>subject: ".$subject;
echo "<br/>message: ".$message;
echo "<br/>headers: ".$headers;

to the bottom of your script to see if all your variables look like you expect?

Weedpacket

A couple more ideas:

1) Complete the HTML so that you have a complete HTML document (<html>, <body>, and the rest), not just a fragment.

2) Pursuant to the note at the bottom of the [man]mail[/man] page, try an address that says "info@bh-j.com" instead of "J.B.H. <info@bh-j.com>" and see if that makes a difference.

merav

The script still don't work...