pulling my hair out

include_me

Can anyone see a problem with this? I dont want any validation and i just want to add the contents of those variables into my table and it just says there is a problem right at the end of my HTML page not my PHP :S

<?php
if (isset($_POST['submit'])); { //if submit is clicked handle the form

$message = NULL; //create end message variable
$make = $_POST['make'];
$model = $_POST['model'];
$image = $_POST['image'];
$imagealt = $_POST['imagealt'];
$features = $_POST['features'];
$pricegbp = $_POST['pricegbp'];
$priceeur = $_POST['priceeur'];
$priceusd = $_POST['priceusd'];
$desc = $_POST['desc'];

if ($make && $model && $image && $imagealt && $features && $pricegbp && $priceeur && $priceusd && $desc) {

require('../conn.php');

$query ="INSERT INTO phones (make, model, image, imagealt, features, pricegbp, priceeur, priceusd, desc) VALUES ('$make', '$model', '$image', '$imagealt', '$features', '$pricegbp', '$priceeur', '$priceusd', '$desc')";
$result = @mysql_query ($query);
if ($result) {
	echo '<p>You have added a new phone</p>';
	} else {
		$message = '<p>The Phone could not be added at this time.</p><p>' . mysql_error() . '</p>';
	}
	}

	mysql_close();
?>

Can anyone help me please i have been trying to this since 2pm and im going nuts!

Chris

rehfeld

when you ask for help, you should post the actuall error message(s) php is giving you.

i know you at the very least getting a parse error

if (isset($_POST['submit'])); { //if submit is clicked handle the form

should be

if (isset($_POST['submit'])) { //if submit is clicked handle the form

include_me

Hi I tried what you said and i keep getting the follwoing error coming up when i try and load the page..

Parse error: parse error, unexpected $ in /home/carose/public_html/p2u/backadmin/add_phone.php on line 116

Line 116 in my code is the end of my HTML (further down the page)

<?php
if (isset($_POST['submit'])) { //if submit is clicked handle the form

$message = NULL; //create end message variable
$make=$_POST['make'];
$model=$_POST['model'];
$image=$_POST['image'];
$imagealt=$_POST['imagealt'];
$features=$_POST['features'];
$pricegbp=$_POST['pricegbp'];
$priceeur=$_POST['priceeur'];
$priceusd=$_POST['priceusd'];
$desc=$_POST['desc'];

if ($make && $model && $image && $imagealt && $features && $pricegbp && $priceeur && $priceusd && $desc) {

require('conn.php');

$query = "INSERT INTO phones (make, model, image, imagealt, features, pricegbp, priceeur, priceusd, desc) VALUES ('$make', '$model', '$image', '$imagealt', '$features', '$pricegbp', '$priceeur', '$priceusd', '$desc')";
$result = @mysql_query($query);
if ($result) {
	echo '<p>You have added a new phone</p>';
	} else {
		echo '<p>The Phone could not be added at this time.</p><p>' . mysql_error() . '</p>';
	}
}
	mysql_close();
?>

<body>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
<table width="90%" border="2" align="center" cellpadding="1" cellspacing="0" bordercolor="#ABC323" bgcolor="#208BAC">
<tr>
<td width="25%"><font color="#FFFFFF" size="3" face="Verdana, Arial, Helvetica, sans-serif"><strong>Add
New Phone</strong></font></td>
<td width="3%"></td>
<td width="72%"></td>
</tr>
<tr>
<td><div align="left"><font color="#FFFFFF" size="2" face="Verdana, Arial, Helvetica, sans-serif">Phone
Make</font></div></td>
<td></td>
<td><select name="make" id="make">
<option selected>Please Select</option>
<option>Nokia</option>
<option>Samsung</option>
<option>Motorola</option>
<option>Sony Ericsson</option>
<option>Siemens</option>
<option>I-Mate</option>
<option>Panasonic</option>
</select></td>
</tr>
<tr>
<td><div align="left"><font color="#FFFFFF" size="2" face="Verdana, Arial, Helvetica, sans-serif">Phone
Model</font></div></td>
<td></td>
<td><input name="model" type="text" maxlength="25"></td>
</tr>
<tr>
<td><div align="left"><font color="#FFFFFF" size="2" face="Verdana, Arial, Helvetica, sans-serif">Image
File Name</font></div></td>
<td></td>
<td><input name="image" type="text" maxlength="15"></td>
</tr>
<tr>
<td><div align="left"><font color="#FFFFFF" size="2" face="Verdana, Arial, Helvetica, sans-serif">Image
Alt Tag</font></div></td>
<td></td>
<td><input name="imagealt" type="text" maxlength="30"></td>
</tr>
<tr>
<td><div align="left"><font color="#FFFFFF" size="2" face="Verdana, Arial, Helvetica, sans-serif">Handset
Features</font></div></td>
<td></td>
<td><textarea name="features" cols="50" rows="10"></textarea></td>
</tr>
<tr>
<td><div align="left"><font color="#FFFFFF" size="2" face="Verdana, Arial, Helvetica, sans-serif">Price
(UK Pounds)</font></div></td>
<td></td>
<td><input name="pricegbp" type="text" maxlength="6"></td>
</tr>
<tr>
<td><div align="left"><font color="#FFFFFF" size="2" face="Verdana, Arial, Helvetica, sans-serif">Price
(Euros)</font></div></td>
<td></td>
<td><input name="priceeur" type="text" maxlength="6"></td>
</tr>
<tr>
<td><div align="left"><font color="#FFFFFF" size="2" face="Verdana, Arial, Helvetica, sans-serif">Price
(US Dollars)</font></div></td>
<td></td>
<td><input name="priceusd" type="text" maxlength="6"></td>
</tr>
<tr>
<td><div align="left"><font color="#FFFFFF" size="2" face="Verdana, Arial, Helvetica, sans-serif">Phone
Description</font></div></td>
<td></td>
<td><p>
<textarea name="desc" cols="50" rows="10"></textarea>
</p>
<p>
<input type="submit" name="submit" value="Add Phone">
</p></td>
</tr>
</table>
</form>
</body>
</html>

Can anyone help? Im really stuck on this one.

Thanks
Chris

laserlight

Let me guess: your page only has 115 lines?

I think you're missing a closing brace somewhere in your PHP code.

include_me

Ok i missed out a closing bracket, i think i was looking at code too long to notice i had missed one.

Now when i click the submit button it comes up with another error. As far as i can tell the code is fine and all variables are assigned values so there should not be a reason for it to go wrong..

the error i get is:

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'desc) VALUES ('Nokia', '2650', '2650.jpg', 'Nokia 2650', 'Nokia

Chris

xblue

this very often means that you are missing a closing } somewhere.

I'd strongly recommend to indent your code not just at random, but somewhat meaningful, this kind of errors is much easier to spot then.

your code, ran through a beautifier

<?php
if (isset($_POST['submit'])) {
    //if submit is clicked handle the form

$message = NULL;
//create end message variable
$make=$_POST['make'];
$model=$_POST['model'];
$image=$_POST['image'];
$imagealt=$_POST['imagealt'];
$features=$_POST['features'];
$pricegbp=$_POST['pricegbp'];
$priceeur=$_POST['priceeur'];
$priceusd=$_POST['priceusd'];
$desc=$_POST['desc'];

if ($make && $model && $image && $imagealt && $features && $pricegbp && $priceeur && $priceusd && $desc) {

    require('conn.php');

    $query = "INSERT INTO phones (make, model, image, imagealt, features, pricegbp, priceeur, priceusd, desc) VALUES ('$make', '$model', '$image', '$imagealt', '$features', '$pricegbp', '$priceeur', '$priceusd', '$desc')";
    $result = @mysql_query($query);
    if ($result) {
        echo '<p>You have added a new phone</p>';
    } else {
        echo '<p>The Phone could not be added at this time.</p><p>' . mysql_error() . '</p>';
    }
}
mysql_close();
?>

EDIT: too slow, too late.

The next error: avoid using 'desc' as column name, this is a reserved word in mysql.

include_me

Hello,

I fixed that problem with the missing closing } bracket. but if you look below i now get another message after i click the submit/add phone button...

is therea anything wrong for it to do this?

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'desc) VALUES ('Nokia', '2650', '2650.jpg', 'Nokia 2650', '2650

thanks

Chris

xblue

yes, I answered that one as I noticed you had replied in between. see above:

avoid using 'desc' as column name, this is a reserved word in mysql.