Store into MYSQL Beginner Question

[techgearfree]

I am trying to store the user's ip address in a mysql table.

The tables name is logins and the collumn I want the ip to go in it loginip. The column that has the users username is username and the time the user signs up goes in login.

Now, I had this code when I just added user name and time and it worked:

$logintime = "INSERT INTO logins SET 
                          username = '$username', 
                          login = Now()";

But, I tried to store the ip of the user and it messed up:

$theip = $_SERVER['REMOTE_ADDR'];
						$logintime = "INSERT INTO logins SET 
                          username = '$username', 
                          login = Now(),
						  loginip = $theip";

When I did that code, it doesn't even record the time.

Any ideas?

Thanks

[access9]

The query is probably failing. Try this:

$logintime = "INSERT INTO logins SET 
                          username = '$username',
                          login = Now(),
                          loginip = '$theip'";

You forgot to wrap $theip in single quotes. Next time a query isn't working, fetch the MySQL error and see why, i.e.:

mysql_query("INSERT INTO logins
             SET
               username = '$username',
               login = Now(),
               loginip = '$theip'") or die(mysql_error());

-a9

EDIT: The post by Catharsis is the way you should formulate your INSERT statements, not by SET (although it may work).

[Catharsis]

Just to let you know that if your login field is of type TIMESTAMP then you dont need to pass it a NOW command to update it 🙂

Im not sure if that mysql insert will work but I always do mine like this :

$logintime = "INSERT INTO logins 
(username, login, loginip)
VALUES
('$username',Now(), '$theip')";

You may want to try to be clever and use a join command to put in ,commas for you or something.

Definately use the "or die" bit though, really helpfull to know what mysql throws back at you.

[techgearfree]

THANKS ! WORKS