error SQL syntax line 4

[rks_underground]

Hey all, i am new here and just wanted to let you know that I use to be at htmlforums and I am interested in to learning php more and what not, and I thought of signing up here and did. So, you should be seeing more of me 🙂. haha

I have a php script, that lets a user add a CSS/HTML and then later i will add php to it, and then list it with page numbers, a search function, and alternating row coors, I am getting this error on list.php:

You have an error in your SQL syntax near '' at line 4

I have been working with this for awhile and cant get it.

list.php

<?php 
include "config/config.php"; // config file
$db = mysql_connect($dbhost, $dbuser, $dbpass);
mysql_select_db('random_code', $db);

if (!$db) {
  echo( '<p>Unable to connect to the ' .
        'database server at this time.</p>' );
  exit();  

}
if (!isset($_GET['limit']) and empty($_GET['limit'])){
    $limit = 10;
} else {
    $limit = $_GET['limit'];
}
if (!isset($_GET['page']) and empty($_GET['page'])){
$page = 0;
} else {
$page = $_GET['page'];
}
$numresults = mysql_query("SELECT * FROM random WHERE title LIKE '%". $query ."%'");
$numrows = mysql_num_rows($numresults); // Number of rows returned from above query. LINE 14
if ($numrows == 0){
echo("No results found matching your query - $query");
exit();}

$pages = intval($numrows/$limit);


if ($numrows%$limit) {
$pages++;}

$current = ($page/$limit) + 1;

if (($pages < 1) || ($pages == 0)) {
$total = 1;} // If $pages is less than one or equal to 0, total pages is 1.

else {
$total = $pages;
}

$first = $page + 1;

if (((($page + $limit) / $limit) >= $pages) && $pages != 1) {
$last = $page + $limit;
} //If not last results page, last result equals $page plus $limit.

else{
$last = $numrows;} // If last results page, last result equals total number of results.
?>
<table width="65%" border="0" align="center" class="results">
  <tr>
    <td width="66%" align="left"> Results found: <b><?php echo"$numrows"?></b><br>
      <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="get" name="code">
        Sort by Category:
        <select name="sort">
          <option value="category">Category</option>
          <option value="title">Title</option>
          <option value="ID">Id</option>
        </select>
        Sort by Precedence:
        <select name="sortdate">
          <option value="ASC">Ascending</option>
          <option value="DESC">Descending</option>
        </select>
        <input type="hidden" name="query" value="<?=$query?>">
        <input type="hidden" name="page" value="<?=$page?>">
        <input type="hidden" name="limit" value="<?=$limit?>">
        <!-- note above added hidden fields...you'll need to get these values to the submitted page either way -->
        <input name="go" type="submit" value="Sort">
      </form></td>
    <td width="34%" align="right">Page <b>
      <?=$current?>
      </b> of <b>
      <?=$total?>
      </b> <br>
      Results per-page: <a href="<?=$PHP_SELF?>?query=<?=$query?>&page=<?=$page?>&limit=5">5</a> | <a href="<?=$PHP_SELF?>?query=<?=$query?>&page=<?=$page?>&limit=10">10</a> | <a href="<?=$PHP_SELF?>?query=<?=$query?>&page=<?=$page?>&limit=20">20</a> | <a href="<?=$PHP_SELF?>?query=<?=$query?>&page=<?=$page?>&limit=50">50</a> </td>
  </tr>
  <tr>
    <td></td>
  </tr>
</table>
<?php
include "config/config.php"; // config file
include "search_code.php"; // file containing code for search 
// Request the text of all the code
  $result = @mysql_query('SELECT * FROM random');
  if (!$result) {
    die('<p>Error performing query: ' . mysql_error() .
        '</p>');
}
/* USED FOR SORTING */
$sortby = ($_GET['sort'] != '')? addslashes($_GET['sort']) : 'date';

$sortdate = ($_GET['sortdate'] != '') ? addslashes($_GET['sortdate']) : 'DESC';

$query = addslashes($_GET["query"]);
$page = addslashes($_GET["page"]);
$limit = addslashes($_GET["limit"]);

$results = mysql_query("SELECT * FROM random
WHERE title LIKE '%".$query."%'
ORDER BY ".$sortby." ".$sortdate."
LIMIT ".$page.",".$limit."") or die(mysql_error().'<br/>Query: '.$query);

/* END */

/* Start display of alternating row colors for code listings */
$numrowslimited = mysql_num_rows($results); // Number of rows returned from above query.
echo "<div id=\"table\"><table width=\"50%\" align=\"center\">\n";
echo "<tr><th>Code Display</th><th>Category</th><th>Options</th></tr>\n";
for($i = 0; $i < $numrowslimited; $i++) {
    // check for existing color, if it is the same we change it.
    $color = ($color =="#E9EBE6")?"#DFE3DC":"#E9EBE6";
    $row = mysql_fetch_array($result);            

    echo "<TR bgcolor=\"$color\">\n";    

	echo "<TD><b>Title:</b> ".$row['title']."<b><div align=\"right\">Date Added:</b> ".$row['date']."</div></TD>\n";
	echo "<TD>".$row['category']."</TD>\n";
	echo "<TD>[<a href='edit.php?id=$id'>Edit</a>]</TD>\n";
    echo "</TR><br>\n";
}
echo "</table></div>\n";
echo"<p align=\"center\">\n";
if ($page != 0) { // Don't show back link if current page is first page.
$back_page = $page - $limit;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$query&page=$back_page&limit=$limit\">Back</a>\n");}

for ($i=1; $i <= $pages; $i++) // loop through each page and give link to it.
{
$ppage = $limit*($i - 1);
if ($ppage == $page){
echo("<b>$i</b> \n");} // If current page don't give link, just text.
else{
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$query&page=$ppage&limit=$limit\">$i</a>\n");}
}

if (((($page+$limit) / $limit) >= $pages) && ($pages != 1)) { // If last page don't give next link.
$next_page = $page + $limit;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$query&page=$next_page&limit=$limit\">Next</a>\n");}
?>
</table>

That is the page where the rows and queries are priinted out.

search.php

<?
include "config/config.php"; // config file
$db = mysql_connect($dbhost, $dbuser, $dbpass);
mysql_select_db('random_code', $db);

$query = $_GET["query"]; //this should be protected..but lets make sure the script works first

if($query != '')
{

$search = mysql_query("SELECT ID, title FROM random WHERE title LIKE '%".$query."%'");

while($listing = mysql_fetch_array($search))
{
?>
<a href=".....?id=<?=$listing["ID"]?>"><?=$listing["title"]?></a><br/>
<?
}

/* Pagination Code */
/* Pagination Options */
}
else
{
?>
<form action="<?=$_SERVER["PHP_SELF"]?>" method="get">
Query containing text: <input type="text" name="query">
<!-- <select name="category">
/*< Select CATEGORIES,echo 'option tags' */ >
</select> -->
<input type="submit" name="submit" value="submit">
<?
}
?> 

This code works fine. And is used for searching the table for entries.

I cant seem to see why I am getting that error on list.php

Thanks in Advance, Ryan

[bodzan]

$numresults = mysql_query("SELECT * FROM random WHERE title LIKE '%". $query ."%'"); 

When you write and SQL query I think you can't do that. Just use this way:

$numresults = mysql_query("SELECT * FROM random WHERE title LIKE '%$query%'"); 

Fix it wherever you wrote this kind of SQL query and you shouldn't get the error anymore...

[rks_underground]

Thanks man, i replaced that line and I still get it.. could it be at this section:

$results = mysql_query("SELECT * FROM random
WHERE title LIKE '%".$query."%'
ORDER BY ".$sortby." ".$sortdate."
LIMIT ".$page.",".$limit."") or die(mysql_error().'<br/>Query: '.$query);

Thanks, Ryan

edit**

When I remove:

 or die(mysql_error().'<br/>Query: '.$query);

To make it this:

$results = mysql_query("SELECT * FROM random
WHERE title LIKE '%".$query."%'
ORDER BY ".$sortby." ".$sortdate."
LIMIT ".$page.",".$limit."");

I get this error message:

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in c:\web\www\rks\list.php on line 114
Warning: Division by zero in c:\web\www\rks\list.php on line 142

/* Start display of alternating row colors for code listings */
$numrowslimited = mysql_num_rows($results); // Number of rows returned from above query. LINE 114 || ERROR
echo "<div id=\"table\"><table width=\"50%\" align=\"center\">\n";
echo "<tr><th>Code Display</th><th>Category</th><th>Options</th></tr>\n";
for($i = 0; $i < $numrowslimited; $i++) {
    // check for existing color, if it is the same we change it.
    $color = ($color =="#E9EBE6")?"#DFE3DC":"#E9EBE6";
    $row = mysql_fetch_array($result);            

    echo "<TR bgcolor=\"$color\">\n";    

	echo "<TD><b>Title:</b> ".$row['title']."<b><div align=\"right\">Date Added:</b> ".$row['date']."</div></TD>\n";
	echo "<TD>".$row['category']."</TD>\n";
	echo "<TD>[<a href='edit.php?id=$id'>Edit</a>]</TD>\n";
    echo "</TR><br>\n";
}
echo "</table></div>\n";
echo"<p align=\"center\">\n";
if ($page != 0) { // Don't show back link if current page is first page.
$back_page = $page - $limit;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$query&page=$back_page&limit=$limit\">Back</a>\n");}

for ($i=1; $i <= $pages; $i++) // loop through each page and give link to it.
{
$ppage = $limit*($i - 1);
if ($ppage == $page){
echo("<b>$i</b> \n");} // If current page don't give link, just text.
else{
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$query&page=$ppage&limit=$limit\">$i</a>\n");}
}

if (((($page+$limit) / $limit) >= $pages) && ($pages != 1)) { // If last page don't give next link.
$next_page = $page + $limit;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$query&page=$next_page&limit=$limit\">Next</a>\n");}
?>
</table>

code with line 114, in it.

Thanks, Ryan

[bodzan]

$results = mysql_query("SELECT * FROM random
WHERE title LIKE '%$query%'
ORDER BY $sortby $sortdate
LIMIT $page,$limit");

Because the error that you're getting is that the $result variable doesn't contain any SQL result at all... So the error is not in line where it says it is but where you define SQL query i.e. the line above...

Hope it helps...

[rks_underground]

Hey man... thanks for the suggestion

So you are saying its the line above, and the line above that is:

$numresults = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext%'"); // got rid of this line and it still erroros

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Database listings of random HTML and CSS</title>
<link href="style_list.css" rel="stylesheet" type="text/css">
</head>
<body>
<?php 
include "config/config.php"; // config file
$db = mysql_connect($dbhost, $dbuser, $dbpass);
mysql_select_db('random_code', $db);

if (!$db) {
  echo( '<p>Unable to connect to the ' .
        'database server at this time.</p>' );
  exit();  

}
if (!isset($_GET['limit']) and empty($_GET['limit'])){
    $limit = 10;
} else {
    $limit = $_GET['limit'];
}
if (!isset($_GET['page']) and empty($_GET['page'])){
$page = 0;
} else {
$page = $_GET['page'];
}
$numresults = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext%'");
$numrows = mysql_num_rows($numresults); // Number of rows returned from above query. LINE 14
if ($numrows == 0){
echo("No results found matching your query - $searchtext");
exit();}

$pages = intval($numrows/$limit);


if ($numrows%$limit) {
$pages++;}

$current = ($page/$limit) + 1;

if (($pages < 1) || ($pages == 0)) {
$total = 1;} // If $pages is less than one or equal to 0, total pages is 1.

else {
$total = $pages;
}

$first = $page + 1;

if (((($page + $limit) / $limit) >= $pages) && $pages != 1) {
$last = $page + $limit;
} //If not last results page, last result equals $page plus $limit.

else{
$last = $numrows;} // If last results page, last result equals total number of results.
?>
<?php
include "config/config.php"; // config file
$db = mysql_connect($dbhost, $dbuser, $dbpass);
mysql_select_db('random_code', $db);

if (!$db) {
  echo( '<p>Unable to connect to the ' .
        'database server at this time.</p>' );
  exit();  

}
/* variables for search query */
$numresults = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext%'");
$cq = mysql_query("SELECT count(*)as count FROM random WHERE title LIKE '%$searchtext%'");

$c_arr = mysql_fetch_array($cq);
$count = $c_arr["count"];

$page = (is_numeric($_GET["page"]) && $_GET["page"] > 0) ? $_GET["page"] : 0;

$limit = (is_numeric($_GET["limit"]) && $_GET["limit"] > 0) ? $_GET["limit"] : 20;

$offset = ($page*$limit);

$page_total = round($count/$limit);

$searchtext = $_GET["searchtext"];

/* search query...add: LIMIT $offset,$limit to the query */



$query = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext' LIMIT $offset,$limit");

$numrowslimited = mysql_num_rows($query);
echo ("$query= SELECT * FROM random WHERE title LIKE '%$searchtext' LIMIT $offset,$limit");
while($row = mysql_fetch_array($query))
{
// Number of rows returned from above query.
echo "<div id=\"table\"><table width=\"50%\" align=\"center\">\n";
echo "<tr><th>Code Display</th><th>Category</th><th>Options</th></tr>\n";{
    // check for existing color, if it is the same we change it.
    $color = ($color == "#E9EBE6")?"#DFE3DC":"#E9EBE6";    

    echo "<TR bgcolor=\"$color\">\n";    

    echo "<TD><b>Title:</b> ".$row['title']."<b><div align=\"right\">Date Added:</b> ".$row['date']."</div></TD>\n";
    echo "<TD>".$row['category']."</TD>\n";
    echo "<TD>[<a href='edit.php?id=$id'>Edit</a>]</TD>\n";
    echo "</TR><br>\n";
}
echo "</table></div>\n";
echo"<p align=\"center\">\n";
if ($page != 0) { // Don't show back link if current page is first page.
$back_page = $page - $limit;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$back_page&limit=$limit\">Back</a>\n");}
/* alternating row color code(if $bg = '....' $bg = '....' blah blah blah */
?>

<table width="65%" border="0" align="center" class="results">
  <tr>
    <td width="66%" align="left"> Results found: <b><?php echo"$numrows"?></b><br>
      <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="get" name="code">
        Sort by Category:
        <select name="sort">
          <option value="category">Category</option>
          <option value="title">Title</option>
          <option value="ID">Id</option>
        </select>
        Sort by Precedence:
        <select name="sortdate">
          <option value="ASC">Ascending</option>
          <option value="DESC">Descending</option>
        </select>
        <input type="hidden" name="query" value="<?=$searchtext?>">
        <input type="hidden" name="page" value="<?=$page?>">
        <input type="hidden" name="limit" value="<?=$limit?>">
        <!-- note above added hidden fields...you'll need to get these values to the submitted page either way -->
        <input name="go" type="submit" value="Sort">
      </form></td>
    <td width="34%" align="right">Page <b>
      <?=$current?>
      </b> of <b>
      <?=$total?>
      </b> <br>
      Results per-page: <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=5">5</a> | <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=10">10</a> | <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=20">20</a> | <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=50">50</a> </td>
  </tr>
  <tr>
    <td></td>
  </tr>
</table>
<?php
include "config/config.php"; // config file
// Request the text of all the code
  $result = @mysql_query('SELECT * FROM random');
  if (!$result) {
    die('<p>Error performing query: ' . mysql_error() .
        '</p>');
}
/* USED FOR SORTING */
$sortby = ($_GET['sort'] != '')? addslashes($_GET['sort']) : 'date';

$sortdate = ($_GET['sortdate'] != '') ? addslashes($_GET['sortdate']) : 'DESC';

$searchtext = addslashes($_GET["searchtext"]);
$page = addslashes($_GET["page"]);
$limit = addslashes($_GET["limit"]);
$numresults = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext%'"); // got rid of this line and it still erroros
$results = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext%' ORDER BY ".$sortby." ".$sortdate." LIMIT ".$page.",".$limit.""};

/* END */
/* Start display of alternating row colors for code listings */
$numrowslimited = mysql_num_rows($results); // Number of rows returned from above query. LINE 114 || ERROR
echo "<div id=\"table\"><table width=\"50%\" align=\"center\">\n";
echo "<tr><th>Code Display</th><th>Category</th><th>Options</th></tr>\n";
for($i = 0; $i < $numrowslimited; $i++) {
    // check for existing color, if it is the same we change it.
    $color = ($color =="#E9EBE6")?"#DFE3DC":"#E9EBE6";
    $row = mysql_fetch_array($result);            

    echo "<TR bgcolor=\"$color\">\n";    

	echo "<TD><b>Title:</b> ".$row['title']."<b><div align=\"right\">Date Added:</b> ".$row['date']."</div></TD>\n";
	echo "<TD align=\"center\">".$row['category']."</TD>\n";
	echo "<TD>[<a href='edit.php?id=$id'>Edit</a>]</TD>\n";
    echo "</TR><br>\n";
}
echo "</table></div>\n";
echo"<p align=\"center\">\n";
if ($page != 0) { // Don't show back link if current page is first page.
$back_page = $page - $limit;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$back_page&limit=$limit\">Back</a>\n");}

for ($i=1; $i <= $pages; $i++) // loop through each page and give link to it.
{
$ppage = $limit*($i - 1);
if ($ppage == $page){
echo("<b>$i</b> \n");} // If current page don't give link, just text.
else{
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$ppage&limit=$limit\">$i</a>\n");}
}

if (((($page+$limit) / $limit) >= $pages) && $pages != 1)
$next_page = $page+1;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$next_page&limit=$limit\">Next</a>\n");}

?>
</table>
<p>&nbsp;</p>
<p><td align="center"&nbsp;</p>
</body>
</html>

i am trying to see what I need numresults for and I will try getting rid of that whole query.

Thanks, Ryan

[Roger_Ramjet]

Not sure that I'm following this thread properly. Are you still getting error in list.php at line 4?

I can see that there is a comma missing between the column names in your ORDER BY clause. Would that be the problem? If that query does not return a valid resultset then the subsequent ref to the resultset is what generates the error on line 114.

[rks_underground]

Okay...I added that suggestion. thank you!

Here is the updated code:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Database listings of random HTML and CSS</title>
<link href="style_list.css" rel="stylesheet" type="text/css">
</head>
<body>
<?php 
include "config/config.php"; // config file
$db = mysql_connect($dbhost, $dbuser, $dbpass);
mysql_select_db('random_code', $db);

if (!$db) {
  echo( '<p>Unable to connect to the ' .
        'database server at this time.</p>' );
  exit();  

}
if (!isset($_GET['limit']) and empty($_GET['limit'])){
    $limit = 10;
} else {
    $limit = $_GET['limit'];
}
if (!isset($_GET['page']) and empty($_GET['page'])){
$page = 0;
} else {
$page = $_GET['page'];
}
$numresults = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext%'");
$numrows = mysql_num_rows($numresults); // Number of rows returned from above query. LINE 14
if ($numrows == 0){
echo("No results found matching your query - $searchtext");
exit();}

$pages = intval($numrows/$limit);


if ($numrows%$limit) {
$pages++;}

$current = ($page/$limit) + 1;

if (($pages < 1) || ($pages == 0)) {
$total = 1;} // If $pages is less than one or equal to 0, total pages is 1.

else {
$total = $pages;
}

$first = $page + 1;

if (((($page + $limit) / $limit) >= $pages) && $pages != 1) {
$last = $page + $limit;
} //If not last results page, last result equals $page plus $limit.

else{
$last = $numrows;} // If last results page, last result equals total number of results.
?>
<?php
include "config/config.php"; // config file
$db = mysql_connect($dbhost, $dbuser, $dbpass);
mysql_select_db('random_code', $db);

if (!$db) {
  echo( '<p>Unable to connect to the ' .
        'database server at this time.</p>' );
  exit();  

}
/* variables for search query */
$numresults = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext%'");
$cq = mysql_query("SELECT count(*)as count FROM random WHERE title LIKE '%$searchtext%'");

$c_arr = mysql_fetch_array($cq);
$count = $c_arr["count"];

$page = (is_numeric($_GET["page"]) && $_GET["page"] > 0) ? $_GET["page"] : 0;

$limit = (is_numeric($_GET["limit"]) && $_GET["limit"] > 0) ? $_GET["limit"] : 20;

$offset = ($page*$limit);

$page_total = round($count/$limit);

$searchtext = $_GET["searchtext"];

/* search query...add: LIMIT $offset,$limit to the query */

/* CODE FOR THE RETURN OF THE SEARCH ELEMENT BELOW */

$query = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext' LIMIT $offset,$limit");

$numrowslimited = mysql_num_rows($query);
echo ("$query= SELECT * FROM random WHERE title LIKE '%$searchtext' LIMIT $offset,$limit");
while($row = mysql_fetch_array($query))
{
// Number of rows returned from above query.
echo "<div id=\"table\"><table width=\"50%\" align=\"center\">\n";
echo "<tr><th>Code Display</th><th>Category</th><th>Options</th></tr>\n";{
    // check for existing color, if it is the same we change it.
    $color = ($color == "#E9EBE6")?"#DFE3DC":"#E9EBE6";    

    echo "<TR bgcolor=\"$color\">\n";    

    echo "<TD><b>Title:</b> ".$row['title']."<b><div align=\"right\">Date Added:</b> ".$row['date']."</div></TD>\n";
    echo "<TD>".$row['category']."</TD>\n";
    echo "<TD>[<a href='edit.php?id=$id'>Edit</a>]</TD>\n";
    echo "</TR><br>\n";
}
echo "</table></div>\n";
echo"<p align=\"center\">\n";
if ($page != 0) { // Don't show back link if current page is first page.
$back_page = $page - $limit;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$back_page&limit=$limit\">Back</a>\n");}
/* alternating row color code(if $bg = '....' $bg = '....' blah blah blah */
?>

<table width="65%" border="0" align="center" class="results">
  <tr>
    <td width="66%" align="left"> Results found: <b><?php echo"$numrows"?></b><br>
      <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="get" name="code">
        Sort by Category:
        <select name="sort">
          <option value="category">Category</option>
          <option value="title">Title</option>
          <option value="ID">Id</option>
        </select>
        Sort by Precedence:
        <select name="sortdate">
          <option value="ASC">Ascending</option>
          <option value="DESC">Descending</option>
        </select>
        <input type="hidden" name="query" value="<?=$searchtext?>">
        <input type="hidden" name="page" value="<?=$page?>">
        <input type="hidden" name="limit" value="<?=$limit?>">
        <!-- note above added hidden fields...you'll need to get these values to the submitted page either way -->
        <input name="go" type="submit" value="Sort">
      </form></td>
    <td width="34%" align="right">Page <b>
      <?=$current?>
      </b> of <b>
      <?=$total?>
      </b> <br>
      Results per-page: <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=5">5</a> | <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=10">10</a> | <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=20">20</a> | <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=50">50</a> </td>
  </tr>
  <tr>
    <td></td>
  </tr>
</table>
<?php /* END */ ?>
<?php

/* CODE FOR THE LISTINGS OFF ALL THE DATA IN THE TABLE RANDOM FOR CODE OUTPUT IN A TABLE */

include "config/config.php"; // config file
// Request the text of all the code
  $result = @mysql_query('SELECT * FROM random');
  if (!$result) {
    die('<p>Error performing query: ' . mysql_error() .
        '</p>');
}
/* USED FOR SORTING */
$sortby = ($_GET['sort'] != '')? addslashes($_GET['sort']) : 'date';

$sortdate = ($_GET['sortdate'] != '') ? addslashes($_GET['sortdate']) : 'DESC';

$searchtext = addslashes($_GET["searchtext"]);
$page = addslashes($_GET["page"]);
$limit = addslashes($_GET["limit"]);
$numresults = mysql_query("SELECT * FROM random WHERE title"); // got rid of this line and it still erroros
$results = mysql_query("SELECT * FROM random WHERE title ORDER BY ".$sortby.",".$sortdate." LIMIT ".$page.",".$limit.""};

/* END */
/* Start display of alternating row colors for code listings */
$numrowslimited = mysql_num_rows($results); // Number of rows returned from above query. LINE 114 || ERROR
echo "<div id=\"table\"><table width=\"50%\" align=\"center\">\n";
echo "<tr><th>Code Display</th><th>Category</th><th>Options</th></tr>\n";
for($i = 0; $i < $numrowslimited; $i++) {
    // check for existing color, if it is the same we change it.
    $color = ($color =="#E9EBE6")?"#DFE3DC":"#E9EBE6";
    $row = mysql_fetch_array($result);            

    echo "<TR bgcolor=\"$color\">\n";    

	echo "<TD><b>Title:</b> ".$row['title']."<b><div align=\"right\">Date Added:</b> ".$row['date']."</div></TD>\n";
	echo "<TD align=\"center\">".$row['category']."</TD>\n";
	echo "<TD>[<a href='edit.php?id=$id'>Edit</a>]</TD>\n";
    echo "</TR><br>\n";
}
echo "</table></div>\n";
echo"<p align=\"center\">\n";
if ($page != 0) { // Don't show back link if current page is first page.
$back_page = $page - $limit;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$back_page&limit=$limit\">Back</a>\n");}

for ($i=1; $i <= $pages; $i++) // loop through each page and give link to it.
{
$ppage = $limit*($i - 1);
if ($ppage == $page){
echo("<b>$i</b> \n");} // If current page don't give link, just text.
else{
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$ppage&limit=$limit\">$i</a>\n");}
}

if (((($page+$limit) / $limit) >= $pages) && $pages != 1)
$next_page = $page+1;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$next_page&limit=$limit\">Next</a>\n");}

?>
</table>
<p>&nbsp;</p>
<p><td align="center"&nbsp;</p>
</body>
</html>

i get an error now on:

Parse error: parse error in c:\web\www\rks\list.php on line 164

Line 164:

$results = mysql_query("SELECT * FROM random WHERE title ORDER BY ".$sortby.",".$sortdate." LIMIT ".$page.",".$limit.""};

Thanks for your help, Ryan

[Roger_Ramjet]

$results = mysql_query("SELECT * FROM random WHERE title ORDER BY ".$sortby.",".$sortdate." LIMIT ".$page.",".$limit.""};

WHERE title = WHAT??

AND you have a problem at the end of the query string - ""} will chuck an error everytime.

[rks_underground]

Oh, haha. i just got rid of that cause its not needed for the all the data output. And I still get the error.

Thanks, Ryan

[Roger_Ramjet]

Well, in my editor this is line 164

$searchtext = addslashes($_GET["searchtext"]);

I never use the double quotes myself, so I don't know if they generate an error. But you use this form above line 164 so I'm sure they do.

$searchtext = addslashes($_GET['searchtext']);

and you use doubles further down as well. Change line 164 to single quotes and if you get an error on 165 then that's your answer.

[rks_underground]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Database listings of random HTML and CSS</title>
<link href="style_list.css" rel="stylesheet" type="text/css">
</head>
<body>
<?php 
include "config/config.php"; // config file
$db = mysql_connect($dbhost, $dbuser, $dbpass);
mysql_select_db('random_code', $db);

if (!$db) {
  echo( '<p>Unable to connect to the ' .
        'database server at this time.</p>' );
  exit();  

}
if (!isset($_GET['limit']) and empty($_GET['limit'])){
    $limit = 10;
} else {
    $limit = $_GET['limit'];
}
if (!isset($_GET['page']) and empty($_GET['page'])){
$page = 0;
} else {
$page = $_GET['page'];
}
$numresults = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext%'");
$numrows = mysql_num_rows($numresults); // Number of rows returned from above query. LINE 14
if ($numrows == 0){
echo("No results found matching your query - $searchtext");
exit();}

$pages = intval($numrows/$limit);


if ($numrows%$limit) {
$pages++;}

$current = ($page/$limit) + 1;

if (($pages < 1) || ($pages == 0)) {
$total = 1;} // If $pages is less than one or equal to 0, total pages is 1.

else {
$total = $pages;
}

$first = $page + 1;

if (((($page + $limit) / $limit) >= $pages) && $pages != 1) {
$last = $page + $limit;
} //If not last results page, last result equals $page plus $limit.

else{
$last = $numrows;} // If last results page, last result equals total number of results.
?>
<?php
include "config/config.php"; // config file
$db = mysql_connect($dbhost, $dbuser, $dbpass);
mysql_select_db('random_code', $db);

if (!$db) {
  echo( '<p>Unable to connect to the ' .
        'database server at this time.</p>' );
  exit();  

}
/* variables for search query */
$numresults = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext%'");
$cq = mysql_query("SELECT count(*)as count FROM random WHERE title LIKE '%$searchtext%'");

$c_arr = mysql_fetch_array($cq);
$count = $c_arr['count'];

$page = (is_numeric($_GET["page"]) && $_GET["page"] > 0) ? $_GET["page"] : 0;

$limit = (is_numeric($_GET["limit"]) && $_GET["limit"] > 0) ? $_GET["limit"] : 20;

$offset = ($page*$limit);

$page_total = round($count/$limit);

$searchtext = $_GET['searchtext'];

/* search query...add: LIMIT $offset,$limit to the query */

/* CODE FOR THE RETURN OF THE SEARCH ELEMENT BELOW */

$query = mysql_query("SELECT * FROM random WHERE title LIKE '%$searchtext' LIMIT $offset,$limit");

$numrowslimited = mysql_num_rows($query);
echo ("$query= SELECT * FROM random WHERE title LIKE '%$searchtext' LIMIT $offset,$limit");
while($row = mysql_fetch_array($query))
{
// Number of rows returned from above query.
echo "<div id=\"table\"><table width=\"50%\" align=\"center\">\n";
echo "<tr><th>Code Display</th><th>Category</th><th>Options</th></tr>\n";{
    // check for existing color, if it is the same we change it.
    $color = ($color == "#E9EBE6")?"#DFE3DC":"#E9EBE6";    

    echo "<TR bgcolor=\"$color\">\n";    

    echo "<TD><b>Title:</b> ".$row['title']."<b><div align=\"right\">Date Added:</b> ".$row['date']."</div></TD>\n";
    echo "<TD>".$row['category']."</TD>\n";
    echo "<TD>[<a href='edit.php?id=$id'>Edit</a>]</TD>\n";
    echo "</TR><br>\n";
}
echo "</table></div>\n";
echo"<p align=\"center\">\n";
if ($page != 0) { // Don't show back link if current page is first page.
$back_page = $page - $limit;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$back_page&limit=$limit\">Back</a>\n");}
/* alternating row color code(if $bg = '....' $bg = '....' blah blah blah */
?>

<table width="65%" border="0" align="center" class="results">
  <tr>
    <td width="66%" align="left"> Results found: <b><?php echo"$numrows"?></b><br>
      <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="get" name="code">
        Sort by Category:
        <select name="sort">
          <option value="category">Category</option>
          <option value="title">Title</option>
          <option value="ID">Id</option>
        </select>
        Sort by Precedence:
        <select name="sortdate">
          <option value="ASC">Ascending</option>
          <option value="DESC">Descending</option>
        </select>
        <input type="hidden" name="query" value="<?=$searchtext?>">
        <input type="hidden" name="page" value="<?=$page?>">
        <input type="hidden" name="limit" value="<?=$limit?>">
        <!-- note above added hidden fields...you'll need to get these values to the submitted page either way -->
        <input name="go" type="submit" value="Sort">
      </form></td>
    <td width="34%" align="right">Page <b>
      <?=$current?>
      </b> of <b>
      <?=$total?>
      </b> <br>
      Results per-page: <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=5">5</a> | <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=10">10</a> | <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=20">20</a> | <a href="<?=$PHP_SELF?>?query=<?=$searchtext?>&page=<?=$page?>&limit=50">50</a> </td>
  </tr>
  <tr>
    <td></td>
  </tr>
</table>
<?php /* END */ ?>
<?php

/* CODE FOR THE LISTINGS OFF ALL THE DATA IN THE TABLE RANDOM FOR CODE OUTPUT IN A TABLE */

include "config/config.php"; // config file
// Request the text of all the code
  $result = @mysql_query('SELECT * FROM random');
  if (!$result) {
    die('<p>Error performing query: ' . mysql_error() .
        '</p>');
}
/* USED FOR SORTING */
$sortby = ($_GET['sort'] != '')? addslashes($_GET['sort']) : 'date';

$sortdate = ($_GET['sortdate'] != '') ? addslashes($_GET['sortdate']) : 'DESC';

$searchtext = addslashes($_GET['searchtext']);
$page = addslashes($_GET['page']);
$limit = addslashes($_GET['limit']);
$numresults = mysql_query("SELECT * FROM random WHERE title"); // got rid of this line and it still erroros
$results = mysql_query("SELECT * FROM random ORDER BY ".$sortby.",".$sortdate." LIMIT ".$page.",".$limit.""};

/* END */
/* Start display of alternating row colors for code listings */
$numrowslimited = mysql_num_rows($results); // Number of rows returned from above query. LINE 114 || ERROR
echo "<div id=\"table\"><table width=\"50%\" align=\"center\">\n";
echo "<tr><th>Code Display</th><th>Category</th><th>Options</th></tr>\n";
for($i = 0; $i < $numrowslimited; $i++) {
    // check for existing color, if it is the same we change it.
    $color = ($color =="#E9EBE6")?"#DFE3DC":"#E9EBE6";
    $row = mysql_fetch_array($result);            

    echo "<TR bgcolor=\"$color\">\n";    

	echo "<TD><b>Title:</b> ".$row['title']."<b><div align=\"right\">Date Added:</b> ".$row['date']."</div></TD>\n";
	echo "<TD align=\"center\">".$row['category']."</TD>\n";
	echo "<TD>[<a href='edit.php?id=$id'>Edit</a>]</TD>\n";
    echo "</TR><br>\n";
}
echo "</table></div>\n";
echo"<p align=\"center\">\n";
if ($page != 0) { // Don't show back link if current page is first page.
$back_page = $page - $limit;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$back_page&limit=$limit\">Back</a>\n");}

for ($i=1; $i <= $pages; $i++) // loop through each page and give link to it.
{
$ppage = $limit*($i - 1);
if ($ppage == $page){
echo("<b>$i</b> \n");} // If current page don't give link, just text.
else{
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$ppage&limit=$limit\">$i</a>\n");}
}

if (((($page+$limit) / $limit) >= $pages) && $pages != 1)
$next_page = $page+1;
echo("<a href=\"{$_SERVER['SCRIPT_NAME']}?query=$searchtext&page=$next_page&limit=$limit\">Next</a>\n");}

?>
</table>
</body>
</html>

This is my new updated code with the suggestion that you said changing the " to ' and now the error is on 168

$results = mysql_query("SELECT * FROM random ORDER BY ".$sortby.",".$sortdate." LIMIT ".$page.",".$limit.""};

Thanks, Ryan

[Azala]

$results = mysql_query("SELECT * FROM random ORDER BY ".$sortby.",".$sortdate." LIMIT ".$page.",".$limit);

[Roger_Ramjet]

So now we know: using $var["var"] throws an error.

The answer to line 168 is the typo at the end of the string: too may quotes and the wrong bracket.

[rks_underground]

Okay... thanks guys! i did that and now I see the table, and get this

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in c:\web\www\rks\list.php on line 172

Here is line 172, its the top one.

$numrowslimited = mysql_num_rows($results); // Number of rows returned from above query. LINE 114 || ERROR
echo "<div id=\"table\"><table width=\"50%\" align=\"center\">\n";
echo "<tr><th>Code Display</th><th>Category</th><th>Options</th></tr>\n";
for($i = 0; $i < $numrowslimited; $i++) {
    // check for existing color, if it is the same we change it.
    $color = ($color =="#E9EBE6")?"#DFE3DC":"#E9EBE6";
    $row = mysql_fetch_array($result);            

    echo "<TR bgcolor=\"$color\">\n";    

	echo "<TD><b>Title:</b> ".$row['title']."<b><div align=\"right\">Date Added:</b> ".$row['date']."</div></TD>\n";
	echo "<TD align=\"center\">".$row['category']."</TD>\n";
	echo "<TD>[<a href='edit.php?id=$id'>Edit</a>]</TD>\n";
    echo "</TR><br>\n";
}
echo "</table></div>\n";
echo"<p align=\"center\">\n";

Thanks, Ryan