Small problem with search function

[weewizard]

Hi GUYS

Two small problems
1. my css are not working
2. It should be searching both 'product_name' & 'product_type_description' form the 'products' table. Unfortunatley it is only searching 'product_name'.

Can anyone guide me in the right direction?

Many Thanks
richard Howells

<?<a href="http://websearch01.mcclient.com/search.php?s=php+search+function&rnd=c513cf" onmouseover="window.status='http://www.phpbuilder.com/info.php?php'; return true;" onMouseOut="window.status='Done'; return true;">Php</a> 
include('includes/misc.inc'); 



$sname = 1;  

$result = mysql_query ("SELECT * FROM products WHERE ". ($sname ?  'product_name' : 'product_type_description')." LIKE '%$search%' ") 
or die('ERROR :'.sql_error()); // just to check it's OK 
$OK = "</table><BR>Sorry, no records were found!"; 

echo "<table cellpadding='0' cellspacing='2' border='0' width='524'>"; 
while ($row = mysql_fetch_array($result)) { 
  $OK = "</table"; 
  echo "<tr><td class='productsdisplayedimageborder'><img src='images/thumbnail_images/{$row['product_thumbnail_image']}'></td>"; 
  echo "<td class='productsdisplayedbackground' valign='top'> <a href='viewitem.php?product_item=".urlencode($row['product_id'])."'>". 
  htmlentities($row['product_name'])."</a> <br> <span class='productsdisplayeddescription'>". 
  htmlentities($row['product_description'])." </span> </td>"; 
  echo "<td class='productsdisplayedprice' width='62'>". 
  htmlentities($row['product_price']). "</td>"; 
} 
echo $OK; 
?> 

[TheDefender]

1) I don't see how/where you are linking to a style sheet. Is this the code in it's entirety? Is it in the misc.inc file?
2) Personally, I would get out of the habit of using the ternary operator in your code altogether, but especially in the middle of your SQL query... It's been a while since I looked at the ternary syntax, and you'll find a lot of people just don't use it. Rewrite your SQL statement without the ternary and I'll take a look a bit harder.

[Roger_Ramjet]

Hey, Defender, did you see the comments?. He did not use the terniary operator, whomever wrote this code for him did. :rolleyes:

Richard, if you try writing a query that searches the columns you want, I'll help you to debug it. Scrap what you were given and start again.

[TheDefender]

LOL Roger, I didn't see that the first time through. This code is so bunched up, that on the quick glance, I kinda skipped over the comments. (See at the end of my first post? Rewrite your SQL statement without the ternary and I'll take a look a bit harder.) I guess I didn't look that hard to begin with. LOL

In all fairness weewizard, if you are using code someone else wrote, then I recommend you first consult with them. (especially if they resort to ternarys) If they can't or won't help you, I suggest you be open for some radical changes in the code you have.

One other things I noticed is this:

if ($search == "")  

{$search = '%';}  

(This looks as though the author assumes register globals is on. If your php.ini has register globals off, then this code won't work for you anyhow. You may want to change it to something like this:

$search = $_POST['search']; //Change to GET if using GET instead of POST.
if ($search == "")  

{$search = '%';}

[weewizard]

Hi yes this code came from two places codewalkers.com and the help of a fellow forum member.

I have just noticed that the code is taken from 2001 so it is quite old ahhhhhhhhhhhhhhhhh.

As this isnt such a large piece of code I would like to start again.

But It must be possible to search both 'product_name' & 'product_type_description' form the 'products' table.

If there is any one with a suggestion fo how to get me started on this soultion please feel free to lend a hand to this newbie in need.

Many Thanks

Best
Regards
Richard Howells

[Roger_Ramjet]

SELECT * FROM table WHERE column1 LIKE '%$var%' OR column2 LIKE '%$var%'

[weewizard]

Greatest Thanks for that im to try that right away, many thanks,

If i wanted to be able to search other fields in the table do i just continue along the same lines?

Best Wishes

Richard Howells

[Roger_Ramjet]

logical operators . You can combine as many as you want, and use brackets to organise them into groups.

[weewizard]

Hi

Okay my search function is working okay apart from one thing, the message that is shown for no results is showing up on every type of search result.

I guess I should have it in some form of statement (if, else ) etc etc.

As a newbie this is above my level of capability.

Any help greatley appreciated

<?php 
include('includes/misc.inc'); 

//You should now this but be sure to connect to your database or this is useless. :/ 

if ($search == "")   

{$search = '%';}


$result = mysql_query ("SELECT * FROM products WHERE product_type_description LIKE '%$search%' OR
 product_name LIKE '%$search%' OR product_description LIKE '%$search%' ") 


or die('ERROR :'.sql_error()); // just to check it's OK 

//This is the section that should be displayed when no results are avaialble from search
$OK = "Sorry, no records were found!"; 
echo "<table align='center' width='370' class='nosearchresults'><tr>";
echo "<td rowspan='2' valign='top'>";
echo "<img src='images/error_warning.gif' width='64' height='58'>";
echo "</td><td width='355' height='' valign='top' class='nosearchheading'>";
echo $OK;
echo "<br></td><td>&nbsp;</td>"; 
echo "<tr><td class='nosearchresultscontent'>";
echo "Try using less keywords or searching for different keywords altogether.";
echo "</p><p>"; 
echo "Alternatively you could try the quick find menu to the top-right of the screen or browse by product categories..";
echo "</p></td><td>&nbsp;</td></tr></table>";

//This is the section that displays the search results

while ($row = mysql_fetch_array($result)) { 
  echo "<table cellpadding='0' cellspacing='2' border='0' width='524'>";
  echo "<tr><td class='productsdisplayedimageborder'><img src='images/thumbnail_images/{$row['product_thumbnail_image']}'></td>"; 
  echo "<td class='productsdisplayedbackground' valign='top'> <a href='viewitem.php?product_item=".urlencode($row['product_id'])."'>". 
  htmlentities($row['product_name'])."</a> <br> <span class='productsdisplayeddescription'>". 
  htmlentities($row['product_description'])." </span> </td>"; 
  echo "<td class='productsdisplayedprice' width='62'>". 
  htmlentities($row['product_price']). "</td></tr>"; 
  echo "</table>"; 
} 

?>

[TheDefender]

if(mysql_num_rows($result) == 0){
// Your code for no results goes here.
}else{
// Your code for showing results goes here.
}

[weewizard]

many thanks

great help for me........................it work !!

🙂

[TheDefender]

Glad to hear you got it all worked out. be sure to mark the thread resolved using the "Mark Thread Resolved" link at the bottom.

[weewizard]

Is there a way by which i can have the results seperated in to sections

so that on screen at the top of each type there will be the title for each, i.e memory, graphics cards, processors etc etc.

the database filed that stores these is called 'product_type_description'

from the table 'products'

any ideas?

please let me know what would be the most suitable way to tackle this.

<?php 
include('includes/misc.inc'); 

//You should now this but be sure to connect to your database or this is useless. :/ 

if ($search == "")   

{$search = '%';}


$result = mysql_query ("SELECT * FROM products WHERE product_type_description LIKE '%$search%' OR
 product_name LIKE '%$search%' OR product_description LIKE '%$search%' ") 


or die('ERROR :'.sql_error()); // just to check it's OK 

if(mysql_num_rows($result) == 0){ 
//This is the section that should be displayed when no results are avaialble from search

$OK = "Sorry, no records were found!"; 
echo "<table align='center' width='370' class='nosearchresults'><tr>";
echo "<td rowspan='2' valign='top'>";
echo "<img src='images/error_warning.gif' width='64' height='58'>";
echo "</td><td width='355' height='' valign='top' class='nosearchheading'>";
echo $OK;
echo "<br></td><td>&nbsp;</td>"; 
echo "<tr><td class='nosearchresultscontent'>";
echo "Try using less keywords or searching for different keywords altogether.";
echo "</p><p>"; 
echo "Alternatively you could try the quick find menu to the top-right of the screen or browse by product categories..";
echo "</p></td><td>&nbsp;</td></tr></table>";
}else{ 
//This is the section that displays the search results
echo "<span class='allresultsheadings'>Search Results:</span>";
while ($row = mysql_fetch_array($result)) { 
  echo "<table cellpadding='0' cellspacing='2' border='0' width='524'>";
  echo "<tr><td class='productsdisplayedimageborder'><img src='images/thumbnail_images/{$row['product_thumbnail_image']}'></td>"; 
  echo "<td class='productsdisplayedbackground' valign='top'> <a href='viewitem.php?product_item=".urlencode($row['product_id'])."'>". 
  htmlentities($row['product_name'])."</a> <br> <span class='productsdisplayeddescription'>". 
  htmlentities($row['product_description'])." </span> </td>"; 
  echo "<td class='productsdisplayedprice' width='62'>". 
  htmlentities($row['product_price']). "</td></tr>"; 
  echo "</table>";} 
}?>