[Resolved] SQL statements displayed on every page

snowplank

Every php page that queries my MySQL db outputs the SQL string on the result page. I just want to output the results. An example is below:

Output from my index.php

WHAT'S NEW:
SELECT ID,title FROM articles ORDER BY ID DESC LIMIT 0,5
Followed by the list of articles.

Desired output from index.php

WHAT'S NEW:
Followed by the list of articles.

Here is my code for index.php

WHAT'S NEW: 
<?php
// Require the database class
require_once('includes/DbConnector.php');

// Create an object (instance) of the DbConnector
$connector = new DbConnector();

// Execute the query to retrieve articles
$result = $connector->query('SELECT ID,title FROM cmsarticles ORDER BY ID DESC LIMIT 0,5');

// Get an array containing the results.
// Loop for each item in that array
while ($row = $connector->fetchArray($result)){

echo ' <a href="cmsadmin/viewArticle.php?id='.$row['ID'].'">';
echo $row['title'];
echo '</a> ';

}
?>

Can anyone help with this issue?

Roger_Ramjet

post the dbconnector.php script

snowplank

Thanks for looking at my post. Here's my DbConnector...

<?php

////////////////////////////////////////////////////////////////////////////////////////
// Class: DbConnector
// Purpose: Connect to a database
///////////////////////////////////////////////////////////////////////////////////////

require_once ('SystemComponent.php');

class DbConnector extends SystemComponent {

var $theQuery;
var $link;

//*** Function: DbConnector, Purpose: Connect to the database ***
function DbConnector(){

	// Load settings from parent class
	$settings = SystemComponent::getSettings();

	// Get the main settings from the array we just loaded
	$host = $settings['dbhost'];
	$db = $settings['dbname'];
	$user = $settings['dbusername'];
	$pass = $settings['dbpassword'];

	// Connect to the database
	$this->link = mysql_connect($host, $user, $pass);
	mysql_select_db($db);
	register_shutdown_function(array(&$this, 'close'));

}

// Function: query, Purpose: Execute a database query
function query($query) {

	$this->theQuery = $query;
	return mysql_query($query, $this->link);

}

// Function: fetchArray, Purpose: Generate array of all records returned in query results
function fetchArray($result) {

	return mysql_fetch_array($result);

}

// Function: close, Purpose: Close the database connection
function close() {

	mysql_close($this->link);

}

}
?>

snowplank

I'm sure this issue has an easy answer. Can anyone help me?

Roger_Ramjet

Sorry, snowplank. I can't for the life of me see where the query string is coming from. You will have to create some test pages that use diff parts of your code to isolate the problem further.

snowplank

Thanks for trying RogerRamjet.

Anyone else got any ideas?

tsinka

Hi,

there must be a line somwhere (I guess in the query function) that prints the query.

If the files are on a remote server then download all the files and check for any differences compared to the local files.

If that doesn't help then post all the relevant files as attachment (zip).

Thomas

Roger_Ramjet

Yep. Must be in your systemcomponents.php

That's the problem with class and object overkill. I mean, personally, I can't see anything in your dbconnector class that could not be done as efficiently, and more transparently, with simple procedural code. Sure, I have a db.php script that connects and returns the db, but no more. It just saves me form having to type or copy-paste the same code again and again.

PHP is an interpretted script. So there is no code 'reuse in memory' gain from having all queries run through a class object - it will not be memory resident from call to call.

snowplank

I have been using Peter Zeidman's CMS from Intranet Journal (http://www.intranetjournal.com/php-cms/). I haven't really made many changes unless I understood what I was doing. I am new to PHP and am still working out what the functions in his code do and how to utilise them.

I am at work today so will post the rest of my code tonight. Do you need the MySQL database schema too?

Have you ever heard of this issue before? Can you tell me what I am looking for?

Roger_Ramjet

Well, I've had a look right through the Peter Zeidman articles and code and for the life of me I can't see where it's coming from. Maybe someone else has an idea. Sorry!

RossC0

Its got to be outputted by somewhere!

Does SystemComponent.php have any debugging settings?

snowplank

Here are the files in a zipped folder.

RossC0

Hi,

Just looked at your dbconnector.php - look at lines: 34 - 41 specifically line 38! Its not the same code as you posted before!!

//*** Function: query, Purpose: Execute a database query ***
	function query($query) {
		$this->theQuery = $query;
		echo $query.'<br>';
		return mysql_query($query, $this->link);

}

It outputs the query! : echo $query.' ';

snowplank

RossCo,

Many thanks! I have no idea why that was there.

Thanks again.

Roger_Ramjet

RossCo, why do they do that? Post different code to the script that is giving them trouble!! 😕

Snowplank. If you want help then post the script that you are using ON YOUR SERVER, not some other version of it from your local drive. :glare: Common sense should have told you that. :rolleyes:

Now mark this thread as resolved with the link at the bottom of this page that says 'Mark as Resolved' to save wasting anyone elses time, thank you very much.

RossC0

lol RamJet - the funny thing is SnowPlank or some developer on the same project must have wanted to output the queries at some point to do debugging!! Then promptly forgot :rolleyes:

😃

snowplank

Once again RossCO many thanks. Sorry to have taken up your time on a silly error.

Roger Ramjet,

Your patience and magnanimity astound me. Offer to help the beginner whose made a mistake and then chastise them for wasting your time?

Roger_Ramjet

Well. Having wasted over an hour on this examining both your posted code and the original from your link, I do not feel particularly magnanimous.

Not seeing the echo for yourself is a newbie mistake and competely OK. Posting code which is not the script you are using and having problems with is downright stupid. If you feel stupid, good. It means you are less likely to try and debug the wrong code in the future.

peterz

I'm glad you've got it sorted. As the author of the tutorial in question (it was quite a while ago now!), the point of all the classes were to create a scalable system. It became the 'OtterCMS', http://www.ottercms.com , which has been an 'alpha' release for a while, but will hopefully be complete soon enough 🙂 .

Good luck with the PHP.

Pete.