pagination ??

habbardone

Hi,
I have looked at the class example - but could not understand how to apply it,
so I am adapting this code to my little application.

I like it because it isasy to follow and understand - but there are a couple of points
that I don't know about - and I hope that someone can put me right.

Here is the complete code:

First off , I guess that this is named view.php
Because it is called with an <a href from within ?

<?php
$limit = 20 // the number of rows per page
$query_count = "SELECT * FROM homes WHERE (topicid='$topicid') ORDER BY timestamp";

$result_count = mysql_query($query_count);

$totalrows = mysql_num_rows($result_count);

$PHP_SELF = $_SERVER['PHP_SELF']; // I DON'T UNDERSTAND THIS LINE ! WHY IS IT HERE
if(empty($page))

{

$page = 1;

}

$limitvalue = $page $limit - ($limit);

$query = "SELECT FROM posts,users WHERE (topicid='$topicid') AND username=name ORDER BY timestamp LIMIT $limitvalue, $limit";

$result = mysql_query($query) or die("Error: " . mysql_error());

if(mysql_num_rows($result) == 0)

{

echo("<center>Empty Post</center>");

}

while($row = mysql_fetch_array($result))

{

/////////////////
//posts here
/////////////////
if($page != 1)

{

$pageprev = $page - 1;

echo("Pages: ");

}

else

{

echo("Pages: ");

}

$numofpages = $totalrows / $limit;

for($i = 1; $i <= $numofpages; $i++)

{

if($i == $page)

{

echo("".$i." ");
}

else

{

echo("<a href='view.php?topicid=$topicid&page=$i'>$i</a> ");

// THIS BIT I ALSO DON'T KNOW ABOUT
// - MAYBE IT IS CALLING A DIFFERENT PROGRAM NOT THIS ONE? BECAUSE
// THERE IS NO $_GET AT THE BEGINNING OF THIS PROG ?
//
// WHAT IS THE &page DOING IN THIS BIT ?topicid=$topicid&page=$i

}

}

$last_page=ceil ($totalrows/$limit); // IS CEIL A BUILT-IN FUNCTION ?
if(($totalrows % $limit) != 0)

{

if($i == $page)

{

echo("" . $i . " ");

}

else

{

echo("<a href='view.php?topicID=$topicID&page=$i'>$i</a> ");

echo " ";
echo "<a href=view.php?topicid=$topicid&page=$last_page#last>Last Page</a>";
}

}

if(($totalrows - ($limit * $page)) > 0)

{

$pagenext = $page + 1;

echo("<a href='$PHP_SELF?topicid=$topicid&page=$pagenext'>>></a> ");

// I DON'T FOLLOW THIS BIT - WHAT DOES IT DO ?

}

else

{

echo("");

}

thanks very much for any advice and what would you do to improve it ?

David.

habbardone

Any help from you guys on this ?

Roger_Ramjet

// I DON'T FOLLOW THIS BIT - WHAT DOES IT DO ?

if(($totalrows - ($limit * $page)) > 0)
{
$pagenext = $page + 1;
echo("<a href='$PHP_SELF?topicid=$topicid&page=$pagenext'><font size=1>>></font></a> ");

// I DON'T FOLLOW THIS BIT - WHAT DOES IT DO ?

}
else
{
echo("");
}

It test to see if there are any more rows to display, ie Is This the Last Page?
If it is not, then output the next page link. If it is the last page then just output an empty string.

The empty string is redundant as it does absolutetly nothing in html.

RossC0

Interesting questions here habbardone.

RamJets right theres no need for the else statement it does bugger all!

I think this code will only work when registered globals is on:

/ THIS BIT I ALSO DON'T KNOW ABOUT
// - MAYBE IT IS CALLING A DIFFERENT PROGRAM NOT THIS ONE? BECAUSE
// THERE IS NO $_GET AT THE BEGINNING OF THIS PROG ?
//
// WHAT IS THE &page DOING IN THIS BIT ?topicid=$topicid&page=$i

Ok you get no $_GET syntax to check if it has been passed but you do have:

if(empty($page))
{
$page = 1;
}

Leading me to think that it requires registered global variables to be turned on - which aint great! It should contain some logic for catching url variables (and making sure the url variable is correct i.e. not outside the page range!).

Finally, the $PHP_SELF stuff is so that the paging in <a hrefs can be related to itself - although its not always used as it uses view.php as well in other parts! 😕

Roger_Ramjet

DO NOT TURN GLOBALS ON.

Search and replace all vars from $var to $_GET['var'] as appropriate.