[Resolved] Help

[tytanic11]

I'm building a simple form using php to take information the user has entered and send it in an email - here's the error I get when trying to submit it :
"Parse error: parse error, unexpected '\"' in /home/httpd/vhosts/free.ftwnet.com/httpdocs/mail.php on line 3"

and here's the code :
"<?

mail("[e-mail]", "$sub", "$comments" "$user" "$pass", "From: $name Reply-To: $mail");

echo "Your email is being processed, and you're being redirected to our main site. Expect a reply shortly. Thank you.";
echo "<meta http-equiv="refresh" content="2;URL=http://free.ftwnet.com">" ;
?>"

Any ideas on why it'd be giving that error ?
Thanks,
-Tyler

[rpanning]

You have to concatinate the message strings. Take a look at the manual on [man]mail/man

mail('[e-mail]', $sub, $comments . $user . $pass, "From: $name \r\nReply-To: $mail");

[tytanic11]

after changing that line, I get :

Parse error: parse error, unexpected T_STRING, expecting ',' or ';' in /home/httpd/vhosts/free.ftwnet.com/httpdocs/mail.php on line 6

what do I need to change there ?

[bodzan]

    mail('[e-mail]', $sub, "$comments  $user  $pass", "From: $name \r\nReply-To: $mail");

But then again I might be wrong... 🙂

Because the referred manual says:

bool mail ( string to, string subject, string message [, string additional_headers [, string additional_parameters]] )

So the message should be all one string of characters and this way you would get one...

[tytanic11]

I got that one sorted, it was an issue in line 6..but now I get this series of errors when going to submit it :
[QUOTE[
Notice: Undefined variable: sub in /home/httpd/vhosts/free.ftwnet.com/httpdocs/mail.php on line 3

Notice: Undefined variable: comments in /home/httpd/vhosts/free.ftwnet.com/httpdocs/mail.php on line 3

Notice: Undefined variable: user in /home/httpd/vhosts/free.ftwnet.com/httpdocs/mail.php on line 3

Notice: Undefined variable: pass in /home/httpd/vhosts/free.ftwnet.com/httpdocs/mail.php on line 3

Notice: Undefined variable: name in /home/httpd/vhosts/free.ftwnet.com/httpdocs/mail.php on line 3

Notice: Undefined variable: mail in /home/httpd/vhosts/free.ftwnet.com/httpdocs/mail.php on line 3
Your email is being processed, and you're being redirected to our main site. Expect a reply shortly. Thank you.
[/QUOTE]

Here's the updated code for the page :

 <?

mail('[e-mail]', $sub, $comments . $user . $pass, "From: $name \r\nReply-To: $mail");

echo "Your email is being processed, and you're being redirected to our main site. Expect a reply shortly. Thank you.";
echo "<meta http-equiv=\"refresh\" content=\"2;URL=http://free.ftwnet.com\">";
?> 

and here's the form :

<script language="javascript">
<!--

function check()
{

var error_string = "";
// check the text field
if (window.document.contact.name.value == "" || window.document.contact.name.value == "Name")
{
error_string += "You must enter your name.\n";
}
if (window.document.contact.mail.value == "" || window.document.contact.mail.value == "e-mail")
{
error_string += "You must enter your e-mail adderess.\n";
}
if (error_string == "")
{
return true;
}
else
{
alert(error_string); return false;
}

}

//-->
</script>
<style type="text/css">
<!--
.style2 {font-size: 10px}
-->
</style>
<form name="signup" method="post" action="mail.php"
onSubmit="var the_result = check(); return the_result">
<table width="408" border="0" cellpadding="0" cellspacing="0">
<tr>
<td width="50%"><p>Name:</p></td>
<td><input type="text" style="width:150;" name="name"></td>
</tr>
<tr>
<td>E-mail:<br>
<span class="style9">Must be a working, valid email address.</span></td>
<td><input type="text" style="width:150;" name="mail"></td>
</tr>
<tr>
<td>Website: <br>
<span class="style9">If you already have one, provide the address</span></td>
<td><input type="text"style="width:150;" name="site"></td>
</tr>
<tr>
<td>Desired Usernane : </td>
<td><input type="text" style="width:150;" name="user"></td>
</tr>
<tr>
<td height="27">Desired Password : </td>
<td><input type="text" style="width:150;" name="pass"></td>
</tr>
<tr>
<td>Any special requests </td>
<td><input type="text" style="width:150;" name="sub"></td>
</tr>
<tr>
<td colspan="2">Short description of what you're going to use our services for : <br>
<textarea style="width:303; height:150" name="comments"></textarea>
<br>
<input type="submit" name="submit" value="Submit"></td>
</tr>
</table>

[TheDefender]

Your register globals is off in the php.ini (which is a good thing)

You need to call your variables from the $_POST superglobal array.

//Add the following:
$sub = $_POST['sub'];
$comments = $_POST['comments'];
$user = $_POST['user'];
$pass = $_POST['pass'];
$name = $_POST['name'];

mail('[e-mail]', $sub, $comments . $user . $pass, "From: $name \r\nReply-To: $mail"); 

Do a search in the php manual for "predefined variables" and you will find a section that discusses the use of the superglobal arrays ($GET, $POST, $_SERVER, etc.) It also talks about register globals in there.

[tytanic11]

thanks guys, it's up and working now 🙂