Insert Statement

twb

Hi, If someone could help me it would be appreciated,
I have a form that has 4 textboxes anda function that takes the input from these and adds it to a mysql db. My problem is my INSERT statement dosen't seem to work:
The code is as follows

function Add_new_details($task_name,$task_description,$task_date,$task_time){ 
$query = "INSERT INTO calander (task_name, task_description, task_date, task_time) "; 
$query .= "VALUES ('$task_name', '$task_description','$task_date','$task_time') "; 
    echo $query;//this prints out a empty set for the VALUES 
    $result = mysql_query($query); 
    echo $result; //this prints out "1" 
    if(!$result){ 
        echo "Error in search for results:".mysql_error(); 
        //exit(); 
        } 
}

The function call is as follows:

Add_new_details($task_name,$task_description,$task_date,$task_time);

I can manually insert into the db, so I know it can be done
Thank you for your time
twb

Thora_Fan

Are all of the form elements named properly? Do all the text boxes have the "name" property set and do they match your variable names? This would be the first thing I would check.

Instead of passing the form variables to the function manually, I would use the predefined variables $GET or $POST. In my opinion, this leaves less room for errors. An example is as follows:

function Add_new_details()
{
	extract($_GET); // or $_POST, depending on which method you are using.

$Query = "INSERT INTO calander SET
      task_name='$task_name',
      task_description='$task_description',
      task_date='$task_date',
      task_time='$task_time'";

echo $Query;
$result = mysql_query($Query);

// whatever else you need to do goes here
}

When you call the function, you don't need to pass any parameters to it. The global variable $GET (or $POST, depending on which method you are using) will take care of it for you. Take a look at http://us2.php.net/variables.predefined for more information on predefined variables.