functions

kickme21

I am trying to make a Mysql command page so I can just call a it rather then to keep writing it on each page.

//connect to DB
function connect($link){
$link = mysql_connect("127.0.0.1","root","");
mysql_select_db("F1racers",$link);
if (!$link) {
die('Could not connect: ' . mysql_error());
}}

//fetching news messages
function news(){
$sql = "SELECT * FROM newsmessages";
$result = mysql_query($sql, $link) or die(mysql_error());
while ($newsfetch = mysql_fetch_array($result)) {
$news = $newsfetch['Text'];
$newstitle = $newsfetch['Title'];
$newsdate = $newsfetch['Date'];
}}

//fetching stats
function stats(){
$sql = "SELECT * FROM users WHERE username = '$user';";
$result = mysql_query($sql, $link) or die(mysql_error());
while ($stats = mysql_fetch_array($result)) {
$turns = $stats['turns'];
$money = $stats['money'];
$car = $stats['carpoints'];
$pitmen = $stats['pitmen'];
}}

The tubble is it won't connect to the database unless I paste the connect lines into the function but then when it does connect were the $user is the is stored in the session so then it won't read it outof the session. How do I fix these 2 problems.

RossC0

function news(){
$sql = "SELECT * FROM newsmessages";
$result = mysql_query($sql, $link) or die(mysql_error());
while ($newsfetch = mysql_fetch_array($result)) {
$news = $newsfetch['Text'];
$newstitle = $newsfetch['Title'];
$newsdate = $newsfetch['Date'];
}}

The problem is $link is not defined in this function - you either need to save it in the session or place it in function parameters ie: have a function news($link)

cahva

Betterway IMHO is just leave the $link out of the query. It will use the connection automatically. If you have multiple connections, then its better to define the $link..

$result = mysql_query($sql) or die(mysql_error());

kickme21

thanks very much that has sorted the problem with then function but how do I get the function to read session data

kickme21

to sort that I just put the session line in the fuction section but the trub is that I can not use any of the variables from the function. How to I get php to remember the verible to use them later on once I have run the function

RossC0

Set up your database conection as a class and then set the variables that you need to remember as class variables.

You may need to store the class in the session, if you require it after form posts etc..

kickme21

well what I am doing is runing the function and then the varible in that function I am calling stright after. I have called it on the same script as were I have run the function.

RossC0

Function created variables are throw away variables - So after the function is run they are dropped!

So unless they are assigned to something - ie a class or a session or you return something from your function they will be lost.

So to keep a single variable you can always return it. Something like this will do (I haven't tested the code though) but the concept is sound - you create an array of all the newstories and return that array when the function is called.

function news(){
$sql = "SELECT * FROM newsmessages";
$result = mysql_query($sql, $link) or die(mysql_error());

$newsData = Array();
while ($newsfetch = mysql_fetch_array($result)) {
$newsData[] = Array (
'news' => $newsfetch['Text'],
'newstitle' => $newsfetch['Title'],
'newsdate' => $newsfetch['Date'])
}

return $newsData;
}

// To call news and get the data do this:
$newsdata = news();

kickme21

Yerr it looks good but I get this

Parse error: syntax error, unexpected '}' in D:\F1racers\f1racers\mysqlcom.php on line 21

RossC0

I missed out a ; after the Array() - syntax!

kickme21

lol thanks shows that I am a n00b I noticed it now u pointed it out thanks :p

kickme21

right I have put $newsdata = newsmsg($link); but now how do I call be ie. 'news'

RossC0

sorry lost me there! What you trying to do now?

if you print_r($newsdata); do you get a nice array ?

kickme21

yes it has printed out the whole array but I am trying to put the information into a table. There are 3 fields

'news' => $newsfetch['Text'],
'newstitle' => $newsfetch['Title'],
'newsdate' => $newsfetch['Date']);

and I want to print each part in different sections in the table

ie. the Title I used to call $newstitle and that went at the top etc