Simple Phrase Error

jami3

Im not much of a newbie i have been learning php for over a year now and have produced many scripts however i cannot get my head around this. i know this is probley simple by im a bit rusty.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>Online Ftp</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<?php
$path = dirname($_SERVER['PATH_TRANSLATED']) . "/";

$dir_handle = @opendir($path) or die ("Failed To Open $dir Sorry For The Inconvienience");
echo "<ul>";
while ($file = readdir($dirhandle)) {
$path_parts = pathinfo("$path/" . $file);
$ext = $path_parts ["extension"];
if($file == "." || $file == ".." || $file == "ftp.php" )

continue;

if ($ext == "txt"){
$icon = "txt.gif";}
elseif ( $ext == "php" || $ext == "htm" || $ext == "html" || ) {
$icon = "web.gif";}
elseif ($ext == "doc"){
$icon ="word.gif";}
elseif ($ext == "jpg" || $ext == "gif"){
$icon = "img.gif";}
elseif ($ext == "pdf"){
$icon = "pdf.gif";}
elseif ($ext == ""){
$icon = "dir.gif";
} else {
$icon = "txt.gif";
}
closedir($dir_handle);
echo "</ul>";
echo "<li><img src=\"../img/" . $icon . "\" alt=\"\"/> <a href =\"" . $file ."\">" . $file ."</a></li>\n";
?>
</body>
</html>

andi get this error
Parse error: parse error, unexpected ')' in /home/www/jami3EETh/ftp.php on line 22

that is the line starting with
elseif ( $ext == "php" || $ext == "htm" || $ext == "html" || ) {

andy753421

#1. on line 22 you dont need the last ||
#2. your missing you end } form the while loop

hope that helps

jami3

ah Thanks it was like 1 am last night when i was coding this and i had school so i was kind of rushing it 😛 my code now looks like this

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>Online Ftp</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<?php
$path = dirname($_SERVER['PATH_TRANSLATED']) . "/";

$dir_handle = @opendir($path) or die ("Failed To Open $dir Sorry For The Inconvienience");
echo "<ul>";
while ($file = readdir($dirhandle)) {
$path_parts = pathinfo("$path/" . $file);
$ext = $path_parts ["extension"];
if($file == "." || $file == ".." || $file == "ftp.php" )

continue;

if ($ext == "txt"){
$icon = "txt.gif";
}elseif ( $ext == "php" || $ext == "htm" || $ext == "html" ){
$icon = "web.gif";
}elseif ($ext == "doc"){
$icon ="word.gif";
}elseif ($ext == "jpg" || $ext == "gif"){
$icon = "img.gif";
}elseif ($ext == "pdf"){
$icon = "pdf.gif";
}elseif ($ext == ""){
$icon = "dir.gif";
} else {
$icon = "txt.gif";
}
closedir($dir_handle);
echo "</ul>";
echo "<li><img src=\"../img/" . $icon . "\" alt=\"\"/> <a href =\"" . $file ."\">" . $file ."</a></li>\n";}
?>
</body>
</html>

And now i get Warning: readdir(): supplied argument is not a valid Directory resource in /home/www/jami3EETh/ftp.php on line 13
sorry for all the errors this is the first time i have tried to interact with my server files😃

mtmosier

$dir_handle = @opendir($path) or die ("Failed To Open $dir Sorry For The Inconvienience");
echo "<ul>";
while ($file = readdir($dirhandle)) {

Look closely at the variable name.

rehfeld

when your writing code/ debugging, its a good idea to set error_reporting(E_ALL);

then php will let you know about undefined variables and such.

jami3

Ah thanks 😃 i missed out the _ im no good at late night coding 😛

Errr Now i get this crap i need sleep. 😛
Warning: readdir(): 2 is not a valid Directory resource in /home/www/jami3EETh/ftp.php on line 13
that is after i fixed the underscore

rehfeld

closedir($dir_handle);

is inside your while() loop

so after the first iteration, your closing your handle. move it outside of your loop.

jami3

Ah Muchias gracias thanks soo much you like saved me from killing myself i dident have a clue what was wrong with it :S thanks again
Jamie Thompson