header writing

guest

ok i have these script i put together that gets the files and the url from the database but when i download a file (ex: a picture) it says the image is not viewable so i think there is something wrong with header printing does anyone see any errors in this?

<?
include("connect.php");
if ($id) {//if an id has been queried then...

$go = MYSQL_QUERY("SELECT * FROM downloads WHERE id = $id");//define go as a query


if(!$go) { die("Error!"); }//if there is a problem, slit wrists
$home = MYSQL_FETCH_ARRAY($go);//define home


MYSQL_QUERY("UPDATE downloads SET count = count + 1 WHERE ID = $home[id]");//update table downloads, by adding 1 to the count of the id specified
MYSQL_FREE_RESULT($go);

}
?>
<?
 set_time_limit(0); //run unlimited time


/* In kB/s */
$speed = 10; #THIS IS THE SPEED IN KB

header('Cache-control: private');
header('Content-Description: File Transfer');
header('Content-Type: application/force-download');
header('Content-Length: ' . filesize($home[url] . $home[title]));
header('Content-Disposition: attachment; filename=' . $home[title]);

if (!$file = fopen($home[url] . $home[title], 'rb')) {
exit;
}

while (!feof($file)) {
echo fread($file, $speed * 1024 * 8); #read speed in Kb x 8 bits
flush(); #do not wait send it now
sleep(1); #snorr 1 second
}

@fclose($file); 
?>

and another problem is when i have a file names like "image number2.jpg", when i download it i only see "image" and it doesnt tell you the extension so im looking for a way to add a space in this script

hkucsis

Use $rs["fieldName"] to refer to the field in your result set

dalecosp

Originally posted by guest
and another problem is when i have a file names like "image number2.jpg", when i download it i only see "image" and it doesnt tell you the extension so im looking for a way to add a space in this script

There quite a religious war that has been fought over spaces in filenames. My personal feeling is, "don't do it", and you've provided some evidence there as to why.

One strategy is the double quote such things, but without seeing for myself what's going on, I can't really offer any strategy to help you, except read, read, read and learn, learn, learn...

guest

Originally posted by hkucsis
Use $rs["fieldName"] to refer to the field in your result set

so do you mean to ues quotes for the database tables cause i tried

<?
include("connect.php");
if ($id) {//if an id has been queried then...

$go = MYSQL_QUERY("SELECT * FROM downloads WHERE id = $id");//define go as a query


if(!$go) { die("Error!"); }//if there is a problem, slit wrists
$home = MYSQL_FETCH_ARRAY($go);//define home


MYSQL_QUERY("UPDATE downloads SET count = count + 1 WHERE ID = $home[id]");//update table downloads, by adding 1 to the count of the id specified
MYSQL_FREE_RESULT($go);


}
?>
<?
 set_time_limit(0); //run unlimited time

/* In kB/s */
$speed = 10; #THIS IS THE SPEED IN KB

header('Cache-control: private');
header('Content-Description: File Transfer');
header('Content-Type: application/force-download');
header('Content-Length: ' . filesize($home["url"] . $home["title"]));
header('Content-Disposition: attachment; filename=' . $home["title"]);

if (!$file = fopen($home["url"] . $home["title"], 'rb')) {
exit;
}

while (!feof($file)) {
echo fread($file, $speed * 1024 * 8); #read speed in Kb x 8 bits
flush(); #do not wait send it now
sleep(1); #snorr 1 second
}

@fclose($file); 
?>

and i still get the corrupted image 🙁 please explain more.. im still a noobie in php

guest

ok i found this script that had more features i wanted off of php.net and i need help putting these two code snippets together i tried but im pretty sure it has to do with getting the url and title from the database so any help would be good

This is the Mysql table searching and getting

<?
include("connect.php");
if ($id) {//if an id has been queried then...

$go = MYSQL_QUERY("SELECT * FROM downloads WHERE id = $id");//define go as a query


if(!$go) { die("Error!"); }//if there is a problem, slit wrists
$home = MYSQL_FETCH_ARRAY($go);//define home


MYSQL_QUERY("UPDATE downloads SET count = count + 1 WHERE ID = $home[id]");//update table downloads, by adding 1 to the count of the id specified
MYSQL_FREE_RESULT($go);


}

// $home["url"]  -get the url to dl
//$home["title"] -get the filename to rename the dl to
?>

amd here is the script im trying to integrate into it but like the last one it does no download correct cause its file size is 0kbs

// $home["url"]  is the url to the file download
//$home["title"] is what i want the file name to the download i want to be

<?php
function send_file($name) {
  ob_end_clean();
  $path = "protected/".$name;
  if (!is_file($path) or connection_status()!=0) return(FALSE);
  header("Cache-Control: no-store, no-cache, must-revalidate");
  header("Cache-Control: post-check=0, pre-check=0", false);
  header("Pragma: no-cache");
  header("Expires: ".gmdate("D, d M Y H:i:s", mktime(date("H")+2, date("i"), date("s"), date("m"), date("d"), date("Y")))." GMT");
  header("Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT");
  header("Content-Type: application/octet-stream");
  header("Content-Length: ".(string)(filesize($path)));
  header("Content-Disposition: inline; filename=$name");
  header("Content-Transfer-Encoding: binary\n");
  if ($file = fopen($path, 'rb')) {
   while(!feof($file) and (connection_status()==0)) {
     print(fread($file, 1024*8));
     flush();
   }
   fclose($file);
  }
  return((connection_status()==0) and !connection_aborted());
}
?>

Please help im starting to get php more by more but i do not know how to work this out